From: "Levin, Alexander" <alexander.levin@verizon.com>
To: "mingo@redhat.com" <mingo@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ben Hutchings <ben@decadent.org.uk>,
Sasha Levin <sasha.levin@oracle.com>
Subject: [PATCH 1/8] liblockdep: Fix undefined symbol prandom_u32
Date: Fri, 29 Jul 2016 22:55:35 -0400 [thread overview]
Message-ID: <1469846824-20966-2-git-send-email-alexander.levin@verizon.com> (raw)
In-Reply-To: <1469846824-20966-1-git-send-email-alexander.levin@verizon.com>
From: Ben Hutchings <ben@decadent.org.uk>
__lock_pin_lock() now calls prandom_u32() which is not defined in
liblockdep. __lock_pin_lock() and its caller lock_pin_lock() are dead
code in liblockdep, but we still need to provide a definition of
prandom_u32() in case lazy binding is disabled.
Fixes: e7904a28f533 ("locking/lockdep, sched/core: Implement a better ...")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
tools/lib/lockdep/lockdep.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/lib/lockdep/lockdep.c b/tools/lib/lockdep/lockdep.c
index a0a2e3a..443acb1 100644
--- a/tools/lib/lockdep/lockdep.c
+++ b/tools/lib/lockdep/lockdep.c
@@ -1,8 +1,15 @@
#include <linux/lockdep.h>
+#include <stdlib.h>
/* Trivial API wrappers, we don't (yet) have RCU in user-space: */
#define hlist_for_each_entry_rcu hlist_for_each_entry
#define hlist_add_head_rcu hlist_add_head
#define hlist_del_rcu hlist_del
+u32 prandom_u32(void)
+{
+ /* Used only by lock_pin_lock() which is dead code */
+ abort();
+}
+
#include "../../../kernel/locking/lockdep.c"
--
2.7.4
next prev parent reply other threads:[~2016-07-30 3:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 2:55 [PATCH 0/8] liblockdep fixes for 3.8 Levin, Alexander
2016-07-30 2:55 ` Levin, Alexander [this message]
2016-07-30 2:59 [PATCH resend " Levin, Alexander
2016-07-30 2:59 ` [PATCH 1/8] liblockdep: Fix undefined symbol prandom_u32 Levin, Alexander
2016-07-30 3:02 [PATCH resend 0/8] liblockdep fixes for 3.8 Levin, Alexander
2016-07-30 3:02 ` [PATCH 1/8] liblockdep: Fix undefined symbol prandom_u32 Levin, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469846824-20966-2-git-send-email-alexander.levin@verizon.com \
--to=alexander.levin@verizon.com \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.