From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49307)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bFfKb-0001r4-2J
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 06:24:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bFfKZ-0007FK-4k
	for qemu-devel@nongnu.org; Wed, 22 Jun 2016 06:24:23 -0400
References: <1466528974-12183-1-git-send-email-peter.maydell@linaro.org>
	<1466528974-12183-7-git-send-email-peter.maydell@linaro.org>
	<20160621184552.p7trf4zpqnrmwruu@hawk.localdomain>
	<CAFEAcA_AnYGV0jy9HAUevHPB=FY3NP25-7BUpdbySZS-QPeGrg@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <146dd497-f988-3b17-3f05-454ee7e97680@redhat.com>
Date: Wed, 22 Jun 2016 12:24:13 +0200
MIME-Version: 1.0
In-Reply-To: <CAFEAcA_AnYGV0jy9HAUevHPB=FY3NP25-7BUpdbySZS-QPeGrg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 6/6] hw/arm/virt: Set minimum_page_bits
 to 12
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Andrew Jones <drjones@redhat.com>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, Patch Tracking <patches@linaro.org>



On 21/06/2016 21:47, Peter Maydell wrote:
>> >
>> > As this breaks migration, then I guess we also need
>> >
>> > @@ -1507,5 +1510,6 @@ static void virt_machine_2_6_options(MachineClass *mc)
>> >  {
>> >      virt_machine_2_7_options(mc);
>> >      SET_MACHINE_COMPAT(mc, VIRT_COMPAT_2_6);
>> > +    mc->minimum_page_bits = 10;
>> >  }
>> >  DEFINE_VIRT_MACHINE(2, 6)
> Doesn't hurt, but are we trying to claim migration
> compat between different QEMU versions with the
> versioned-machine names ?

For PC machines we are (but only towards newer QEMU versions).

Paolo