All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Alex Briskin <br.shurik@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3 v6] mac80211: Refactor ieee80211_iface_work
Date: Mon, 01 Aug 2016 14:20:05 +0200	[thread overview]
Message-ID: <1470054005.17912.4.camel@sipsolutions.net> (raw)
In-Reply-To: <1468693140-19483-1-git-send-email-br.shurik@gmail.com> (sfid-20160716_201936_943619_6A75EF74)

Please don't submit three patches with identical subject.

> Added ieee80211_iface_work_handle_pkt_type function. Moved part of

Should also use present tense here - "Add ... function, move [...]".

This also applies to the other patches.

The if/else if/... -> switch change should also be part of this patch,
or separate, but not squashed together with a different unrelated
change. Might be worth moving "return 0" into each of the cases and
return an error in the fall-through, but it doesn't really matter.


johannes

      parent reply	other threads:[~2016-08-01 12:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-16 18:18 [PATCH 1/3 v6] mac80211: Refactor ieee80211_iface_work Alex Briskin
2016-07-16 18:18 ` [PATCH 2/3 " Alex Briskin
2016-08-01 12:20   ` Johannes Berg
2016-07-16 18:19 ` [PATCH 3/3 " Alex Briskin
2016-08-01 12:23   ` Johannes Berg
2016-08-01 12:20 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470054005.17912.4.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=br.shurik@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.