From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753828AbcHANTW (ORCPT ); Mon, 1 Aug 2016 09:19:22 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36250 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283AbcHANSu (ORCPT ); Mon, 1 Aug 2016 09:18:50 -0400 Date: Mon, 1 Aug 2016 15:18:40 +0200 From: Michal Hocko To: Vladimir Davydov Cc: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160801131840.GE13544@dhcp22.suse.cz> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 01-08-16 16:03:10, Vladimir Davydov wrote: > We must call shrink_slab() for each memory cgroup on both global and > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > changed that so that now shrink_slab() is only called with memcg != NULL > on memcg reclaim. As a result, memcg-aware shrinkers (including > dentry/inode) are never invoked on global reclaim. Fix that. > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere. > Signed-off-by: Vladimir Davydov The fix looks ok to me otherwise Acked-by: Michal Hocko > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 650d26832569..374d95d04178 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2561,7 +2561,7 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc) > shrink_node_memcg(pgdat, memcg, sc, &lru_pages); > node_lru_pages += lru_pages; > > - if (!global_reclaim(sc)) > + if (memcg) > shrink_slab(sc->gfp_mask, pgdat->node_id, > memcg, sc->nr_scanned - scanned, > lru_pages); > -- > 2.1.4 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbcHANTf (ORCPT ); Mon, 1 Aug 2016 09:19:35 -0400 Received: from mail-db5eur01on0139.outbound.protection.outlook.com ([104.47.2.139]:9280 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753327AbcHANSu (ORCPT ); Mon, 1 Aug 2016 09:18:50 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=VDavydov@virtuozzo.com; From: Vladimir Davydov To: Andrew Morton CC: Mel Gorman , Hillf Danton , Johannes Weiner , "Vlastimil Babka" , Michal Hocko , Joonsoo Kim , Minchan Kim , Rik van Riel , , Subject: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Date: Mon, 1 Aug 2016 16:03:10 +0300 Message-ID: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM4PR0501CA0001.eurprd05.prod.outlook.com (10.167.83.139) To HE1PR0801MB1866.eurprd08.prod.outlook.com (10.168.94.9) X-MS-Office365-Filtering-Correlation-Id: 49873afe-7e71-43f4-9edc-08d3ba0c33c1 X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1866;2:+OLbg6uhc/JSiDP+sKRX5wAdbQssp8sVGpS6v2I45s0E7pyaX1GbCn1Gkj77D3b998S9K4DWi6LgoOh+W8seMUw6bOZ8GIgu6Ut8iO/j7S4VlV41Dzmj4//VMdcHybY48zmVNilhVFmz13hkna+j6r/Y02zVqOgtU1k0qYKwi560wumr5i8PwCPfkius4l4H;3:aix8XibK0VmXT7r3Lf8OVKjbG4tlCQZ63lX+ejdLwjDZdFirIZy551i63BFSjAuBkDZZyV0/UpZ6N5BGq8DEYM+15nwSP+xA01h00FCEfMbGNKOlcKmYoAEhUoIFUbyJ;25:f+pZZyrzbWgfki6j6+wzGhfnAcEfieCAAtHzeGwqCsxHq8jjBjKmpYFHCECu3HybOJhkEv6ov+eAL3mG3uiPbTR+k8suqZJQypQaiIX4Hd4KGPDAOiGmJoJ52AwutO99yNhWWUAsWVvu3kr4KzkDDkLvHhSzuEsRJKYu6UxXl2FUCEBG+uKNrSWZd1hj9tMpRGuWZ4wnVn1BfEjFqTQizfm89GYMZNdb5seo8c/B4z89l2L5uklY59TzXtpqCtTQLr6NmE+lQwJ2M4zyNv8O8eHDYk2z64qYX3FBNiGzoS7/F3CuB2EAWe4cH9Ugn+o0txmldkas444G/pwUvQZVDcdWrK7ioPqXNwYhDhQ55r18t5lbwCF4Q2Z/O7fiwttrUwzAw6QfuASNjzRC61icEr1vhGYDOpMGPqlk+7S1Jeg= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1866; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1866;31:7pixTDfqL13vMas4cKkZgi2z2GtASGpn6o7aSoTK4N3dwoCa8XXGl09x6Z3//A1hQ9SI/bRpBRuFkmkNpbnPQ5cKhlNJL2/UQkCCj8XaMJ5pOj1ScqONQgKPDt777ThOONhhG6VaEQWEMS8GCWWGQWLenHvGUlVagVPKusIYiSHStwOx8Urc/iufI/XKQskrwwzZk8RJ4D+/4irnQlsztjThqNn54zVef98+ODLMoQA=;4:RxgdOTGwR+pIOPx2rXWung21/LaqSNlnzgf16/AK9XguLMSDqipsqnqDo2ogVq6xOygNZv3rCo7QFo8ESiPnBPIesNiN4zw8IwWS5nnITPJsvxSSJS3gfFYN+PMTXo97Od+4Gga9coea1JQ7sO0a/tmXhp1tGqkhtzehNFjw/Ud87zhKq/nqE9XjMmVGJ8vMuIH0RCRzSMvPx/miPYdsBwZm+ZwvwtHHe7CXGn8ygfl7j4u66wEzXSPl0EeEFb3+aMVtXWCHkA4FMwogUMQY6LcJi4tiYoJ/i2TMwNlFJ5wq3o+t3ErfqO1Qrjz7Oz80J4oOMCc+BIFcCIOT1s+K7FrbE7Fx3ntxaJWv/mNyH+voBBUOMXUY+h0MQck4s/qYe+12pFHEaRIxWFxeOJ6ilEz/uWsytxYJ2/k+dJ8T8yE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041072)(6043046);SRVR:HE1PR0801MB1866;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1866; X-Forefront-PRVS: 0021920B5A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(66066001)(80792005)(77096005)(7416002)(86362001)(50226002)(47776003)(68736007)(48376002)(8676002)(2906002)(81156014)(81166006)(97736004)(106356001)(50466002)(36756003)(50986999)(110136002)(586003)(305945005)(189998001)(101416001)(4326007)(69596002)(6116002)(21086003)(92566002)(3846002)(19580405001)(105586002)(19580395003)(7736002)(7846002)(33646002)(42186005)(229853001)(5003940100001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB1866;H:virtuozzo.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0801MB1866;23:tve4VdkpLRRtnbu2pX8hHeecXLUVNpWDE6fBhHH?= =?us-ascii?Q?uR+FCZSubtjPbxsRBwhdHCpXIOBdQbdgJGdtUZpg1iPpXRDJjY6FaIPWV1H4?= =?us-ascii?Q?Uq+hHy5iYfQTTV9mRjykWwfwyWadZ42wwGVZGzp4w0hznT2yhO0e0zdoOqM4?= =?us-ascii?Q?AFjUv7QEaQvvpf/JxFM4L1N46CzjqPxkrb+D5EdGUn+mZsSNyFTNp+fAAhiP?= =?us-ascii?Q?cGuf0sHMPBlfUfxcMnb4CNxzV1ZZkHtuw7ENOTjxItXcuUoFSDbmMrGw04+O?= =?us-ascii?Q?CCdypxdAizjmtD0CQiNuXbECa2C3bi0YuSy2THOV4enitkhb2gk0jhvcPVC9?= =?us-ascii?Q?RZ+AyplU5GlSKgHUcy3LHn8SgfeYzJ6eZoviz2tvrxDYtYyuBC8XWB3PrFTO?= =?us-ascii?Q?o7bJrSqTVlUABkE31cBX56RD/S/IHTMB0n2LbtBa3+pkXpnaioEiILSGBPkb?= =?us-ascii?Q?yfpc0tnN+nPulQuFhRhMckRCOxufn7N2wQK9KpYGOq53l15dhSHn+wU7uuy9?= =?us-ascii?Q?KyJgTh6mWncuGFHCuWyFs0B+IC7tCIVxhBTl8d8f2l2GUkINJkEk69QvONSr?= =?us-ascii?Q?N+TTa1J/poLnmVj3KpGzbVq+3Cjw+gsaIVovYgoYZjfSZWt4L1i0ilvBBVUZ?= =?us-ascii?Q?gFWkr2bmaLY7VhXe5JVJgb2ChKm6p8WRwjRgV4pLPQNi1zyF6aTkstxAfFNX?= =?us-ascii?Q?6upHjaFyLFnSIH6gs+hcBkt7brz3Y3MKxYwD875UErg+rI2uqrxp+BllOOLS?= =?us-ascii?Q?IfCbObb+e9btsj7+aXYbkPx5ezjGLRYLAsapxWnMSaiCgZfTZecrE37onwAr?= =?us-ascii?Q?Q5Hiw7fFkGw7qvQKhIgI0o4vNeL3vOrBAHid+PFr3uyQmhHYcRwsdNoQBKlI?= =?us-ascii?Q?GPt3NKZ0rrxNC8oZEVZ/C0J+c3E8Met7r+fQwRGwNOzOandrQTm1iovhaVh8?= =?us-ascii?Q?62vc9u7K+u55hmz1wCkz19TcF7b+GR9WkFk79a0FptEZRdx7XLxgMGJbsxd+?= =?us-ascii?Q?uXFzgmTrIkD2FoJLvjhTwBwAEULYwMoC0nihhcpQWtq/HJ4JMhOtQehp5Y6I?= =?us-ascii?Q?FDZIjcPTHsRUrCwQUMRIzNQzfVqRu?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1866;6:oV0Zzg8l102x3WAC6/GjoVmqBr7Gowb4NJ9cidwoKgr3LN15HQ67Bee5XuPBx9V04q329Cn49UVegoBpYBkBawjjpBx5CmAzMAAJ+f3EzGtlaJ678EygZXpz39nst9AR2zlCEgivzieZ4ed0R/ziKPEq6erItV151uX1j70dYvQ47+OjFKTXNhs829625fHD2FdiTJPnJi63c4MHId0XFTIGNeDPx2hpx3EI8MJDFKnzp5wCSgG0ysI8bk8hvLT7YdrRv7EieCWaR9qMZO7GkHAtolJtG0tST/qeGTetXRP4FtFX3EzdAPoYczYmY/Z0;5:oKYWd2Wz71I1FRDhRcHqYaDUcGhXUPBrbWPOcgroYvIJVcdkTXPPPtH3D0S1TRtnzmUa327Sfm4QB6QTD+pF0uBCSD2uF243R7gFjWoZTWQ2jQCbQNaDJ54FoqRuUCxYP+GjyGldC8PaNLAMO7yYRQ==;24:Tk5jneugmL7tG2T9DWnZHA1LQBxkUZmUXApIxxCwFc7ypFDOut4MZxcfNwvUGgqX93mugiTmw8dphSIVaKrBzPggLI3FVYTLTD4sguLveBc=;7:z+N8kCsV4faqQwBfPvSXQKhxBj1lyUatxKxau9aazmJHoEu9QzZHkOOwC2OlMhacV5RN4UFw5xtb04gFWC3IDxk1Qhq9x/E0vXFdrH1QvXoakwdUqn6h1BusLxV9FnAAk/M3xM9iNsbKaUa3JyHPK6p/TrrgzAZsUBEcp2ruvQp+uS/G2QioqkvlHBoy49CelDLUzT/+3mgMw56BXTKTtleVOA6t8JHqndcB/YzSmS1XUV17+EWJXi7X5eWK0hGS SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1866;20:SQeG81HOI4ceYmNbb0AhlEaJvIxCbpvoPhxwwzXEAcBcW2DQQSzMzm47YEQjQe9KxN+bX3mVATg6haGuUGXqFJ77opr1lGanwGkk/B8LJvmwppgVUJ6WRnf5BwHSMn+VDoBsTSNntPjju2NFYnO0R3RaqgyWlWQUvPA7CVr0KxM= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 13:03:14.9243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1866 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We must call shrink_slab() for each memory cgroup on both global and memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally changed that so that now shrink_slab() is only called with memcg != NULL on memcg reclaim. As a result, memcg-aware shrinkers (including dentry/inode) are never invoked on global reclaim. Fix that. Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") Signed-off-by: Vladimir Davydov --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 650d26832569..374d95d04178 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2561,7 +2561,7 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc) shrink_node_memcg(pgdat, memcg, sc, &lru_pages); node_lru_pages += lru_pages; - if (!global_reclaim(sc)) + if (memcg) shrink_slab(sc->gfp_mask, pgdat->node_id, memcg, sc->nr_scanned - scanned, lru_pages); -- 2.1.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753919AbcHAN1M (ORCPT ); Mon, 1 Aug 2016 09:27:12 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35227 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753322AbcHAN1H (ORCPT ); Mon, 1 Aug 2016 09:27:07 -0400 Date: Mon, 1 Aug 2016 15:27:04 +0200 From: Michal Hocko To: Vladimir Davydov Cc: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160801132703.GF13544@dhcp22.suse.cz> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> <20160801131840.GE13544@dhcp22.suse.cz> <20160801132145.GA19395@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160801132145.GA19395@esperanza> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 01-08-16 16:21:45, Vladimir Davydov wrote: > On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote: > > On Mon 01-08-16 16:03:10, Vladimir Davydov wrote: > > > We must call shrink_slab() for each memory cgroup on both global and > > > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > > > changed that so that now shrink_slab() is only called with memcg != NULL > > > on memcg reclaim. As a result, memcg-aware shrinkers (including > > > dentry/inode) are never invoked on global reclaim. Fix that. > > > > > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > > > > I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere. > > I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's > d71df22b55099. But this sha is unstable. THe patch you are referring to is already sitting in the Linus tree so please use his (stable sha instead). -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120AbcHAP6M (ORCPT ); Mon, 1 Aug 2016 11:58:12 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:55658 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbcHAP6C (ORCPT ); Mon, 1 Aug 2016 11:58:02 -0400 Date: Mon, 1 Aug 2016 11:15:08 -0400 From: Johannes Weiner To: Vladimir Davydov Cc: Andrew Morton , Mel Gorman , Hillf Danton , Vlastimil Babka , Michal Hocko , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160801151508.GB7603@cmpxchg.org> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 04:03:10PM +0300, Vladimir Davydov wrote: > We must call shrink_slab() for each memory cgroup on both global and > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > changed that so that now shrink_slab() is only called with memcg != NULL > on memcg reclaim. As a result, memcg-aware shrinkers (including > dentry/inode) are never invoked on global reclaim. Fix that. > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > Signed-off-by: Vladimir Davydov Ouch, I missed that in the review. The change looked so obviously correct, but the shrink_slab() interface is a little deceiving. It would be great if shrink_slab() could handle root_mem_cgroup/NULL and then we'd always call it from inside the loop. But AFAICS we need the global call to get the cumulative scanned/lru_pages ratio from all of the memcgs reclaimed... grr. Oh well. This fix looks correct to me, anyway. Acked-by: Johannes Weiner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754976AbcHAT7d (ORCPT ); Mon, 1 Aug 2016 15:59:33 -0400 Received: from mail-db5eur01on0115.outbound.protection.outlook.com ([104.47.2.115]:32255 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754887AbcHAT70 (ORCPT ); Mon, 1 Aug 2016 15:59:26 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=VDavydov@virtuozzo.com; Date: Mon, 1 Aug 2016 16:21:45 +0300 From: Vladimir Davydov To: Michal Hocko CC: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Joonsoo Kim , Minchan Kim , "Rik van Riel" , , Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160801132145.GA19395@esperanza> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> <20160801131840.GE13544@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160801131840.GE13544@dhcp22.suse.cz> X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM4PR01CA0016.eurprd01.prod.exchangelabs.com (10.164.74.154) To AM5PR0801MB1860.eurprd08.prod.outlook.com (10.168.157.17) X-MS-Office365-Filtering-Correlation-Id: 3569b7e3-294a-4e07-79c1-08d3ba0ecc1a X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1860;2:4MmI0wLubrYeL7b/NLpP19cdcrQ9Oo6hDpwjm+jJi+tKaMAo3Qgr5oaNb6qwDt6/xGyn7yeB43NMxAtQvEqfrtUgA75JvyqEz641kevK73m522wsPQkj4WnS6c5Bc+C4qfYlpjNA7Eo0KxhEQDcTa8gVV2tk2ua1LaWd19iQequciz4Fp4NTGexFRB5xEeH7;3:t9pGnPy5Qd0INT36wYtFn+8LgPqhNZc5u4aLlLAgI0M7vVYB7Bqf2QO04kk/qd0+SQRqKkANo1mQNn0wDzWnym7mCXK8zi0HOGkEmLw+3kBKv2AgoFyuU0rK3CPCmSnT X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB1860; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1860;25:PS4om35VX+CCqbt1sB4BmFb4qQMDbnY1YawkQ/9gjtEyBQuI2sRFPO2QxgfxkTCrssi2nOaNjo9G8PVRY8rLaySkgkga2WzybUnp25qonjULASJ5TkOiB+h08sKex9kj1teIR0TyTsEgI+cb1NNvlu/mbFRcIweEiGwUHQ21VrsfE7GmU7zY/1NwN3Ko+57jrrEXWZNt1FlD7JrJbCsIgrkGE5o3B2gKWa2oyjmCN1ZA6gM83U8nlantWneIiUUKB5rR2q5vAdpO/AaIscg3e1NZFt572DGsGUsIr+7kgbG8l1Q1JAQjJzKwLUURXDYujNeV7N7e+nKpGx1ugVi+djNqWSf1oGbC1bcYj3PVi51tfMo06exIuyb9913ugayhZOD2cHHVex21mbxPjhV/EHPfHzI741jYajMbGBrl0sq8tblZj0msddTQk6YbARr4PeI2WbpRIYlDkJABlN3kwNTZOSd0lRGXxL/5VtwwRAezN33AwYGq2W0kb4HIioIVxb7Id0RnlIiUhRez3Jkdo/x5thGH34piWYNGRMaW+qnSCBERAEUunO5Eqw1eeu3uJoed09YvZTyrCS1VmUiYLr1/p/X1DDDFrsKWQxnl4Z9RE4tW0+m6mreo1BEIdWVgEfT/te7njwbv0dCl0rAElZNNqoGBCgUNXjO9SIhZfd/Hhk/B064B59K3lsh+VJuUY/zEKGCUXL4zxirdJaeNAw==;31:Hju99lh/C8M82Za6siKIXMkYJndPyd76+q56qbAbH1enoT1AbekFditZ5sjCmQuJ7rpbk2+fwscWA2F8Q5Bcg93mSFCVXFW7p3cTpH5zOwnXXVH4UeYmfepjm3elz57M3hC7iyW7WkNCERMYna/iqAtqYzTqKxQblfSPpT3+RvstFloBeNgLZf1DZR4PL5iPQQ6ugdlEXnub9PumnaEJ/Qmdg/7AFzInoiWmz3HHmWM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041072)(6043046);SRVR:AM5PR0801MB1860;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB1860; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1860;4:KEoJ6hHEjFQE9L9vlMHhz605PYlUXNwAJ9J9SehkMEuSY28SM8TDB+FYhUYzjAV4IxBSbNyuUQ68KSInNVnQfZbcy8a6gPjDpb9jKfx3uX8+pCPus90OeJ4uB/fBvfD2m2g4cRq2TN5Y2GnIjEKJl1/pIpWDjvpkm6uGOW8MfaD6BOzaeKeqUktSi/xUTzS2/EvRhQ9dcZGvEF2uFZmGp66dgWcVcf1szcwxEfJu2sAoznjUtxBIMXaV/1Jd58lw3iRVn8G+i3IiPvIKgQItUnN336kWw2rL7XCmgVMM7lAD0qwxNO7tUKdyXQMz8rHpNhfn5g8VnhaTa33rioS8EPLS1p8F9ZbRInUE3K6hNrrd8eSMdYAwyI/IwLs6QRw9Uj8IBoxMAm68NE6pNvQ/mr5mceYq/YyM+Zk2GJJvles= X-Forefront-PRVS: 0021920B5A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(377424004)(189002)(199003)(24454002)(105586002)(101416001)(47776003)(8676002)(92566002)(106356001)(86362001)(33716001)(4326007)(42186005)(2906002)(305945005)(19580395003)(19580405001)(3846002)(586003)(33656002)(7416002)(23726003)(97736004)(46406003)(7736002)(6116002)(2950100001)(9686002)(1076002)(77096005)(110136002)(50466002)(189998001)(80792005)(7846002)(81166006)(54356999)(81156014)(97756001)(76176999)(66066001)(50986999)(68736007);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0801MB1860;H:esperanza;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM5PR0801MB1860;23:Vhdq09uSqRNTDiE3ofKQphvk0XZfMJtLRCpPYcW?= =?us-ascii?Q?odYrKYpz2hzq/vU+8AP34pQv14hPoqpppTODIY1RXMWbxvQksTCoKaC24+KR?= =?us-ascii?Q?R+aisxhiipLeeaT+r7kTHJ9w8fVVFw4QIAMMBdN9L1g6/3VkbHyK8QMW5Li9?= =?us-ascii?Q?v4Xa4ABf7Qt2286rI5/UiU8iVXeiYtSPGjVekQRPYcMrMLcwGvKVwUHIdGVS?= =?us-ascii?Q?hP7K+ePcQcro5e+F2lLwEjFkatnuWsCYy8VrdfheB3dxqQlSGyBOtGEjzX4o?= =?us-ascii?Q?n7yEJfvfFrZAIV5eFxNlQMPvQ2Nt0rJodgPTt9QAzTLPAimwxQWg/LccJCIu?= =?us-ascii?Q?vPu+WUsuzdniHlkEhATSV0zsP/GPCX+YZRP7SjrTvzNS5oJzCDagIlgSFMBZ?= =?us-ascii?Q?cZ0Lf2VM/+p4qiVu/sO18Axli/xpMJqnoyofddBJ3I3TrkFHqQql3uiKMf77?= =?us-ascii?Q?zupKyPRdbt5CCgEffiIxeOMhfWUsmT0pc9gKjQHqQNVnLvzoCttaEp3A7KzJ?= =?us-ascii?Q?uS/v1q8nL/Sh+AkVbPzWdjQkmEtyizVHr0ySOyFg5gr1f0FVP8PcwFDR1Vtd?= =?us-ascii?Q?prnm2R2n8ef2pLKBENLieZMcb8+eqg5vcK4L24VwKb3Yx5MHS8VpF/b0p5v4?= =?us-ascii?Q?FvECfvBDRgT+95NL7PLXlt84KAVB04ghQdp4PigyVGlxFbfgSZwQfV4ub2V8?= =?us-ascii?Q?k26zhmoTB/NzaVmMWftxFgrpHEw7HEKBEZbBPL68OiQpWm/lLI+VcDAUH+p/?= =?us-ascii?Q?t3khVdBnyOyXhvp4yDH77/BDtiFwghzhPTw1BqdAf6FzcC/HieW+YK+jEe+z?= =?us-ascii?Q?UyxbJozuRq8c2CLEmo85ZncmQkalGFuPu6jLJk8h9rqW35ITuCpI4LplQQsO?= =?us-ascii?Q?AxVaWOkVX6x06aYcM6E1heIyc0sWDKooYE4Sr1RLqVEGsZxRl7AMi6xfooGm?= =?us-ascii?Q?uJSym9Xgi0pZ2ioM8/+6G+Ld39B9qmqHKyk1az4hpeYPR3ruaalrFHhhVatW?= =?us-ascii?Q?XmkrtI/8TALKntLR9DN1HD2I1/5uXYVB9/bpCqNqTky+YXW0DTDkEpuwcQhS?= =?us-ascii?Q?Exhn+C/khckf73ykc7DP8d7PokvhVwsjHBjcXYqVJPrdeoRdclabOijRNGOn?= =?us-ascii?Q?trOKmV1pvG6iGlE/SaMiSL+148atT/MYsAB5rUylRuLQeHQ5NrqEiyw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1860;6:K4otSFJ7dZV1tUun8sKonRwqr/SBibDmZyo/cAgZLz3XNEY3urPu0FaXlkHChNT1+nD3qF4ykVf3coSbJ1dadI7M1mZTZxKiKbtMFVI4bT4ZCydxKhDu+ggl3kR6ZsYJpAwIW46xYCfov/6NfyqLBlilh0HaV7CtZ2UqddoxoikbrgQDZiOmVDQ9AJwp1ryqwU4h11fPo6jfIx4JSzvO/t64cUVFwLTRkDE9hyhXz6nxTHnQBh5xDtcRw+VujPM4SCmNnBsdRBaQ8DL6czcxX9HwSotTLJNKZoqwUI4abapi8K/rJJqwqDRN6oQxW4pg;5:1mUHtgCJ11r8MKXKaNQ0qlwUXqwB4nWHqUqHOwdyEcAAr92Z06lrbvbgS1l26hy6Ptn7iAclRhwVyUWZW+JkZkRDylVCYyGOkt5mW9P6zh1jWG37xs51fFGmxronBaGppbejl/hSc9P5+zyHmTvGcg==;24:uwh10N8Fnvlli+UsadqvWFSCmUWmIFplDxoF5KJJjekQyw68YKfW/1KhYC8oB5WZRMqqtxgPVHrwGIJEiARCp4FquYWj3wUiHG6J3DaNPXM=;7:6GgHAE3TzbdZ7SNqIMirPZ5cMke6AZnz+FtISlnBk8lNiB5bzOZ/C2T38tyv0ElVL14zc+XZ5YPMbgeaZKzMpS9hlqKM0bTb0tl3E8dbc0k3c9aXEGvdsdC8QjU/LZhp83AKk7twIetrnW0qlZDYkgxGeAICfqIYr3ZpuKKkujJ+Liwb7bx5i61cC63KNF5XspuiMcidZ+/R3hqiawRfKMutCzbnZ3tJu0uG1IZ/J6QyhEvwTIoe8NSaH1O3gouD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB1860;20:9ucw1tiem6KjBafByEcuY+yCVDXr/+Ca0Z7QbAU4DcVBhwbS3+oj+dFYEDtYF8JRMl3fO76aad164gRHvQozt1mLy6TTSoVUWxsu/3iJ0WlERNILefjBswe0xpZCXfZzsuEm5BevLkybIvrgm9S3oO3DaM4vuWFFuFQpVmsccQI= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 13:21:49.9452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1860 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote: > On Mon 01-08-16 16:03:10, Vladimir Davydov wrote: > > We must call shrink_slab() for each memory cgroup on both global and > > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > > changed that so that now shrink_slab() is only called with memcg != NULL > > on memcg reclaim. As a result, memcg-aware shrinkers (including > > dentry/inode) are never invoked on global reclaim. Fix that. > > > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > > I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere. I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's d71df22b55099. > > > Signed-off-by: Vladimir Davydov > > The fix looks ok to me otherwise > > Acked-by: Michal Hocko Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755514AbcHBAZo (ORCPT ); Mon, 1 Aug 2016 20:25:44 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:39444 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755486AbcHBAZl (ORCPT ); Mon, 1 Aug 2016 20:25:41 -0400 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.204 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Tue, 2 Aug 2016 09:11:38 +0900 From: Minchan Kim To: Vladimir Davydov CC: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Michal Hocko , Joonsoo Kim , Rik van Riel , , Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160802001138.GB6770@bbox> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/08/02 09:10:37, Serialize by Router on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/08/02 09:10:37, Serialize complete at 2016/08/02 09:10:37 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 04:03:10PM +0300, Vladimir Davydov wrote: > We must call shrink_slab() for each memory cgroup on both global and > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > changed that so that now shrink_slab() is only called with memcg != NULL > on memcg reclaim. As a result, memcg-aware shrinkers (including > dentry/inode) are never invoked on global reclaim. Fix that. > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > Signed-off-by: Vladimir Davydov Acked-by: Minchan Kim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753327AbcHBJdF (ORCPT ); Tue, 2 Aug 2016 05:33:05 -0400 Received: from outbound-smtp02.blacknight.com ([81.17.249.8]:33788 "EHLO outbound-smtp02.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbcHBJci (ORCPT ); Tue, 2 Aug 2016 05:32:38 -0400 Date: Tue, 2 Aug 2016 10:32:08 +0100 From: Mel Gorman To: Vladimir Davydov Cc: Andrew Morton , Hillf Danton , Johannes Weiner , Vlastimil Babka , Michal Hocko , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160802093208.GH2799@techsingularity.net> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 04:03:10PM +0300, Vladimir Davydov wrote: > We must call shrink_slab() for each memory cgroup on both global and > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > changed that so that now shrink_slab() is only called with memcg != NULL > on memcg reclaim. As a result, memcg-aware shrinkers (including > dentry/inode) are never invoked on global reclaim. Fix that. > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > Signed-off-by: Vladimir Davydov Acked-by: Mel Gorman -- Mel Gorman SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f70.google.com (mail-it0-f70.google.com [209.85.214.70]) by kanga.kvack.org (Postfix) with ESMTP id EDBBD6B0005 for ; Mon, 1 Aug 2016 09:03:20 -0400 (EDT) Received: by mail-it0-f70.google.com with SMTP id c126so184346699ith.3 for ; Mon, 01 Aug 2016 06:03:20 -0700 (PDT) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50095.outbound.protection.outlook.com. [40.107.5.95]) by mx.google.com with ESMTPS id e136si27714269ioe.224.2016.08.01.06.03.19 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Aug 2016 06:03:20 -0700 (PDT) From: Vladimir Davydov Subject: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Date: Mon, 1 Aug 2016 16:03:10 +0300 Message-ID: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Michal Hocko , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org We must call shrink_slab() for each memory cgroup on both global and memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally changed that so that now shrink_slab() is only called with memcg != NULL on memcg reclaim. As a result, memcg-aware shrinkers (including dentry/inode) are never invoked on global reclaim. Fix that. Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") Signed-off-by: Vladimir Davydov --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 650d26832569..374d95d04178 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2561,7 +2561,7 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc) shrink_node_memcg(pgdat, memcg, sc, &lru_pages); node_lru_pages += lru_pages; - if (!global_reclaim(sc)) + if (memcg) shrink_slab(sc->gfp_mask, pgdat->node_id, memcg, sc->nr_scanned - scanned, lru_pages); -- 2.1.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f70.google.com (mail-lf0-f70.google.com [209.85.215.70]) by kanga.kvack.org (Postfix) with ESMTP id E746E6B0260 for ; Mon, 1 Aug 2016 09:18:44 -0400 (EDT) Received: by mail-lf0-f70.google.com with SMTP id 33so75272504lfw.1 for ; Mon, 01 Aug 2016 06:18:44 -0700 (PDT) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com. [74.125.82.65]) by mx.google.com with ESMTPS id tm3si31325574wjc.108.2016.08.01.06.18.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Aug 2016 06:18:43 -0700 (PDT) Received: by mail-wm0-f65.google.com with SMTP id o80so26131567wme.0 for ; Mon, 01 Aug 2016 06:18:43 -0700 (PDT) Date: Mon, 1 Aug 2016 15:18:40 +0200 From: Michal Hocko Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160801131840.GE13544@dhcp22.suse.cz> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> Sender: owner-linux-mm@kvack.org List-ID: To: Vladimir Davydov Cc: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon 01-08-16 16:03:10, Vladimir Davydov wrote: > We must call shrink_slab() for each memory cgroup on both global and > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > changed that so that now shrink_slab() is only called with memcg != NULL > on memcg reclaim. As a result, memcg-aware shrinkers (including > dentry/inode) are never invoked on global reclaim. Fix that. > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere. > Signed-off-by: Vladimir Davydov The fix looks ok to me otherwise Acked-by: Michal Hocko > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 650d26832569..374d95d04178 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2561,7 +2561,7 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc) > shrink_node_memcg(pgdat, memcg, sc, &lru_pages); > node_lru_pages += lru_pages; > > - if (!global_reclaim(sc)) > + if (memcg) > shrink_slab(sc->gfp_mask, pgdat->node_id, > memcg, sc->nr_scanned - scanned, > lru_pages); > -- > 2.1.4 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f70.google.com (mail-it0-f70.google.com [209.85.214.70]) by kanga.kvack.org (Postfix) with ESMTP id 5093E6B0260 for ; Mon, 1 Aug 2016 09:21:54 -0400 (EDT) Received: by mail-it0-f70.google.com with SMTP id d65so10456620ith.0 for ; Mon, 01 Aug 2016 06:21:54 -0700 (PDT) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00103.outbound.protection.outlook.com. [40.107.0.103]) by mx.google.com with ESMTPS id r10si19328303oih.174.2016.08.01.06.21.53 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Aug 2016 06:21:53 -0700 (PDT) Date: Mon, 1 Aug 2016 16:21:45 +0300 From: Vladimir Davydov Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160801132145.GA19395@esperanza> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> <20160801131840.GE13544@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160801131840.GE13544@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote: > On Mon 01-08-16 16:03:10, Vladimir Davydov wrote: > > We must call shrink_slab() for each memory cgroup on both global and > > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > > changed that so that now shrink_slab() is only called with memcg != NULL > > on memcg reclaim. As a result, memcg-aware shrinkers (including > > dentry/inode) are never invoked on global reclaim. Fix that. > > > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > > I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere. I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's d71df22b55099. > > > Signed-off-by: Vladimir Davydov > > The fix looks ok to me otherwise > > Acked-by: Michal Hocko Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f71.google.com (mail-wm0-f71.google.com [74.125.82.71]) by kanga.kvack.org (Postfix) with ESMTP id CCAE1828E2 for ; Mon, 1 Aug 2016 09:27:06 -0400 (EDT) Received: by mail-wm0-f71.google.com with SMTP id 1so82361719wmz.2 for ; Mon, 01 Aug 2016 06:27:06 -0700 (PDT) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com. [74.125.82.66]) by mx.google.com with ESMTPS id sj15si31363785wjb.130.2016.08.01.06.27.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Aug 2016 06:27:05 -0700 (PDT) Received: by mail-wm0-f66.google.com with SMTP id i5so26179853wmg.2 for ; Mon, 01 Aug 2016 06:27:05 -0700 (PDT) Date: Mon, 1 Aug 2016 15:27:04 +0200 From: Michal Hocko Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160801132703.GF13544@dhcp22.suse.cz> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> <20160801131840.GE13544@dhcp22.suse.cz> <20160801132145.GA19395@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160801132145.GA19395@esperanza> Sender: owner-linux-mm@kvack.org List-ID: To: Vladimir Davydov Cc: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon 01-08-16 16:21:45, Vladimir Davydov wrote: > On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote: > > On Mon 01-08-16 16:03:10, Vladimir Davydov wrote: > > > We must call shrink_slab() for each memory cgroup on both global and > > > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > > > changed that so that now shrink_slab() is only called with memcg != NULL > > > on memcg reclaim. As a result, memcg-aware shrinkers (including > > > dentry/inode) are never invoked on global reclaim. Fix that. > > > > > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > > > > I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere. > > I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's > d71df22b55099. But this sha is unstable. THe patch you are referring to is already sitting in the Linus tree so please use his (stable sha instead). -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f71.google.com (mail-wm0-f71.google.com [74.125.82.71]) by kanga.kvack.org (Postfix) with ESMTP id 4A37F6B0263 for ; Mon, 1 Aug 2016 11:15:31 -0400 (EDT) Received: by mail-wm0-f71.google.com with SMTP id l4so84467430wml.0 for ; Mon, 01 Aug 2016 08:15:31 -0700 (PDT) Received: from gum.cmpxchg.org (gum.cmpxchg.org. [85.214.110.215]) by mx.google.com with ESMTPS id i11si16466985wmh.67.2016.08.01.08.15.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Aug 2016 08:15:30 -0700 (PDT) Date: Mon, 1 Aug 2016 11:15:08 -0400 From: Johannes Weiner Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160801151508.GB7603@cmpxchg.org> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> Sender: owner-linux-mm@kvack.org List-ID: To: Vladimir Davydov Cc: Andrew Morton , Mel Gorman , Hillf Danton , Vlastimil Babka , Michal Hocko , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 04:03:10PM +0300, Vladimir Davydov wrote: > We must call shrink_slab() for each memory cgroup on both global and > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > changed that so that now shrink_slab() is only called with memcg != NULL > on memcg reclaim. As a result, memcg-aware shrinkers (including > dentry/inode) are never invoked on global reclaim. Fix that. > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > Signed-off-by: Vladimir Davydov Ouch, I missed that in the review. The change looked so obviously correct, but the shrink_slab() interface is a little deceiving. It would be great if shrink_slab() could handle root_mem_cgroup/NULL and then we'd always call it from inside the loop. But AFAICS we need the global call to get the cumulative scanned/lru_pages ratio from all of the memcgs reclaimed... grr. Oh well. This fix looks correct to me, anyway. Acked-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200]) by kanga.kvack.org (Postfix) with ESMTP id 4A4E66B025E for ; Mon, 1 Aug 2016 20:10:40 -0400 (EDT) Received: by mail-pf0-f200.google.com with SMTP id 63so303271761pfx.0 for ; Mon, 01 Aug 2016 17:10:40 -0700 (PDT) Received: from lgeamrelo13.lge.com (LGEAMRELO13.lge.com. [156.147.23.53]) by mx.google.com with ESMTP id iv7si37625609pac.17.2016.08.01.17.10.38 for ; Mon, 01 Aug 2016 17:10:39 -0700 (PDT) Date: Tue, 2 Aug 2016 09:11:38 +0900 From: Minchan Kim Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160802001138.GB6770@bbox> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: Vladimir Davydov Cc: Andrew Morton , Mel Gorman , Hillf Danton , Johannes Weiner , Vlastimil Babka , Michal Hocko , Joonsoo Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 04:03:10PM +0300, Vladimir Davydov wrote: > We must call shrink_slab() for each memory cgroup on both global and > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > changed that so that now shrink_slab() is only called with memcg != NULL > on memcg reclaim. As a result, memcg-aware shrinkers (including > dentry/inode) are never invoked on global reclaim. Fix that. > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > Signed-off-by: Vladimir Davydov Acked-by: Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 6DFCE6B0005 for ; Tue, 2 Aug 2016 05:32:11 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id o80so99141137wme.1 for ; Tue, 02 Aug 2016 02:32:11 -0700 (PDT) Received: from outbound-smtp06.blacknight.com (outbound-smtp06.blacknight.com. [81.17.249.39]) by mx.google.com with ESMTPS id m22si2244343wmc.79.2016.08.02.02.32.10 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 02 Aug 2016 02:32:10 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp06.blacknight.com (Postfix) with ESMTPS id DBD6D9922B for ; Tue, 2 Aug 2016 09:32:09 +0000 (UTC) Date: Tue, 2 Aug 2016 10:32:08 +0100 From: Mel Gorman Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim Message-ID: <20160802093208.GH2799@techsingularity.net> References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com> Sender: owner-linux-mm@kvack.org List-ID: To: Vladimir Davydov Cc: Andrew Morton , Hillf Danton , Johannes Weiner , Vlastimil Babka , Michal Hocko , Joonsoo Kim , Minchan Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon, Aug 01, 2016 at 04:03:10PM +0300, Vladimir Davydov wrote: > We must call shrink_slab() for each memory cgroup on both global and > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally > changed that so that now shrink_slab() is only called with memcg != NULL > on memcg reclaim. As a result, memcg-aware shrinkers (including > dentry/inode) are never invoked on global reclaim. Fix that. > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis") > Signed-off-by: Vladimir Davydov Acked-by: Mel Gorman -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org