From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, rth@twiddle.net
Cc: qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, anton@samba.org
Subject: [Qemu-devel] [PATCH v1 2/2] target-ppc: cmprb - truncate RA to 8bits
Date: Tue, 2 Aug 2016 13:23:00 +0530 [thread overview]
Message-ID: <1470124380-5751-2-git-send-email-nikunj@linux.vnet.ibm.com> (raw)
In-Reply-To: <1470124380-5751-1-git-send-email-nikunj@linux.vnet.ibm.com>
Missed the following bit in the instruction coding.
src1 ← EXTZ(RA(56:63))
Reported-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
---
Can be squashed with the original commit
target-ppc/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index dc89e6a..14f4b68 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -867,6 +867,7 @@ static void gen_cmprb(DisasContext *ctx)
tcg_gen_trunc_tl_i32(src1, cpu_gpr[rA(ctx->opcode)]);
tcg_gen_trunc_tl_i32(src2, cpu_gpr[rB(ctx->opcode)]);
+ tcg_gen_andi_i32(src1, src1, 0xFF);
tcg_gen_ext8u_i32(src2lo, src2);
tcg_gen_shri_i32(src2, src2, 8);
tcg_gen_ext8u_i32(src2hi, src2);
--
2.7.4
next prev parent reply other threads:[~2016-08-02 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 7:52 [Qemu-devel] [PATCH v1 1/2] target-ppc: modsw - return 64-bit sign extended Nikunj A Dadhania
2016-08-02 7:53 ` Nikunj A Dadhania [this message]
2016-08-03 1:17 ` [Qemu-devel] [PATCH v1 2/2] target-ppc: cmprb - truncate RA to 8bits David Gibson
2016-08-03 1:17 ` [Qemu-devel] [PATCH v1 1/2] target-ppc: modsw - return 64-bit sign extended David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470124380-5751-2-git-send-email-nikunj@linux.vnet.ibm.com \
--to=nikunj@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.