From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753600AbcHBK3t (ORCPT ); Tue, 2 Aug 2016 06:29:49 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:23877 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753089AbcHBK3j (ORCPT ); Tue, 2 Aug 2016 06:29:39 -0400 X-AuditID: cbfec7f4-f796c6d000001486-0e-57a07379b3df From: Marek Szyprowski To: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Kishon Vijay Abraham I , Krzysztof Kozlowski Subject: [PATCH] phy: exynos-mipi-video: simplify check for coupled phy status Date: Tue, 02 Aug 2016 12:17:34 +0200 Message-id: <1470133054-31957-1-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1470127956-22476-1-git-send-email-m.szyprowski@samsung.com> References: <1470127956-22476-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplluLIzCtJLcpLzFFi42I5/e/4Vd3K4gXhBo/nS1tsnLGe1WLS/Qks Fq9fGFpceNrDZnF51xw2ixnn9zFZrD1yl93i8Jt2VgcOj74tqxg9jt/YzuTxeZNcAHMUl01K ak5mWWqRvl0CV8bz5VMZCxp5K6Y93cHUwPiMq4uRk0NCwETi8stFbBC2mMSFe+vBbCGBpYwS U2ewdDFyAdlNTBJfLzxnBUmwCRhKdL3tAisSEXCWuP3hG1gRs8BORok/N7rBioQF/CR2nLsJ VsQioCoxafUhJhCbV8BD4tv1S+wQ2+QkTh6bDFTPwcEp4Clx64gDxGIPiR8dHYwTGHkXMDKs YhRNLU0uKE5KzzXUK07MLS7NS9dLzs/dxAgJpC87GBcfszrEKMDBqMTDG5A7P1yINbGsuDL3 EKMEB7OSCK9t0YJwId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rxzd70PERJITyxJzU5NLUgtgsky cXBKNTAK3Arw7fo6b9slvkkzZD2jVno7+AoVH1zU5+naLDJlz42JdVN6r9Ut/pnf+2n95VOK uQc8rOeo3eYMvDQ3zuPs2Wu5zM1bRAVnRhZ4x/zjWsDV6pzgbMOfM+dHj1tDvYdblED/6Yjo JOGCHd/89vPd92LkVDGXZl/HxyPjaZsZ8fjc+/feV5VYijMSDbWYi4oTAbLdRfogAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to access regmap of coupled phy to check its state - such information is already in the phy device itself, so use it directly. This let us to avoid possible access to registers of the device in the disabled power domain if the coupled phy is already disabled. Signed-off-by: Marek Szyprowski Acked-by: Sylwester Nawrocki --- drivers/phy/phy-exynos-mipi-video.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c index 8b851f7..6bee04c 100644 --- a/drivers/phy/phy-exynos-mipi-video.c +++ b/drivers/phy/phy-exynos-mipi-video.c @@ -229,19 +229,6 @@ struct exynos_mipi_video_phy { spinlock_t slock; }; -static inline int __is_running(const struct exynos_mipi_phy_desc *data, - struct exynos_mipi_video_phy *state) -{ - u32 val; - int ret; - - ret = regmap_read(state->regmaps[data->resetn_map], data->resetn_reg, &val); - if (ret) - return 0; - - return val & data->resetn_val; -} - static int __set_phy_state(const struct exynos_mipi_phy_desc *data, struct exynos_mipi_video_phy *state, unsigned int on) { @@ -251,7 +238,7 @@ static int __set_phy_state(const struct exynos_mipi_phy_desc *data, /* disable in PMU sysreg */ if (!on && data->coupled_phy_id >= 0 && - !__is_running(state->phys[data->coupled_phy_id].data, state)) { + state->phys[data->coupled_phy_id].phy->power_count == 0) { regmap_read(state->regmaps[data->enable_map], data->enable_reg, &val); val &= ~data->enable_val; -- 1.9.1