From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets Date: Wed, 23 Mar 2016 11:41:26 +0100 Message-ID: <1470283.VAKgtTzWav@xps13> References: <1458682638-28378-1-git-send-email-aconole@redhat.com> <1458682638-28378-3-git-send-email-aconole@redhat.com> <5248499.WRMHcbhMjp@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Aaron Conole , dev@dpdk.org, bruce.richardson@intel.com To: Wenzhuo Lu Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 2B34D2A5E for ; Wed, 23 Mar 2016 11:43:08 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id p65so17989078wmp.0 for ; Wed, 23 Mar 2016 03:43:08 -0700 (PDT) In-Reply-To: <5248499.WRMHcbhMjp@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" fixing Wenzhuo email address... 2016-03-23 11:38, Thomas Monjalon: > 2016-03-22 17:37, Aaron Conole: > > The register read/write mphy functions have misleading whitespace around > > the locked check. This cleanup merely preserves the existing functionality > > while improving the ready check. > > > > Fixes commit 38db3f7f50bd ("e1000: update base driver") > > > > Signed-off-by: Aaron Conole > > --- > > v2: > > * Changed from "whitespace-only" fix to a functional change > > moving the phy writes into protection of the `if (locked)` > > code > > * Added "Fixes" line. > > Wenzhuo, do you agree to fix the base driver here?