From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:58916 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934977AbcHEL5U (ORCPT ); Fri, 5 Aug 2016 07:57:20 -0400 Message-ID: <1470398236.2311.89.camel@gmail.com> Subject: Re: [PATCH v7 00/47] xfs: add reverse mapping support From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Dave Chinner Cc: "Darrick J. Wong" , Mark Fasheh , linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, bfoster@redhat.com, xfs@oss.sgi.com Date: Fri, 05 Aug 2016 14:57:16 +0300 In-Reply-To: <20160805104950.GF16044@dastard> References: <146907695530.25461.3225785294902719773.stgit@birch.djwong.org> <20160803194536.GJ5316@wotan.suse.de> <20160803205520.GQ8590@birch.djwong.org> <20160804005843.GJ8593@birch.djwong.org> <20160804021852.GK5316@wotan.suse.de> <20160804154845.GV8590@birch.djwong.org> <20160804235015.GC16044@dastard> <1470380474.2311.71.camel@gmail.com> <20160805104950.GF16044@dastard> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 2016-08-05 at 20:49 +1000, Dave Chinner wrote: > On Fri, Aug 05, 2016 at 10:01:14AM +0300, Artem Bityutskiy wrote: > > > > On Fri, 2016-08-05 at 09:50 +1000, Dave Chinner wrote: > > > > > > I'd much prefer that fiemap gives exact information about shared > > > extents. FIEMAP is a diagnostic tool and as such we need it to > > > accurately reflect the exact extent map of the inode being > > > queried > > > so we aren't mislead about the layout of the file during trouble > > > shooting. > > > > Hi Dave, you are right, and here is a side note:  we were using > > FIEMAP > > for optimizing image deployment in production, so it is a > > diagnostic > > tool and more. > > Yay, data corruption ahoy! > > Hasn't /anyone/ listened to the repeated statements from fs > developers that FIEMAP is not a safe method of optimising data > copying? Yes, which is kind of sad from the user's perspective. We had issues with XFS, not ext4, and tweaking preallocation helped. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id DD1277CA1 for ; Fri, 5 Aug 2016 06:57:24 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 55AD6AC003 for ; Fri, 5 Aug 2016 04:57:21 -0700 (PDT) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by cuda.sgi.com with ESMTP id JERgP0HF7lJnL910 for ; Fri, 05 Aug 2016 04:57:20 -0700 (PDT) Message-ID: <1470398236.2311.89.camel@gmail.com> Subject: Re: [PATCH v7 00/47] xfs: add reverse mapping support From: Artem Bityutskiy Date: Fri, 05 Aug 2016 14:57:16 +0300 In-Reply-To: <20160805104950.GF16044@dastard> References: <146907695530.25461.3225785294902719773.stgit@birch.djwong.org> <20160803194536.GJ5316@wotan.suse.de> <20160803205520.GQ8590@birch.djwong.org> <20160804005843.GJ8593@birch.djwong.org> <20160804021852.GK5316@wotan.suse.de> <20160804154845.GV8590@birch.djwong.org> <20160804235015.GC16044@dastard> <1470380474.2311.71.camel@gmail.com> <20160805104950.GF16044@dastard> Mime-Version: 1.0 Reply-To: dedekind1@gmail.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: "Darrick J. Wong" , Mark Fasheh , vishal.l.verma@intel.com, bfoster@redhat.com, xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org T24gRnJpLCAyMDE2LTA4LTA1IGF0IDIwOjQ5ICsxMDAwLCBEYXZlIENoaW5uZXIgd3JvdGU6Cj4g T24gRnJpLCBBdWcgMDUsIDIwMTYgYXQgMTA6MDE6MTRBTSArMDMwMCwgQXJ0ZW0gQml0eXV0c2tp eSB3cm90ZToKPiA+IAo+ID4gT24gRnJpLCAyMDE2LTA4LTA1IGF0IDA5OjUwICsxMDAwLCBEYXZl IENoaW5uZXIgd3JvdGU6Cj4gPiA+IAo+ID4gPiBJJ2QgbXVjaCBwcmVmZXIgdGhhdCBmaWVtYXAg Z2l2ZXMgZXhhY3QgaW5mb3JtYXRpb24gYWJvdXQgc2hhcmVkCj4gPiA+IGV4dGVudHMuIEZJRU1B UCBpcyBhIGRpYWdub3N0aWMgdG9vbCBhbmQgYXMgc3VjaCB3ZSBuZWVkIGl0IHRvCj4gPiA+IGFj Y3VyYXRlbHkgcmVmbGVjdCB0aGUgZXhhY3QgZXh0ZW50IG1hcCBvZiB0aGUgaW5vZGUgYmVpbmcK PiA+ID4gcXVlcmllZAo+ID4gPiBzbyB3ZSBhcmVuJ3QgbWlzbGVhZCBhYm91dCB0aGUgbGF5b3V0 IG9mIHRoZSBmaWxlIGR1cmluZyB0cm91YmxlCj4gPiA+IHNob290aW5nLgo+ID4gCj4gPiBIaSBE YXZlLCB5b3UgYXJlIHJpZ2h0LCBhbmQgaGVyZSBpcyBhIHNpZGUgbm90ZTogwqB3ZSB3ZXJlIHVz aW5nCj4gPiBGSUVNQVAKPiA+IGZvciBvcHRpbWl6aW5nIGltYWdlIGRlcGxveW1lbnQgaW4gcHJv ZHVjdGlvbiwgc28gaXQgaXMgYQo+ID4gZGlhZ25vc3RpYwo+ID4gdG9vbCBhbmQgbW9yZS4KPiAK PiBZYXksIGRhdGEgY29ycnVwdGlvbiBhaG95IQo+IAo+IEhhc24ndCAvYW55b25lLyBsaXN0ZW5l ZCB0byB0aGUgcmVwZWF0ZWQgc3RhdGVtZW50cyBmcm9tIGZzCj4gZGV2ZWxvcGVycyB0aGF0IEZJ RU1BUCBpcyBub3QgYSBzYWZlIG1ldGhvZCBvZiBvcHRpbWlzaW5nIGRhdGEKPiBjb3B5aW5nPwoK WWVzLCB3aGljaCBpcyBraW5kIG9mIHNhZCBmcm9tIHRoZSB1c2VyJ3MgcGVyc3BlY3RpdmUuIFdl IGhhZCBpc3N1ZXMKd2l0aCBYRlMsIG5vdCBleHQ0LCBhbmQgdHdlYWtpbmcgcHJlYWxsb2NhdGlv biBoZWxwZWQuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwp4ZnMgbWFpbGluZyBsaXN0Cnhmc0Bvc3Muc2dpLmNvbQpodHRwOi8vb3NzLnNnaS5jb20vbWFp bG1hbi9saXN0aW5mby94ZnMK