From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752472AbcHFU1J (ORCPT ); Sat, 6 Aug 2016 16:27:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40004 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752136AbcHFU1H (ORCPT ); Sat, 6 Aug 2016 16:27:07 -0400 From: Lyude To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, xorg-driver-ati@lists.freedesktop.org Cc: Lyude , David Airlie , linux-kernel@vger.kernel.org Subject: [PATCH 7/7] drm/dp_helper: Rate limit timeout errors from drm_dp_i2c_do_msg() Date: Fri, 5 Aug 2016 20:30:39 -0400 Message-Id: <1470443443-27252-8-git-send-email-cpaul@redhat.com> In-Reply-To: <1470443443-27252-1-git-send-email-cpaul@redhat.com> References: <1470443443-27252-1-git-send-email-cpaul@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sat, 06 Aug 2016 00:31:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Timeouts can be errors, but timeouts are also usually normal behavior and happen a lot. Since the kernel already lets us know when we're suppressing messages due to rate limiting, rate limit timeout errors so we don't make too much noise in the kernel log. Signed-off-by: Lyude --- drivers/gpu/drm/drm_dp_helper.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 43be189..5ca72d25 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -574,7 +574,17 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) if (ret == -EBUSY) continue; - DRM_DEBUG_KMS("transaction failed: %d\n", ret); + /* + * While timeouts can be errors, they're usually normal + * behavior (for instance, when a driver tries to + * communicate with a non-existant DisplayPort device). + * Avoid spamming the kernel log with timeout errors. + */ + if (ret == -ETIMEDOUT) + DRM_DEBUG_KMS_RATELIMITED("transaction timed out\n"); + else + DRM_DEBUG_KMS("transaction failed: %d\n", ret); + return ret; } -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Subject: [PATCH 7/7] drm/dp_helper: Rate limit timeout errors from drm_dp_i2c_do_msg() Date: Fri, 5 Aug 2016 20:30:39 -0400 Message-ID: <1470443443-27252-8-git-send-email-cpaul@redhat.com> References: <1470443443-27252-1-git-send-email-cpaul@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1470443443-27252-1-git-send-email-cpaul-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, xorg-driver-ati-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: David Airlie , Lyude , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: dri-devel@lists.freedesktop.org VGltZW91dHMgY2FuIGJlIGVycm9ycywgYnV0IHRpbWVvdXRzIGFyZSBhbHNvIHVzdWFsbHkgbm9y bWFsIGJlaGF2aW9yCmFuZCBoYXBwZW4gYSBsb3QuIFNpbmNlIHRoZSBrZXJuZWwgYWxyZWFkeSBs ZXRzIHVzIGtub3cgd2hlbiB3ZSdyZQpzdXBwcmVzc2luZyBtZXNzYWdlcyBkdWUgdG8gcmF0ZSBs aW1pdGluZywgcmF0ZSBsaW1pdCB0aW1lb3V0IGVycm9ycyBzbwp3ZSBkb24ndCBtYWtlIHRvbyBt dWNoIG5vaXNlIGluIHRoZSBrZXJuZWwgbG9nLgoKU2lnbmVkLW9mZi1ieTogTHl1ZGUgPGNwYXVs QHJlZGhhdC5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYyB8IDEyICsr KysrKysrKysrLQogMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX2hlbHBlci5jIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYwppbmRleCA0M2JlMTg5Li41Y2E3MmQyNSAxMDA2NDQK LS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYworKysgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX2RwX2hlbHBlci5jCkBAIC01NzQsNyArNTc0LDE3IEBAIHN0YXRpYyBpbnQgZHJtX2Rw X2kyY19kb19tc2coc3RydWN0IGRybV9kcF9hdXggKmF1eCwgc3RydWN0IGRybV9kcF9hdXhfbXNn ICptc2cpCiAJCQlpZiAocmV0ID09IC1FQlVTWSkKIAkJCQljb250aW51ZTsKIAotCQkJRFJNX0RF QlVHX0tNUygidHJhbnNhY3Rpb24gZmFpbGVkOiAlZFxuIiwgcmV0KTsKKwkJCS8qCisJCQkgKiBX aGlsZSB0aW1lb3V0cyBjYW4gYmUgZXJyb3JzLCB0aGV5J3JlIHVzdWFsbHkgbm9ybWFsCisJCQkg KiBiZWhhdmlvciAoZm9yIGluc3RhbmNlLCB3aGVuIGEgZHJpdmVyIHRyaWVzIHRvCisJCQkgKiBj b21tdW5pY2F0ZSB3aXRoIGEgbm9uLWV4aXN0YW50IERpc3BsYXlQb3J0IGRldmljZSkuCisJCQkg KiBBdm9pZCBzcGFtbWluZyB0aGUga2VybmVsIGxvZyB3aXRoIHRpbWVvdXQgZXJyb3JzLgorCQkJ ICovCisJCQlpZiAocmV0ID09IC1FVElNRURPVVQpCisJCQkJRFJNX0RFQlVHX0tNU19SQVRFTElN SVRFRCgidHJhbnNhY3Rpb24gdGltZWQgb3V0XG4iKTsKKwkJCWVsc2UKKwkJCQlEUk1fREVCVUdf S01TKCJ0cmFuc2FjdGlvbiBmYWlsZWQ6ICVkXG4iLCByZXQpOworCiAJCQlyZXR1cm4gcmV0Owog CQl9CiAKLS0gCjIuNy40CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK