From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: [PATCH 02/33] drm/i915: Do not overwrite the request with zero on reallocation Date: Sun, 7 Aug 2016 15:45:10 +0100 Message-ID: <1470581141-14432-3-git-send-email-chris@chris-wilson.co.uk> References: <1470581141-14432-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C9CC6E2EB for ; Sun, 7 Aug 2016 14:45:50 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id q128so11079049wma.1 for ; Sun, 07 Aug 2016 07:45:50 -0700 (PDT) In-Reply-To: <1470581141-14432-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , "Goel, Akash" List-Id: intel-gfx@lists.freedesktop.org V2hlbiB1c2luZyBSQ1UgbG9va3VwIGZvciB0aGUgcmVxdWVzdCwgY29tbWl0IDBlYWZlYzZkMzI0 NCAoImRybS9pOTE1OgpFbmFibGUgbG9ja2xlc3MgbG9va3VwIG9mIHJlcXVlc3QgdHJhY2tpbmcg dmlhIFJDVSIpLCB3ZSBhY2tub3dsZWRnZSB0aGF0CndlIG1heSByYWNlIHdpdGggYW5vdGhlciB0 aHJlYWQgdGhhdCBjb3VsZCBoYXZlIHJlYWxsb2NhdGVkIHRoZSByZXF1ZXN0LgpJbiBvcmRlciBm b3IgdGhlIGZpcnN0IHRocmVhZCBub3QgdG8gYmxvdyB1cCwgdGhlIHNlY29uZCB0aHJlYWQgbXVz dCBub3QKY2xlYXIgdGhlIHJlcXVlc3QgY29tcGxldGVkIGJlZm9yZSBvdmVyd3JpdGluZyBpdC4g SW4gdGhlIFJDVSBsb29rdXAsIHdlCmFsbG93IGZvciB0aGUgZW5naW5lL3NlcW5vIHRvIGJlIHJl cGxhY2VkIGJ1dCB3ZSBkbyBub3QgYWxsb3cgZm9yIGl0IHRvCmJlIHplcm9lZC4KClRoZSBjaG9p Y2Ugd2UgbWFrZSBpcyB0byBlaXRoZXIgYWRkIGV4dHJhIGNoZWNraW5nIHRvIHRoZSBSQ1UgbG9v a3VwLCBvcgplbWJyYWNlIHRoZSBpbmhlcmVudCByYWNlcyAoYXMgaW50ZW5kZWQpLiBJdCBpcyBt b3JlIGNvbXBsaWNhdGVkIGFzIHdlCm5lZWQgdG8gbWFudWFsbHkgY2xlYXIgZXZlcnl0aGluZyB3 ZSBkZXBlbmQgdXBvbiBiZWluZyB6ZXJvIGluaXRpYWxpc2VkLApidXQgd2UgYmVuZWZpdCBmcm9t IG5vdCBlbWl0aW5nIHRoZSBtZW1zZXQoKSB0byBjbGVhciB0aGUgZW50aXJlCmZyZXF1ZW50bHkg YWxsb2NhdGVkIHN0cnVjdHVyZSAodGhhdCBtZW1zZXQgdHVybnMgdXAgaW4gdGhyb3VnaHB1dApw cm9maWxlcykuIEFuZCBhdCB0aGUgc2FtZSB0aW1lLCB0aGUgbG9va3VwIHJlbWFpbnMgZmxleGli bGUgZm9yIGZ1dHVyZQphZGp1c3RtZW50cy4KCnYyOiBPbGQgc3R5bGUgTFJDIHJlcXVpcmVzIGFu b3RoZXIgdmFyaWFibGUgdG8gYmUgaW5pdGlhbGl6ZS4gKFRoZQpkYW5nZXIgaW5oZXJlbnQgaW4g bm90IHplcm9pbmcgZXZlcnl0aGluZy4pCnYzOiByZXF1ZXN0LT5iYXRjaCBhbHNvIG5lZWRzIHRv IGJlIGNsZWFyZWQKCkZpeGVzOiAwZWFmZWM2ZDMyNDQgKCJkcm0vaTkxNTogRW5hYmxlIGxvY2ts ZXNzIGxvb2t1cCBvZiByZXF1ZXN0Li4uIikKU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+CkNjOiAiR29lbCwgQWthc2giIDxha2FzaC5nb2VsQGlu dGVsLmNvbT4KQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+CkNjOiBK b29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Ci0tLQogZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jIHwgMzcgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKystCiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0 LmggfCAxMSArKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDQ3IGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9y ZXF1ZXN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMKaW5kZXgg NmExNjYxNjQzZDNkLi5iN2ZmZGUwMDJhNjIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX3JlcXVlc3QuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9yZXF1ZXN0LmMKQEAgLTM1NSw3ICszNTUsMzUgQEAgaTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCiAJaWYgKHJlcSAmJiBpOTE1X2dlbV9yZXF1 ZXN0X2NvbXBsZXRlZChyZXEpKQogCQlpOTE1X2dlbV9yZXF1ZXN0X3JldGlyZShyZXEpOwogCi0J cmVxID0ga21lbV9jYWNoZV96YWxsb2MoZGV2X3ByaXYtPnJlcXVlc3RzLCBHRlBfS0VSTkVMKTsK KwkvKiBCZXdhcmU6IERyYWdvbnMgYmUgZmx5aW5nIG92ZXJoZWFkLgorCSAqCisJICogV2UgdXNl IFJDVSB0byBsb29rIHVwIHJlcXVlc3RzIGluIGZsaWdodC4gVGhlIGxvb2t1cHMgbWF5CisJICog cmFjZSB3aXRoIHRoZSByZXF1ZXN0IGJlaW5nIGFsbG9jYXRlZCBmcm9tIHRoZSBzbGFiIGZyZWVs aXN0LgorCSAqIFRoYXQgaXMgdGhlIHJlcXVlc3Qgd2UgYXJlIHdyaXRpbmcgdG8gaGVyZSwgbWF5 IGJlIGluIHRoZSBwcm9jZXNzCisJICogb2YgYmVpbmcgcmVhZCBieSBfX2k5MTVfZ2VtX2FjdGl2 ZV9nZXRfcmVxdWVzdF9yY3UoKS4gQXMgc3VjaCwKKwkgKiB3ZSBoYXZlIHRvIGJlIHZlcnkgY2Fy ZWZ1bCB3aGVuIG92ZXJ3cml0aW5nIHRoZSBjb250ZW50cy4gRHVyaW5nCisJICogdGhlIFJDVSBs b29rdXAsIHdlIGNoYW5nZSBjaGFzZSB0aGUgcmVxdWVzdC0+ZW5naW5lIHBvaW50ZXIsCisJICog cmVhZCB0aGUgcmVxdWVzdC0+ZmVuY2Uuc2Vxbm8gYW5kIGluY3JlbWVudCB0aGUgcmVmZXJlbmNl IGNvdW50LgorCSAqCisJICogVGhlIHJlZmVyZW5jZSBjb3VudCBpcyBpbmNyZW1lbnRlZCBhdG9t aWNhbGx5LiBJZiBpdCBpcyB6ZXJvLAorCSAqIHRoZSBsb29rdXAga25vd3MgdGhlIHJlcXVlc3Qg aXMgdW5hbGxvY2F0ZWQgYW5kIGNvbXBsZXRlLiBPdGhlcndpc2UsCisJICogaXQgaXMgZWl0aGVy IHN0aWxsIGluIHVzZSwgb3IgaGFzIGJlZW4gcmVhbGxvY2F0ZWQgYW5kIHJlc2V0CisJICogd2l0 aCBmZW5jZV9pbml0KCkuIFRoaXMgaW5jcmVtZW50IGlzIHNhZmUgZm9yIHJlbGVhc2UgYXMgd2Ug Y2hlY2sKKwkgKiB0aGF0IHRoZSByZXF1ZXN0IHdlIGhhdmUgYSByZWZlcmVuY2UgdG8gYW5kIG1h dGNoZXMgdGhlIGFjdGl2ZQorCSAqIHJlcXVlc3QuCisJICoKKwkgKiBCZWZvcmUgd2UgaW5jcmVt ZW50IHRoZSByZWZjb3VudCwgd2UgY2hhc2UgdGhlIHJlcXVlc3QtPmVuZ2luZQorCSAqIHBvaW50 ZXIuIFdlIG11c3Qgbm90IGNhbGwga21lbV9jYWNoZV96YWxsb2MoKSBvciBlbHNlIHdlIHNldAor CSAqIHRoYXQgcG9pbnRlciB0byBOVUxMIGFuZCBjYXVzZSBhIGNyYXNoIGR1cmluZyB0aGUgbG9v a3VwLiBJZgorCSAqIHdlIHNlZSB0aGUgcmVxdWVzdCBpcyBjb21wbGV0ZWQgKGJhc2VkIG9uIHRo ZSB2YWx1ZSBvZiB0aGUKKwkgKiBvbGQgZW5naW5lIGFuZCBzZXFubyksIHRoZSBsb29rdXAgaXMg Y29tcGxldGUgYW5kIHJlcG9ydHMgTlVMTC4KKwkgKiBJZiB3ZSBkZWNpZGUgdGhlIHJlcXVlc3Qg aXMgbm90IGNvbXBsZXRlZCAobmV3IGVuZ2luZSBvciBzZXFubyksCisJICogdGhlbiB3ZSBncmFi IGEgcmVmZXJlbmNlIGFuZCBkb3VibGUgY2hlY2sgdGhhdCBpdCBpcyBzdGlsbCB0aGUKKwkgKiBh Y3RpdmUgcmVxdWVzdCAtIHdoaWNoIGl0IHdvbid0IGJlIGFuZCByZXN0YXJ0IHRoZSBsb29rdXAu CisJICoKKwkgKiBEbyBub3QgdXNlIGttZW1fY2FjaGVfemFsbG9jKCkgaGVyZSEKKwkgKi8KKwly ZXEgPSBrbWVtX2NhY2hlX2FsbG9jKGRldl9wcml2LT5yZXF1ZXN0cywgR0ZQX0tFUk5FTCk7CiAJ aWYgKCFyZXEpCiAJCXJldHVybiBFUlJfUFRSKC1FTk9NRU0pOwogCkBAIC0zNzUsNiArNDAzLDEz IEBAIGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2Moc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5l LAogCXJlcS0+ZW5naW5lID0gZW5naW5lOwogCXJlcS0+Y3R4ID0gaTkxNV9nZW1fY29udGV4dF9n ZXQoY3R4KTsKIAorCS8qIE5vIHphbGxvYywgbXVzdCBjbGVhciB3aGF0IHdlIG5lZWQgYnkgaGFu ZCAqLworCXJlcS0+c2lnbmFsaW5nLndhaXQudHNrID0gTlVMTDsKKwlyZXEtPnByZXZpb3VzX2Nv bnRleHQgPSBOVUxMOworCXJlcS0+ZmlsZV9wcml2ID0gTlVMTDsKKwlyZXEtPmJhdGNoX29iaiA9 IE5VTEw7CisJcmVxLT5lbHNwX3N1Ym1pdHRlZCA9IDA7CisKIAkvKgogCSAqIFJlc2VydmUgc3Bh Y2UgaW4gdGhlIHJpbmcgYnVmZmVyIGZvciBhbGwgdGhlIGNvbW1hbmRzIHJlcXVpcmVkIHRvCiAJ ICogZXZlbnR1YWxseSBlbWl0IHRoaXMgcmVxdWVzdC4gVGhpcyBpcyB0byBndWFyYW50ZWUgdGhh dCB0aGUKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3Qu aCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuaAppbmRleCBiMjQ1NmRl ZGUzYWQuLjcyMWViOGNiY2U5YiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW1fcmVxdWVzdC5oCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVl c3QuaApAQCAtNTEsNiArNTEsMTMgQEAgc3RydWN0IGludGVsX3NpZ25hbF9ub2RlIHsKICAqIGVt aXNzaW9uIHRpbWUgdG8gYmUgYXNzb2NpYXRlZCB3aXRoIHRoZSByZXF1ZXN0IGZvciB0cmFja2lu ZyBob3cgZmFyIGFoZWFkCiAgKiBvZiB0aGUgR1BVIHRoZSBzdWJtaXNzaW9uIGlzLgogICoKKyAq IFdoZW4gbW9kaWZ5aW5nIHRoaXMgc3RydWN0dXJlIGJlIHZlcnkgYXdhcmUgdGhhdCB3ZSBwZXJm b3JtIGEgbG9ja2xlc3MKKyAqIFJDVSBsb29rdXAgb2YgaXQgdGhhdCBtYXkgcmFjZSBhZ2FpbnN0 IHJlYWxsb2NhdGlvbiBvZiB0aGUgc3RydWN0CisgKiBmcm9tIHRoZSBzbGFiIGZyZWVsaXN0LiBX ZSBpbnRlbnRpb25hbGx5IGRvIG5vdCB6ZXJvIHRoZSBzdHJ1Y3R1cmUgb24KKyAqIGFsbG9jYXRp b24gc28gdGhhdCB0aGUgbG9va3VwIGNhbiB1c2UgdGhlIGRhbmdsaW5nIHBvaW50ZXJzIChhbmQg aXMKKyAqIGNvZ25pc2NlbnQgdGhhdCB0aG9zZSBwb2ludGVycyBtYXkgYmUgd3JvbmcpLiBJbnN0 ZWFkLCBldmVyeXRoaW5nIHRoYXQKKyAqIG5lZWRzIHRvIGJlIGluaXRpYWxpc2VkIG11c3QgYmUg ZG9uZSBzbyBleHBsaWNpdGx5LgorICoKICAqIFRoZSByZXF1ZXN0cyBhcmUgcmVmZXJlbmNlIGNv dW50ZWQuCiAgKi8KIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCB7CkBAIC00NjUsNiArNDcy LDEwIEBAIF9faTkxNV9nZW1fYWN0aXZlX2dldF9yY3UoY29uc3Qgc3RydWN0IGk5MTVfZ2VtX2Fj dGl2ZSAqYWN0aXZlKQogCSAqIGp1c3QgcmVwb3J0IHRoZSBhY3RpdmUgdHJhY2tlciBpcyBpZGxl LiBJZiB0aGUgbmV3IHJlcXVlc3QgaXMKIAkgKiBpbmNvbXBsZXRlLCB0aGVuIHdlIGFjcXVpcmUg YSByZWZlcmVuY2Ugb24gaXQgYW5kIGNoZWNrIHRoYXQKIAkgKiBpdCByZW1haW5lZCB0aGUgYWN0 aXZlIHJlcXVlc3QuCisJICoKKwkgKiBJdCBpcyB0aGVuIGltcGVyYXRpdmUgdGhhdCB3ZSBkbyBu b3QgemVybyB0aGUgcmVxdWVzdCBvbgorCSAqIHJlYWxsb2NhdGlvbiwgc28gdGhhdCB3ZSBjYW4g Y2hhc2UgdGhlIGRhbmdsaW5nIHBvaW50ZXJzIQorCSAqIFNlZSBpOTE1X2dlbV9yZXF1ZXN0X2Fs bG9jKCkuCiAJICovCiAJZG8gewogCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVl c3Q7Ci0tIAoyLjguMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==