From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 17/33] drm/i915: Use VMA directly for checking tiling parameters Date: Tue, 09 Aug 2016 09:18:28 +0300 Message-ID: <1470723508.4596.2.camel@linux.intel.com> References: <1470581141-14432-1-git-send-email-chris@chris-wilson.co.uk> <1470581141-14432-18-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 317DB6E029 for ; Tue, 9 Aug 2016 06:18:31 +0000 (UTC) In-Reply-To: <1470581141-14432-18-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gc3UsIDIwMTYtMDgtMDcgYXQgMTU6NDUgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBT aWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAt LS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3RpbGluZy5jIHwgNDcgKysrKysr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+IMKgMSBmaWxlIGNoYW5nZWQsIDI4IGluc2Vy dGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV90aWxpbmcuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt X3RpbGluZy5jCj4gaW5kZXggZjRiOTg0ZGU4M2I1Li4yY2VhZGRjOTU5ZDMgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fdGlsaW5nLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbV90aWxpbmcuYwo+IEBAIC0xMTcsMzQgKzExNyw0NSBAQCBp OTE1X3RpbGluZ19vayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgc3RyaWRlLCBpbnQgc2l6 ZSwgaW50IHRpbGluZ19tb2RlKQo+IMKgfQo+IMKgCj4gwqAvKiBJcyB0aGUgY3VycmVudCBHVFQg YWxsb2NhdGlvbiB2YWxpZCBmb3IgdGhlIGNoYW5nZSBpbiB0aWxpbmc/ICovCj4gLXN0YXRpYyBi b29sCj4gK3N0YXRpYyBpbnQKPiDCoGk5MTVfZ2VtX29iamVjdF9mZW5jZV9vayhzdHJ1Y3QgZHJt X2k5MTVfZ2VtX29iamVjdCAqb2JqLCBpbnQgdGlsaW5nX21vZGUpCj4gwqB7Cj4gwqAJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShvYmotPmJhc2UuZGV2KTsKPiAr CXN0cnVjdCBpOTE1X3ZtYSAqdm1hOwo+IMKgCXUzMiBzaXplOwo+IMKgCj4gwqAJaWYgKHRpbGlu Z19tb2RlID09IEk5MTVfVElMSU5HX05PTkUpCj4gLQkJcmV0dXJuIHRydWU7Cj4gKwkJcmV0dXJu IDA7Cj4gwqAKPiDCoAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA0KQo+IC0JCXJldHVybiB0 cnVlOwo+ICsJCXJldHVybiAwOwo+ICsKPiArCXZtYSA9IGk5MTVfZ2VtX29ial90b19nZ3R0KG9i aik7Cj4gKwlpZiAoIXZtYSkKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlpZiAoIW9iai0+bWFwX2Fu ZF9mZW5jZWFibGUpCj4gKwkJcmV0dXJuIDA7Cj4gwqAKPiDCoAlpZiAoSVNfR0VOMyhkZXZfcHJp dikpIHsKPiAtCQlpZiAoaTkxNV9nZW1fb2JqX2dndHRfb2Zmc2V0KG9iaikgJiB+STkxNV9GRU5D RV9TVEFSVF9NQVNLKQo+IC0JCQlyZXR1cm4gZmFsc2U7Cj4gKwkJaWYgKHZtYS0+bm9kZS5zdGFy dCAmIH5JOTE1X0ZFTkNFX1NUQVJUX01BU0spCj4gKwkJCWdvdG8gYmFkOwo+IMKgCX0gZWxzZSB7 Cj4gLQkJaWYgKGk5MTVfZ2VtX29ial9nZ3R0X29mZnNldChvYmopICYgfkk4MzBfRkVOQ0VfU1RB UlRfTUFTSykKPiAtCQkJcmV0dXJuIGZhbHNlOwo+ICsJCWlmICh2bWEtPm5vZGUuc3RhcnQgJiB+ STgzMF9GRU5DRV9TVEFSVF9NQVNLKQo+ICsJCQlnb3RvIGJhZDsKPiDCoAl9Cj4gwqAKPiDCoAlz aXplID0gaTkxNV9nZW1fZ2V0X2dndHRfc2l6ZShkZXZfcHJpdiwgb2JqLT5iYXNlLnNpemUsIHRp bGluZ19tb2RlKTsKPiAtCWlmIChpOTE1X2dlbV9vYmpfZ2d0dF9zaXplKG9iaikgIT0gc2l6ZSkK PiAtCQlyZXR1cm4gZmFsc2U7Cj4gKwlpZiAodm1hLT5ub2RlLnNpemUgPCBzaXplKQo+ICsJCWdv dG8gYmFkOwo+IMKgCj4gLQlpZiAoaTkxNV9nZW1fb2JqX2dndHRfb2Zmc2V0KG9iaikgJiAoc2l6 ZSAtIDEpKQo+IC0JCXJldHVybiBmYWxzZTsKPiArCWlmICh2bWEtPm5vZGUuc3RhcnQgJiAoc2l6 ZSAtIDEpKQo+ICsJCWdvdG8gYmFkOwo+IMKgCj4gLQlyZXR1cm4gdHJ1ZTsKPiArCXJldHVybiAw Owo+ICsKPiArYmFkOgo+ICsJcmV0dXJuIGk5MTVfdm1hX3VuYmluZCh2bWEpOwoKVW1tLCBJIGRv IG5vdCBzZWUgbWF0Y2hpbmcgY2hlY2tzIHRvIGNvbnZlcnQgdG8gcmV0dXJuIHRoZSBlcnJvciB2 YWx1ZXMKaW4gaTkxNV92bWFfdW5iaW5kKCkuIEFtIEkgbG9zdCBvciB3aGF0IHdlcmUgeW91IGFm dGVyIHdpdGggdGhpcz8KClJlZ2FyZHMsIEpvb25hcwoKPiDCoH0KPiDCoAo+IMKgLyoqCj4gQEAg LTE2OCw3ICsxNzksNyBAQCBpOTE1X2dlbV9zZXRfdGlsaW5nKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHZvaWQgKmRhdGEsCj4gwqAJc3RydWN0IGRybV9pOTE1X2dlbV9zZXRfdGlsaW5nICphcmdz ID0gZGF0YTsKPiDCoAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1 KGRldik7Cj4gwqAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iajsKPiAtCWludCByZXQg PSAwOwo+ICsJaW50IGVyciA9IDA7Cj4gwqAKPiDCoAkvKiBNYWtlIHN1cmUgd2UgZG9uJ3QgY3Jv c3MtY29udGFtaW5hdGUgb2JqLT50aWxpbmdfYW5kX3N0cmlkZSAqLwo+IMKgCUJVSUxEX0JVR19P TihJOTE1X1RJTElOR19MQVNUICYgU1RSSURFX01BU0spOwo+IEBAIC0xODcsNyArMTk4LDcgQEAg aTkxNV9nZW1fc2V0X3RpbGluZyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ IMKgCj4gwqAJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+IMKgCWlmIChvYmotPnBp bl9kaXNwbGF5IHx8IG9iai0+ZnJhbWVidWZmZXJfcmVmZXJlbmNlcykgewo+IC0JCXJldCA9IC1F QlVTWTsKPiArCQllcnIgPSAtRUJVU1k7Cj4gwqAJCWdvdG8gZXJyOwo+IMKgCX0KPiDCoAo+IEBA IC0yMzQsMTEgKzI0NSw5IEBAIGk5MTVfZ2VtX3NldF90aWxpbmcoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwgdm9pZCAqZGF0YSwKPiDCoAkJwqAqIGhhcyB0byBhbHNvIGluY2x1ZGUgdGhlIHVuZmVu Y2VkIHJlZ2lzdGVyIHRoZSBHUFUgdXNlcwo+IMKgCQnCoCogd2hpbHN0IGV4ZWN1dGluZyBhIGZl bmNlZCBjb21tYW5kIGZvciBhbiB1bnRpbGVkIG9iamVjdC4KPiDCoAkJwqAqLwo+IC0JCWlmIChv YmotPm1hcF9hbmRfZmVuY2VhYmxlICYmCj4gLQkJwqDCoMKgwqAhaTkxNV9nZW1fb2JqZWN0X2Zl bmNlX29rKG9iaiwgYXJncy0+dGlsaW5nX21vZGUpKQo+IC0JCQlyZXQgPSBpOTE1X3ZtYV91bmJp bmQoaTkxNV9nZW1fb2JqX3RvX2dndHQob2JqKSk7Cj4gwqAKPiAtCQlpZiAocmV0ID09IDApIHsK PiArCQllcnIgPSBpOTE1X2dlbV9vYmplY3RfZmVuY2Vfb2sob2JqLCBhcmdzLT50aWxpbmdfbW9k ZSk7Cj4gKwkJaWYgKCFlcnIpIHsKPiDCoAkJCWlmIChvYmotPnBhZ2VzICYmCj4gwqAJCQnCoMKg wqDCoG9iai0+bWFkdiA9PSBJOTE1X01BRFZfV0lMTE5FRUQgJiYKPiDCoAkJCcKgwqDCoMKgZGV2 X3ByaXYtPnF1aXJrcyAmIFFVSVJLX1BJTl9TV0laWkxFRF9QQUdFUykgewo+IEBAIC0yODEsNyAr MjkwLDcgQEAgZXJyOgo+IMKgCj4gwqAJaW50ZWxfcnVudGltZV9wbV9wdXQoZGV2X3ByaXYpOwo+ IMKgCj4gLQlyZXR1cm4gcmV0Owo+ICsJcmV0dXJuIGVycjsKPiDCoH0KPiDCoAo+IMKgLyoqCi0t IApKb29uYXMgTGFodGluZW4KT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKSW50ZWwgQ29y cG9yYXRpb24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==