From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX91U-0006SK-Oq for qemu-devel@nongnu.org; Tue, 09 Aug 2016 11:32:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX91O-0005hH-TF for qemu-devel@nongnu.org; Tue, 09 Aug 2016 11:32:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX91O-0005h7-LG for qemu-devel@nongnu.org; Tue, 09 Aug 2016 11:32:50 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 46F7B43A2C for ; Tue, 9 Aug 2016 15:32:50 +0000 (UTC) From: "Daniel P. Berrange" Date: Tue, 9 Aug 2016 16:31:41 +0100 Message-Id: <1470756748-18933-14-git-send-email-berrange@redhat.com> In-Reply-To: <1470756748-18933-1-git-send-email-berrange@redhat.com> References: <1470756748-18933-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH for-2.8 v1 13/60] trace: remove generated-events.h from many includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , "Daniel P. Berrange" Now that none of the public APIs rely on the TraceEventID enum, or related constants, it is possible to simplify the includes, dropping generated-events.h from many of them. Signed-off-by: Daniel P. Berrange --- scripts/tracetool/format/events_h.py | 3 +-- scripts/tracetool/format/h.py | 1 + trace/control.h | 2 +- trace/event-internal.h | 3 --- trace/simple.h | 4 ---- 5 files changed, 3 insertions(+), 10 deletions(-) diff --git a/scripts/tracetool/format/events_h.py b/scripts/tracetool/format/events_h.py index d6465d4..a0fe0c4 100644 --- a/scripts/tracetool/format/events_h.py +++ b/scripts/tracetool/format/events_h.py @@ -58,7 +58,6 @@ def generate(events, backend): out('extern uint16_t dstate[TRACE_EVENT_COUNT];') out('extern bool dstate_init[TRACE_EVENT_COUNT];') - out('#include "trace/event-internal.h"', - 'void trace_register_events(void);', + out('void trace_register_events(void);', '', '#endif /* TRACE__GENERATED_EVENTS_H */') diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.py index 3763e9a..2b82b91 100644 --- a/scripts/tracetool/format/h.py +++ b/scripts/tracetool/format/h.py @@ -24,6 +24,7 @@ def generate(events, backend): '', '#include "qemu-common.h"', '#include "trace/control.h"', + '#include "trace/generated-events.h"', '') backend.generate_begin(events) diff --git a/trace/control.h b/trace/control.h index 242fcf3..8ff0a8f 100644 --- a/trace/control.h +++ b/trace/control.h @@ -11,7 +11,7 @@ #define TRACE__CONTROL_H #include "qemu-common.h" -#include "trace/generated-events.h" +#include "event-internal.h" typedef struct TraceEventIter { size_t event; diff --git a/trace/event-internal.h b/trace/event-internal.h index 618d1b5..3e563fc 100644 --- a/trace/event-internal.h +++ b/trace/event-internal.h @@ -10,9 +10,6 @@ #ifndef TRACE__EVENT_INTERNAL_H #define TRACE__EVENT_INTERNAL_H -#include "trace/generated-events.h" - - /** * TraceEvent: * @id: Unique event identifier. diff --git a/trace/simple.h b/trace/simple.h index 862bbc7..551aaae 100644 --- a/trace/simple.h +++ b/trace/simple.h @@ -11,10 +11,6 @@ #ifndef TRACE_SIMPLE_H #define TRACE_SIMPLE_H - -#include "trace/generated-events.h" - - void st_print_trace_file_status(FILE *stream, fprintf_function stream_printf); void st_set_trace_file_enabled(bool enable); void st_set_trace_file(const char *file); -- 2.7.4