From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 05/33] drm/i915: Reduce amount of duplicate buffer information captured on error Date: Wed, 10 Aug 2016 10:04:16 +0300 Message-ID: <1470812656.4143.14.camel@linux.intel.com> References: <1470581141-14432-1-git-send-email-chris@chris-wilson.co.uk> <1470581141-14432-6-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id DE8A86E6DE for ; Wed, 10 Aug 2016 07:04:19 +0000 (UTC) In-Reply-To: <1470581141-14432-6-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gc3UsIDIwMTYtMDgtMDcgYXQgMTU6NDUgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBA QCAtNDE0LDE4ICs0MDMsMjUgQEAgaW50IGk5MTVfZXJyb3Jfc3RhdGVfdG9fc3RyKHN0cnVjdCBk cm1faTkxNV9lcnJvcl9zdGF0ZV9idWYgKm0sCj4gwqAJCQllcnJvcl9wcmludF9lbmdpbmUobSwg JmVycm9yLT5lbmdpbmVbaV0pOwo+IMKgCX0KPiDCoAo+IC0JZm9yIChpID0gMDsgaSA8IGVycm9y LT52bV9jb3VudDsgaSsrKSB7Cj4gLQkJZXJyX3ByaW50ZihtLCAidm1bJWRdXG4iLCBpKTsKPiAr CWZvciAoaSA9IDA7IGkgPCBJOTE1X05VTV9FTkdJTkVTOyBpKyspIHsKPiArCQlpZiAoIWVycm9y LT5hY3RpdmVfdm1baV0pCj4gKwkJCWJyZWFrOwo+IMKgCj4gLQkJcHJpbnRfZXJyb3JfYnVmZmVy cyhtLCAiQWN0aXZlIiwKPiArCQllcnJfcHJpbnRmKG0sICJBY3RpdmUgdm1bJWRdXG4iLCBpKTsK PiArCQlmb3IgKGogPSAwOyBqIDwgSTkxNV9OVU1fRU5HSU5FUzsgaisrKSB7Cj4gKwkJCWlmIChl cnJvci0+ZW5naW5lW2pdLnZtID09IGVycm9yLT5hY3RpdmVfdm1baV0pCgpicmVhayBoZXJlIGFu ZCB0aGVuIHByaW50IG91dHNpZGUgbG9vcD8KCj4gKwkJCQllcnJfcHJpbnRmKG0sICLCoMKgwqDC oCVzXG4iLAo+ICsJCQkJCcKgwqDCoGRldl9wcml2LT5lbmdpbmVbal0ubmFtZSk7Cj4gKwkJfQo+ ICsKCjxTTklQPgoKPiDCoHN0YXRpYyB2b2lkIGk5MTVfZ2VtX2NhcHR1cmVfdm0oc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IMKgCQkJCXN0cnVjdCBkcm1faTkxNV9lcnJvcl9z dGF0ZSAqZXJyb3IsCj4gwqAJCQkJc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gwqAJ CQkJY29uc3QgaW50IG5keCkKPiDCoHsKPiAtCXN0cnVjdCBkcm1faTkxNV9lcnJvcl9idWZmZXIg KmFjdGl2ZV9ibyA9IE5VTEwsICpwaW5uZWRfYm8gPSBOVUxMOwo+IC0Jc3RydWN0IGRybV9pOTE1 X2dlbV9vYmplY3QgKm9iajsKPiArCXN0cnVjdCBkcm1faTkxNV9lcnJvcl9idWZmZXIgKmFjdGl2 ZV9ibzsKPiDCoAlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPiDCoAlpbnQgaTsKCidjb3VudCc7Cgo+ IMKgCj4gwqAJaSA9IDA7Cj4gwqAJbGlzdF9mb3JfZWFjaF9lbnRyeSh2bWEsICZ2bS0+YWN0aXZl X2xpc3QsIHZtX2xpbmspCj4gwqAJCWkrKzsKPiAtCWVycm9yLT5hY3RpdmVfYm9fY291bnRbbmR4 XSA9IGk7Cj4gLQo+IC0JbGlzdF9mb3JfZWFjaF9lbnRyeShvYmosICZkZXZfcHJpdi0+bW0uYm91 bmRfbGlzdCwgZ2xvYmFsX2xpc3QpIHsKPiAtCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHZtYSwgJm9i ai0+dm1hX2xpc3QsIG9ial9saW5rKQo+IC0JCQlpZiAodm1hLT52bSA9PSB2bSAmJiBpOTE1X3Zt YV9pc19waW5uZWQodm1hKSkKPiAtCQkJCWkrKzsKPiAtCX0KPiAtCWVycm9yLT5waW5uZWRfYm9f Y291bnRbbmR4XSA9IGkgLSBlcnJvci0+YWN0aXZlX2JvX2NvdW50W25keF07Cj4gwqAKPiAtCWlm IChpKSB7Cj4gKwlhY3RpdmVfYm8gPSBOVUxMOwoKQ291bGQgYmUgaW5pdGlhbGl6ZWQgYXQgZGVj bGFyYXRpb24gZm9yIGJldHRlciByZWFkYWJpbGl0eS4KCj4gKwlpZiAoaSkKPiDCoAkJYWN0aXZl X2JvID0ga2NhbGxvYyhpLCBzaXplb2YoKmFjdGl2ZV9ibyksIEdGUF9BVE9NSUMpOwo+IC0JCWlm IChhY3RpdmVfYm8pCj4gLQkJCXBpbm5lZF9ibyA9IGFjdGl2ZV9ibyArIGVycm9yLT5hY3RpdmVf Ym9fY291bnRbbmR4XTsKPiAtCX0KPiAtCj4gwqAJaWYgKGFjdGl2ZV9ibykKPiAtCQllcnJvci0+ YWN0aXZlX2JvX2NvdW50W25keF0gPQo+IC0JCQljYXB0dXJlX2FjdGl2ZV9ibyhhY3RpdmVfYm8s Cj4gLQkJCQkJwqDCoGVycm9yLT5hY3RpdmVfYm9fY291bnRbbmR4XSwKPiAtCQkJCQnCoMKgJnZt LT5hY3RpdmVfbGlzdCk7Cj4gLQo+IC0JaWYgKHBpbm5lZF9ibykKPiAtCQllcnJvci0+cGlubmVk X2JvX2NvdW50W25keF0gPQo+IC0JCQljYXB0dXJlX3Bpbm5lZF9ibyhwaW5uZWRfYm8sCj4gLQkJ CQkJwqDCoGVycm9yLT5waW5uZWRfYm9fY291bnRbbmR4XSwKPiAtCQkJCQnCoMKgJmRldl9wcml2 LT5tbS5ib3VuZF9saXN0LCB2bSk7Cj4gKwkJaSA9IGNhcHR1cmVfZXJyb3JfYm8oYWN0aXZlX2Jv LCBpLCAmdm0tPmFjdGl2ZV9saXN0LCBmYWxzZSk7Cj4gKwllbHNlCj4gKwkJaSA9IDA7Cj4gKwo+ IMKgCWVycm9yLT5hY3RpdmVfYm9bbmR4XSA9IGFjdGl2ZV9ibzsKPiAtCWVycm9yLT5waW5uZWRf Ym9bbmR4XSA9IHBpbm5lZF9ibzsKPiArCWVycm9yLT5hY3RpdmVfYm9fY291bnRbbmR4XSA9IGk7 CgpXaGlsZSBhdCBpdCwgbWFrZSB0aGUgaSB2YXJpYWJsZSAnY291bnQnIGFuZCBpbml0aWFsaXpl IGl0IGF0IHRoZQpkZWNsYXJhdGlvbiB0b28uIEFuZCBtYXliZSBtYWtlIHRoZSBuZHggdmFyaWFi bGUgc29tZXRoaW5nIHJlYXNvbmFibGUKbGlrZSAnZW5naW5lJyBvciAnZWlkJy4KCj4gKwllcnJv ci0+YWN0aXZlX3ZtW25keF0gPSB2bTsKPiDCoH0KPiAKCjxTTklQPgoKPiDCoAo+ICsJZm9yIChp ID0gMDsgaSA8IEk5MTVfTlVNX0VOR0lORVM7IGkrKykgewo+ICsJCXN0cnVjdCBkcm1faTkxNV9l cnJvcl9lbmdpbmUgKmVlID0gJmVycm9yLT5lbmdpbmVbaV07Cj4gKwo+ICsJCWlmICghZWUtPnZt KQo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJZm9yIChqID0gMDsgaiA8IGk7IGorKykKPiArCQkJ aWYgKGVycm9yLT5lbmdpbmVbal0udm0gPT0gZWUtPnZtKQo+ICsJCQkJYnJlYWs7Cj4gKwkJaWYg KGogIT0gaSkKPiArCQkJY29udGludWU7CgpNYXliZSBhZGQgYSBjb21tZW50IHRoYXQgd2Ugd2Fu J3QgdG8gYXZvaWQgY2FwdHVyaW5nIHNhbWUgdm0gdHdpY2UuCgo+ICsKPiArCQlpOTE1X2dlbV9j YXB0dXJlX3ZtKGRldl9wcml2LCBlcnJvciwgZWUtPnZtLCBjbnQrKyk7Cj4gwqAJfQo+IMKgfQo+ IMKgCj4gK3N0YXRpYyB2b2lkIGk5MTVfY2FwdHVyZV9waW5uZWRfYnVmZmVycyhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCQkJc3RydWN0IGRybV9pOTE1X2Vycm9yX3N0 YXRlICplcnJvcikKPiArewo+ICsJc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0gPSAmZGV2 X3ByaXYtPmdndHQuYmFzZTsKPiArCXN0cnVjdCBkcm1faTkxNV9lcnJvcl9idWZmZXIgKmJvOwo+ ICsJc3RydWN0IGk5MTVfdm1hICp2bWE7Cj4gKwlpbnQgaSwgajsKCmNvdW50X2FjdGl2ZSwgY291 bnRfaW5hY3RpdmU/IGkgYW5kIGogYXJlIGl0ZXJhdGlvbiB2YXJpYWJsZXMuCgo+ICsKPiArCWkg PSAwOwo+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeSh2bWEsICZ2bS0+YWN0aXZlX2xpc3QsIHZtX2xp bmspCj4gKwkJaSsrOwo+ICsKPiArCWogPSAwOwo+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeSh2bWEs ICZ2bS0+aW5hY3RpdmVfbGlzdCwgdm1fbGluaykKPiArCQlqKys7Cj4gKwo+ICsJYm8gPSBOVUxM OwoKSW5pdGlhbGl6ZSBhdCBkZWNsYXJhdGlvbiBhcyB0aGlzIGlzIG9uZS1zaG90LgoKPiDCoC8q IENhcHR1cmUgYWxsIHJlZ2lzdGVycyB3aGljaCBkb24ndCBmaXQgaW50byBhbm90aGVyIGNhdGVn b3J5LiAqLwo+IMKgc3RhdGljIHZvaWQgaTkxNV9jYXB0dXJlX3JlZ19zdGF0ZShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gwqAJCQkJwqDCoMKgc3RydWN0IGRybV9pOTE1X2Vy cm9yX3N0YXRlICplcnJvcikKPiBAQCAtMTQzNiwxMCArMTQwMiwxMiBAQCB2b2lkIGk5MTVfY2Fw dHVyZV9lcnJvcl9zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gwqAK PiDCoAlpOTE1X2NhcHR1cmVfZ2VuX3N0YXRlKGRldl9wcml2LCBlcnJvcik7Cj4gwqAJaTkxNV9j YXB0dXJlX3JlZ19zdGF0ZShkZXZfcHJpdiwgZXJyb3IpOwo+IC0JaTkxNV9nZW1fY2FwdHVyZV9i dWZmZXJzKGRldl9wcml2LCBlcnJvcik7Cj4gwqAJaTkxNV9nZW1fcmVjb3JkX2ZlbmNlcyhkZXZf cHJpdiwgZXJyb3IpOwo+IMKgCWk5MTVfZ2VtX3JlY29yZF9yaW5ncyhkZXZfcHJpdiwgZXJyb3Ip Owo+IMKgCj4gKwlpOTE1X2NhcHR1cmVfYWN0aXZlX2J1ZmZlcnMoZGV2X3ByaXYsIGVycm9yKTsK PiArCWk5MTVfY2FwdHVyZV9waW5uZWRfYnVmZmVycyhkZXZfcHJpdiwgZXJyb3IpOwo+ICsKCkFu eSBzcGVjaWZpYyByZWFzb24gZm9yIHJlb3JkZXJpbmcgaGVyZT8KClJlZ2FyZHMsIEpvb25hcwot LSAKSm9vbmFzIExhaHRpbmVuCk9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCkludGVsIENv cnBvcmF0aW9uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=