From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932323AbcHKLcH (ORCPT ); Thu, 11 Aug 2016 07:32:07 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36225 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752420AbcHKLcA (ORCPT ); Thu, 11 Aug 2016 07:32:00 -0400 From: Daniel Romell X-Google-Original-From: Daniel Romell To: a.zummo@towertech.it Cc: alexandre.belloni@free-electrons.com, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, daro@hms.se, jao@hms.se, mago@hms.se Subject: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register. Date: Thu, 11 Aug 2016 13:31:43 +0200 Message-Id: <1470915104-10683-2-git-send-email-daro@hms.se> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1470915104-10683-1-git-send-email-daro@hms.se> References: <1470915104-10683-1-git-send-email-daro@hms.se> MIME-Version: 1.0 In-Reply-To: <1470909555-9226-1-git-send-email-daro@hms.se> References: <1470909555-9226-1-git-send-email-daro@hms.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Östlund The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same value. This is no functional change. Signed-off-by: Daniel Romell --- drivers/rtc/rtc-bq32k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c index 0299988..5a0c137 100644 --- a/drivers/rtc/rtc-bq32k.c +++ b/drivers/rtc/rtc-bq32k.c @@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, struct rtc_time *tm) return error; tm->tm_sec = bcd2bin(regs.seconds & BQ32K_SECONDS_MASK); - tm->tm_min = bcd2bin(regs.minutes & BQ32K_SECONDS_MASK); + tm->tm_min = bcd2bin(regs.minutes & BQ32K_MINUTES_MASK); tm->tm_hour = bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK); tm->tm_mday = bcd2bin(regs.date); tm->tm_wday = bcd2bin(regs.day) - 1; -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com. [2a00:1450:400c:c09::241]) by gmr-mx.google.com with ESMTPS id b77si584392wmb.1.2016.08.11.04.31.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Aug 2016 04:31:59 -0700 (PDT) Received: by mail-wm0-x241.google.com with SMTP id i5so812992wmg.2 for ; Thu, 11 Aug 2016 04:31:59 -0700 (PDT) From: Daniel Romell To: a.zummo@towertech.it Cc: alexandre.belloni@free-electrons.com, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, daro@hms.se, jao@hms.se, mago@hms.se Subject: [rtc-linux] [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register. Date: Thu, 11 Aug 2016 13:31:43 +0200 Message-Id: <1470915104-10683-2-git-send-email-daro@hms.se> In-Reply-To: <1470915104-10683-1-git-send-email-daro@hms.se> References: <1470915104-10683-1-git-send-email-daro@hms.se> MIME-Version: 1.0 In-Reply-To: <1470909555-9226-1-git-send-email-daro@hms.se> References: <1470909555-9226-1-git-send-email-daro@hms.se> Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From: Jan =C3=96stlund The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same value. This is no functional change. Signed-off-by: Daniel Romell --- drivers/rtc/rtc-bq32k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c index 0299988..5a0c137 100644 --- a/drivers/rtc/rtc-bq32k.c +++ b/drivers/rtc/rtc-bq32k.c @@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, struct= rtc_time *tm) return error; =20 tm->tm_sec =3D bcd2bin(regs.seconds & BQ32K_SECONDS_MASK); - tm->tm_min =3D bcd2bin(regs.minutes & BQ32K_SECONDS_MASK); + tm->tm_min =3D bcd2bin(regs.minutes & BQ32K_MINUTES_MASK); tm->tm_hour =3D bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK); tm->tm_mday =3D bcd2bin(regs.date); tm->tm_wday =3D bcd2bin(regs.day) - 1; --=20 2.7.4 --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.