From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932347AbcHKTrd (ORCPT ); Thu, 11 Aug 2016 15:47:33 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:37249 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932265AbcHKTra (ORCPT ); Thu, 11 Aug 2016 15:47:30 -0400 From: Mathieu Poirier To: peterz@infradead.org Cc: mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/3] perf/core: Enabling mapping of the stop filters Date: Thu, 11 Aug 2016 13:47:23 -0600 Message-Id: <1470944843-7575-4-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1470944843-7575-1-git-send-email-mathieu.poirier@linaro.org> References: <1470944843-7575-1-git-send-email-mathieu.poirier@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At this time function perf_addr_filter_needs_mmap() will _not_ return true on a user space 'stop' filter. But stop filters needs exactly the same kind of mapping that range and start filters get. Signed-off-by: Mathieu Poirier Acked-by: Alexander Shishkin --- kernel/events/core.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 463235ffc39c..b5022836649a 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6553,15 +6553,6 @@ got_name: } /* - * Whether this @filter depends on a dynamic object which is not loaded - * yet or its load addresses are not known. - */ -static bool perf_addr_filter_needs_mmap(struct perf_addr_filter *filter) -{ - return filter->filter && filter->inode; -} - -/* * Check whether inode and address range match filter criteria. */ static bool perf_addr_filter_match(struct perf_addr_filter *filter, @@ -7781,7 +7772,11 @@ static void perf_event_addr_filters_apply(struct perf_event *event) list_for_each_entry(filter, &ifh->list, entry) { event->addr_filters_offs[count] = 0; - if (perf_addr_filter_needs_mmap(filter)) + /* + * Adjust base offset if the filter is associated to a binary + * that needs to be mapped. + */ + if (filter->inode) event->addr_filters_offs[count] = perf_addr_filter_apply(filter, mm); -- 2.7.4