* [PATCH] mmc: don't print error when allocating urb fails
@ 2016-08-11 21:03 Wolfram Sang
[not found] ` <1470949433-24707-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb-u79uwXL29TY76Z2rM5mHXA
Cc: Wolfram Sang, linux-mmc-u79uwXL29TY76Z2rM5mHXA
This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses
kmalloc which already prints enough information on failure. So, let's simply
remove those "allocation failed" messages from drivers like we did already for
other -ENOMEM cases. gkh acked this approach when we talked about it at LCJ in
Tokyo a few weeks ago.
Wolfram Sang (1):
mmc: host: vub300: don't print error when allocating urb fails
drivers/mmc/host/vub300.c | 2 --
1 file changed, 2 deletions(-)
--
2.8.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mmc: host: vub300: don't print error when allocating urb fails
[not found] ` <1470949433-24707-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
@ 2016-08-11 21:03 ` Wolfram Sang
2016-08-22 13:39 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2016-08-11 21:03 UTC (permalink / raw)
To: linux-usb-u79uwXL29TY76Z2rM5mHXA
Cc: Wolfram Sang, Tony Olech, Ulf Hansson, linux-mmc-u79uwXL29TY76Z2rM5mHXA
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang <wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
---
drivers/mmc/host/vub300.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index 1e819f98b94f52..bb3e0d1dd35501 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -2116,13 +2116,11 @@ static int vub300_probe(struct usb_interface *interface,
command_out_urb = usb_alloc_urb(0, GFP_KERNEL);
if (!command_out_urb) {
retval = -ENOMEM;
- dev_err(&udev->dev, "not enough memory for command_out_urb\n");
goto error0;
}
command_res_urb = usb_alloc_urb(0, GFP_KERNEL);
if (!command_res_urb) {
retval = -ENOMEM;
- dev_err(&udev->dev, "not enough memory for command_res_urb\n");
goto error1;
}
/* this also allocates memory for our VUB300 mmc host device */
--
2.8.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: host: vub300: don't print error when allocating urb fails
2016-08-11 21:03 ` [PATCH] mmc: host: vub300: " Wolfram Sang
@ 2016-08-22 13:39 ` Ulf Hansson
0 siblings, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2016-08-22 13:39 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Linux USB List, Tony Olech, linux-mmc
On 11 August 2016 at 23:03, Wolfram Sang <wsa-dev@sang-engineering.com> wrote:
> kmalloc will print enough information in case of failure.
>
> Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/vub300.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> index 1e819f98b94f52..bb3e0d1dd35501 100644
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -2116,13 +2116,11 @@ static int vub300_probe(struct usb_interface *interface,
> command_out_urb = usb_alloc_urb(0, GFP_KERNEL);
> if (!command_out_urb) {
> retval = -ENOMEM;
> - dev_err(&udev->dev, "not enough memory for command_out_urb\n");
> goto error0;
> }
> command_res_urb = usb_alloc_urb(0, GFP_KERNEL);
> if (!command_res_urb) {
> retval = -ENOMEM;
> - dev_err(&udev->dev, "not enough memory for command_res_urb\n");
> goto error1;
> }
> /* this also allocates memory for our VUB300 mmc host device */
> --
> 2.8.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-22 13:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-11 21:03 [PATCH] mmc: don't print error when allocating urb fails Wolfram Sang
[not found] ` <1470949433-24707-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
2016-08-11 21:03 ` [PATCH] mmc: host: vub300: " Wolfram Sang
2016-08-22 13:39 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.