All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-dev@sang-engineering.com>
To: linux-usb@vger.kernel.org
Cc: Wolfram Sang <wsa-dev@sang-engineering.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org
Subject: [PATCH 16/28] media: usb: gspca: gspca: don't print error when allocating urb fails
Date: Thu, 11 Aug 2016 23:03:52 +0200	[thread overview]
Message-ID: <1470949451-24823-17-git-send-email-wsa-dev@sang-engineering.com> (raw)
In-Reply-To: <1470949451-24823-1-git-send-email-wsa-dev@sang-engineering.com>

kmalloc will print enough information in case of failure.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
 drivers/media/usb/gspca/gspca.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gspca.c
index b17bd7ebcb47f7..af2395a76d8bf9 100644
--- a/drivers/media/usb/gspca/gspca.c
+++ b/drivers/media/usb/gspca/gspca.c
@@ -795,10 +795,8 @@ static int create_urbs(struct gspca_dev *gspca_dev,
 
 	for (n = 0; n < nurbs; n++) {
 		urb = usb_alloc_urb(npkt, GFP_KERNEL);
-		if (!urb) {
-			pr_err("usb_alloc_urb failed\n");
+		if (!urb)
 			return -ENOMEM;
-		}
 		gspca_dev->urb[n] = urb;
 		urb->transfer_buffer = usb_alloc_coherent(gspca_dev->dev,
 						bsize,
-- 
2.8.1


  parent reply	other threads:[~2016-08-11 21:11 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 21:03 [PATCH 00/28] media: don't print error when allocating urb fails Wolfram Sang
2016-08-11 21:03 ` [PATCH 01/28] media: dvb-frontends: rtl2832_sdr: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 02/28] media: radio: si470x: radio-si470x-usb: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 03/28] media: rc: imon: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 04/28] media: rc: redrat3: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 05/28] media: usb: airspy: airspy: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 06/28] media: usb: as102: as102_usb_drv: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 07/28] media: usb: au0828: au0828-video: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 08/28] media: usb: cpia2: cpia2_usb: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 09/28] media: usb: cx231xx: cx231xx-audio: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 10/28] media: usb: cx231xx: cx231xx-core: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 11/28] media: usb: cx231xx: cx231xx-vbi: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 12/28] media: usb: dvb-usb: dib0700_core: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 13/28] media: usb: em28xx: em28xx-audio: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 14/28] media: usb: em28xx: em28xx-core: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 15/28] media: usb: gspca: benq: " Wolfram Sang
2016-08-11 21:03 ` Wolfram Sang [this message]
2016-08-11 21:03 ` [PATCH 17/28] media: usb: gspca: konica: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 18/28] media: usb: hackrf: hackrf: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 19/28] media: usb: hdpvr: hdpvr-video: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 20/28] media: usb: msi2500: msi2500: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 21/28] media: usb: pwc: pwc-if: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 22/28] media: usb: s2255: s2255drv: " Wolfram Sang
2016-08-11 21:03 ` [PATCH 23/28] media: usb: stk1160: stk1160-video: " Wolfram Sang
2016-08-11 21:04 ` [PATCH 24/28] media: usb: stkwebcam: stk-webcam: " Wolfram Sang
2016-08-11 21:04 ` [PATCH 25/28] media: usb: tm6000: tm6000-dvb: " Wolfram Sang
2016-08-11 21:04 ` [PATCH 26/28] media: usb: tm6000: tm6000-video: " Wolfram Sang
2016-08-11 21:04 ` [PATCH 27/28] media: usb: usbvision: usbvision-core: " Wolfram Sang
2016-08-11 21:04 ` [PATCH 28/28] media: usb: zr364xx: zr364xx: " Wolfram Sang
2016-08-30 17:14 ` [PATCH 00/28] media: " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470949451-24823-17-git-send-email-wsa-dev@sang-engineering.com \
    --to=wsa-dev@sang-engineering.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.