From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932247AbcHKV6B (ORCPT ); Thu, 11 Aug 2016 17:58:01 -0400 Received: from smtprelay0230.hostedemail.com ([216.40.44.230]:48428 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751443AbcHKV55 (ORCPT ); Thu, 11 Aug 2016 17:57:57 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3870:3871:3874:4321:5007:6119:6120:7903:7904:8660:9389:10004:10400:10450:10455:10848:10967:11232:11658:11783:11914:12043:12296:12517:12519:12740:13069:13148:13230:13311:13357:13439:13894:14181:14659:14721:19904:19999:21080:21433:21451:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: scent58_623419e14f919 X-Filterd-Recvd-Size: 1587 Message-ID: <1470952673.14552.32.camel@perches.com> Subject: Re: [RFC PATCH] meminfo: Break apart a very long seq_printf with #ifdefs From: Joe Perches To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Andi Kleen , Alexey Dobriyan , Al Viro Date: Thu, 11 Aug 2016 14:57:53 -0700 In-Reply-To: <20160811145012.3285b5bd289a8d2155ae78a3@linux-foundation.org> References: <20160809162504.2db8051c15afd5618c4b7d7e@linux-foundation.org> <8fce7fdef2ba081a4ef531594e97da8a9feebb58.1470810406.git.joe@perches.com> <20160811145012.3285b5bd289a8d2155ae78a3@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-08-11 at 14:50 -0700, Andrew Morton wrote: > On Tue,  9 Aug 2016 23:38:56 -0700 Joe Perches wrote: > > Use a specific routine to emit most lines so that the code is > > easier to read and maintain. > huh. > >    text    data     bss     dec     hex filename >    2976       8       0    2984     ba8 fs/proc/meminfo.o before >    2669       8       0    2677     a75 fs/proc/meminfo.o after > > Nice.  I wonder why that happened. Fewer shifts via removal of K macro. Much smaller call stack in seq_printf.