From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752385AbcHLJWd (ORCPT ); Fri, 12 Aug 2016 05:22:33 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:23487 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752175AbcHLJW3 (ORCPT ); Fri, 12 Aug 2016 05:22:29 -0400 Message-ID: <1470993703.12736.6.camel@mtksdaap41> Subject: Re: [PATCH v4 9/9] arm64: dts: mediatek: Add Video Decoder for MT8173 From: Tiffany Lin To: Matthias Brugger CC: Hans Verkuil , , "Rob Herring" , Mauro Carvalho Chehab , Daniel Kurtz , "Pawel Osciak" , Eddie Huang , Yingjoe Chen , , , , , , Date: Fri, 12 Aug 2016 17:21:43 +0800 In-Reply-To: References: <1470840534-4788-1-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-2-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-3-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-4-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-5-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-6-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-7-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-8-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-9-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-10-git-send-email-tiffany.lin@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On Thu, 2016-08-11 at 17:44 +0200, Matthias Brugger wrote: > > On 10/08/16 16:48, Tiffany Lin wrote: > > Add video decoder node for MT8173 > > > > Signed-off-by: Tiffany Lin > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++++++++++++++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index 10f638f..2872cd7 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -974,6 +974,50 @@ > > #clock-cells = <1>; > > }; > > > > + vcodec_dec: vcodec@16000000 { > > + compatible = "mediatek,mt8173-vcodec-dec"; > > + reg = <0 0x16000000 0 0x100>, /* VDEC_SYS */ > > + <0 0x16020000 0 0x1000>, /* VDEC_MISC */ > > + <0 0x16021000 0 0x800>, /* VDEC_LD */ > > + <0 0x16021800 0 0x800>, /* VDEC_TOP */ > > + <0 0x16022000 0 0x1000>, /* VDEC_CM */ > > + <0 0x16023000 0 0x1000>, /* VDEC_AD */ > > + <0 0x16024000 0 0x1000>, /* VDEC_AV */ > > + <0 0x16025000 0 0x1000>, /* VDEC_PP */ > > + <0 0x16026800 0 0x800>, /* VDEC_HWD */ > > + <0 0x16027000 0 0x800>, /* VDEC_HWQ */ > > + <0 0x16027800 0 0x800>, /* VDEC_HWB */ > > + <0 0x16028400 0 0x400>; /* VDEC_HWG */ > > + interrupts = ; > > + mediatek,larb = <&larb1>; > > + iommus = <&iommu M4U_PORT_HW_VDEC_MC_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_PP_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_AVC_MV_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_PRED_RD_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_PRED_WR_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_UFO_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_VLD_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_VLD2_EXT>; > > + mediatek,vpu = <&vpu>; > > + power-domains = <&scpsys MT8173_POWER_DOMAIN_VDEC>; > > + clocks = <&apmixedsys CLK_APMIXED_VCODECPLL>, > > + <&topckgen CLK_TOP_UNIVPLL_D2>, > > + <&topckgen CLK_TOP_CCI400_SEL>, > > + <&topckgen CLK_TOP_VDEC_SEL>, > > + <&topckgen CLK_TOP_VCODECPLL>, > > + <&apmixedsys CLK_APMIXED_VENCPLL>, > > + <&topckgen CLK_TOP_VENC_LT_SEL>, > > + <&topckgen CLK_TOP_VCODECPLL_370P5>; > > + clock-names = "vcodecpll", > > + "univpll_d2", > > + "clk_cci400_sel", > > + "vdec_sel", > > + "vdecpll", > > + "vencpll", > > + "venc_lt_sel", > > + "vdec_bus_clk_src"; > > + }; > > + > > Shouldn't we set here: > status = "disabled"; > > To save power on headless systems? > We only power on when there is at least one decode instance created. In this case, do we need "status = "disabled";" here? I see some other device nodes in dtsi do not add this. Sorry, I am just confused when should we add status for device node. best regards, Tiffany > Regards, > Matthias > > > larb1: larb@16010000 { > > compatible = "mediatek,mt8173-smi-larb"; > > reg = <0 0x16010000 0 0x1000>; > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiffany Lin Subject: Re: [PATCH v4 9/9] arm64: dts: mediatek: Add Video Decoder for MT8173 Date: Fri, 12 Aug 2016 17:21:43 +0800 Message-ID: <1470993703.12736.6.camel@mtksdaap41> References: <1470840534-4788-1-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-2-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-3-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-4-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-5-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-6-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-7-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-8-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-9-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-10-git-send-email-tiffany.lin@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Matthias Brugger Cc: Hans Verkuil , daniel.thompson@linaro.org, Rob Herring , Mauro Carvalho Chehab , Daniel Kurtz , Pawel Osciak , Eddie Huang , Yingjoe Chen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, PoChun.Lin@mediatek.com List-Id: devicetree@vger.kernel.org Hi Matthias, On Thu, 2016-08-11 at 17:44 +0200, Matthias Brugger wrote: > > On 10/08/16 16:48, Tiffany Lin wrote: > > Add video decoder node for MT8173 > > > > Signed-off-by: Tiffany Lin > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++++++++++++++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index 10f638f..2872cd7 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -974,6 +974,50 @@ > > #clock-cells = <1>; > > }; > > > > + vcodec_dec: vcodec@16000000 { > > + compatible = "mediatek,mt8173-vcodec-dec"; > > + reg = <0 0x16000000 0 0x100>, /* VDEC_SYS */ > > + <0 0x16020000 0 0x1000>, /* VDEC_MISC */ > > + <0 0x16021000 0 0x800>, /* VDEC_LD */ > > + <0 0x16021800 0 0x800>, /* VDEC_TOP */ > > + <0 0x16022000 0 0x1000>, /* VDEC_CM */ > > + <0 0x16023000 0 0x1000>, /* VDEC_AD */ > > + <0 0x16024000 0 0x1000>, /* VDEC_AV */ > > + <0 0x16025000 0 0x1000>, /* VDEC_PP */ > > + <0 0x16026800 0 0x800>, /* VDEC_HWD */ > > + <0 0x16027000 0 0x800>, /* VDEC_HWQ */ > > + <0 0x16027800 0 0x800>, /* VDEC_HWB */ > > + <0 0x16028400 0 0x400>; /* VDEC_HWG */ > > + interrupts = ; > > + mediatek,larb = <&larb1>; > > + iommus = <&iommu M4U_PORT_HW_VDEC_MC_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_PP_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_AVC_MV_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_PRED_RD_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_PRED_WR_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_UFO_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_VLD_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_VLD2_EXT>; > > + mediatek,vpu = <&vpu>; > > + power-domains = <&scpsys MT8173_POWER_DOMAIN_VDEC>; > > + clocks = <&apmixedsys CLK_APMIXED_VCODECPLL>, > > + <&topckgen CLK_TOP_UNIVPLL_D2>, > > + <&topckgen CLK_TOP_CCI400_SEL>, > > + <&topckgen CLK_TOP_VDEC_SEL>, > > + <&topckgen CLK_TOP_VCODECPLL>, > > + <&apmixedsys CLK_APMIXED_VENCPLL>, > > + <&topckgen CLK_TOP_VENC_LT_SEL>, > > + <&topckgen CLK_TOP_VCODECPLL_370P5>; > > + clock-names = "vcodecpll", > > + "univpll_d2", > > + "clk_cci400_sel", > > + "vdec_sel", > > + "vdecpll", > > + "vencpll", > > + "venc_lt_sel", > > + "vdec_bus_clk_src"; > > + }; > > + > > Shouldn't we set here: > status = "disabled"; > > To save power on headless systems? > We only power on when there is at least one decode instance created. In this case, do we need "status = "disabled";" here? I see some other device nodes in dtsi do not add this. Sorry, I am just confused when should we add status for device node. best regards, Tiffany > Regards, > Matthias > > > larb1: larb@16010000 { > > compatible = "mediatek,mt8173-smi-larb"; > > reg = <0 0x16010000 0 0x1000>; > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: tiffany.lin@mediatek.com (Tiffany Lin) Date: Fri, 12 Aug 2016 17:21:43 +0800 Subject: [PATCH v4 9/9] arm64: dts: mediatek: Add Video Decoder for MT8173 In-Reply-To: References: <1470840534-4788-1-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-2-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-3-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-4-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-5-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-6-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-7-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-8-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-9-git-send-email-tiffany.lin@mediatek.com> <1470840534-4788-10-git-send-email-tiffany.lin@mediatek.com> Message-ID: <1470993703.12736.6.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Matthias, On Thu, 2016-08-11 at 17:44 +0200, Matthias Brugger wrote: > > On 10/08/16 16:48, Tiffany Lin wrote: > > Add video decoder node for MT8173 > > > > Signed-off-by: Tiffany Lin > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++++++++++++++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index 10f638f..2872cd7 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -974,6 +974,50 @@ > > #clock-cells = <1>; > > }; > > > > + vcodec_dec: vcodec at 16000000 { > > + compatible = "mediatek,mt8173-vcodec-dec"; > > + reg = <0 0x16000000 0 0x100>, /* VDEC_SYS */ > > + <0 0x16020000 0 0x1000>, /* VDEC_MISC */ > > + <0 0x16021000 0 0x800>, /* VDEC_LD */ > > + <0 0x16021800 0 0x800>, /* VDEC_TOP */ > > + <0 0x16022000 0 0x1000>, /* VDEC_CM */ > > + <0 0x16023000 0 0x1000>, /* VDEC_AD */ > > + <0 0x16024000 0 0x1000>, /* VDEC_AV */ > > + <0 0x16025000 0 0x1000>, /* VDEC_PP */ > > + <0 0x16026800 0 0x800>, /* VDEC_HWD */ > > + <0 0x16027000 0 0x800>, /* VDEC_HWQ */ > > + <0 0x16027800 0 0x800>, /* VDEC_HWB */ > > + <0 0x16028400 0 0x400>; /* VDEC_HWG */ > > + interrupts = ; > > + mediatek,larb = <&larb1>; > > + iommus = <&iommu M4U_PORT_HW_VDEC_MC_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_PP_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_AVC_MV_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_PRED_RD_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_PRED_WR_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_UFO_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_VLD_EXT>, > > + <&iommu M4U_PORT_HW_VDEC_VLD2_EXT>; > > + mediatek,vpu = <&vpu>; > > + power-domains = <&scpsys MT8173_POWER_DOMAIN_VDEC>; > > + clocks = <&apmixedsys CLK_APMIXED_VCODECPLL>, > > + <&topckgen CLK_TOP_UNIVPLL_D2>, > > + <&topckgen CLK_TOP_CCI400_SEL>, > > + <&topckgen CLK_TOP_VDEC_SEL>, > > + <&topckgen CLK_TOP_VCODECPLL>, > > + <&apmixedsys CLK_APMIXED_VENCPLL>, > > + <&topckgen CLK_TOP_VENC_LT_SEL>, > > + <&topckgen CLK_TOP_VCODECPLL_370P5>; > > + clock-names = "vcodecpll", > > + "univpll_d2", > > + "clk_cci400_sel", > > + "vdec_sel", > > + "vdecpll", > > + "vencpll", > > + "venc_lt_sel", > > + "vdec_bus_clk_src"; > > + }; > > + > > Shouldn't we set here: > status = "disabled"; > > To save power on headless systems? > We only power on when there is at least one decode instance created. In this case, do we need "status = "disabled";" here? I see some other device nodes in dtsi do not add this. Sorry, I am just confused when should we add status for device node. best regards, Tiffany > Regards, > Matthias > > > larb1: larb at 16010000 { > > compatible = "mediatek,mt8173-smi-larb"; > > reg = <0 0x16010000 0 0x1000>; > >