All of lore.kernel.org
 help / color / mirror / Atom feed
From: "seokhoon.yoon" <iamyooon@gmail.com>
To: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	iamyooon@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] sched: remove duplicated init_task's preempt_notifiers init
Date: Tue, 16 Aug 2016 18:26:08 +0900	[thread overview]
Message-ID: <1471339568-5790-1-git-send-email-iamyooon@gmail.com> (raw)

init_task's preempt_notifiers is initialized at two times.

1) sched_init()
   -> INIT_HLIST_HEAD(&init_task.preempt_notifiers)
2) sched_init()
   -> init_idle(current,) <--- current task is init_task at this time
    -> __sched_fork(,current)
     -> INIT_HLIST_HEAD(&p->preempt_notifiers)

I think first one is needless, remove it.

Signed-off-by: seokhoon.yoon <iamyooon@gmail.com>
---
 kernel/sched/core.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 5c883fe..5760f62 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7482,10 +7482,6 @@ void __init sched_init(void)
 
 	set_load_weight(&init_task);
 
-#ifdef CONFIG_PREEMPT_NOTIFIERS
-	INIT_HLIST_HEAD(&init_task.preempt_notifiers);
-#endif
-
 	/*
 	 * The boot idle thread does lazy MMU switching as well:
 	 */
-- 
1.9.1

             reply	other threads:[~2016-08-16  9:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16  9:26 seokhoon.yoon [this message]
2016-09-05 11:55 ` [tip:sched/core] schedcore: Remove duplicated init_task's preempt_notifiers init tip-bot for seokhoon.yoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471339568-5790-1-git-send-email-iamyooon@gmail.com \
    --to=iamyooon@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.