From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gowrishankar Muthukrishnan Subject: [PATCH v6 9/9] table: align rte table hash structs for cache line size Date: Tue, 16 Aug 2016 15:57:59 +0530 Message-ID: <1471343279-24014-10-git-send-email-gowrishankar.m@linux.vnet.ibm.com> References: <1471343279-24014-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> Cc: Chao Zhu , Bruce Richardson , Konstantin Ananyev , Thomas Monjalon , Cristian Dumitrescu , Pradeep To: dev@dpdk.org Return-path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id A66096C99 for ; Tue, 16 Aug 2016 12:28:34 +0200 (CEST) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7GAOtAt055884 for ; Tue, 16 Aug 2016 06:28:33 -0400 Received: from e28smtp05.in.ibm.com (e28smtp05.in.ibm.com [125.16.236.5]) by mx0a-001b2d01.pphosted.com with ESMTP id 24sxunw3dp-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 16 Aug 2016 06:28:33 -0400 Received: from localhost by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Aug 2016 15:58:30 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 8B20AE0060 for ; Tue, 16 Aug 2016 16:02:50 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7GASIki11075876 for ; Tue, 16 Aug 2016 15:58:18 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u7GASHBL021206 for ; Tue, 16 Aug 2016 15:58:18 +0530 In-Reply-To: <1471343279-24014-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte table hash structs rte_bucket_4_8, rte_bucket_4_16 and rte_bucket_4_32 have to be cache aligned as required by their corresponding hash create functions rte_table_hash_create_key8_lru etc. Signed-off-by: Gowrishankar Muthukrishnan --- lib/librte_table/rte_table_hash_key16.c | 4 ++-- lib/librte_table/rte_table_hash_key32.c | 4 ++-- lib/librte_table/rte_table_hash_key8.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_table/rte_table_hash_key16.c b/lib/librte_table/rte_table_hash_key16.c index b7e000f..2102326 100644 --- a/lib/librte_table/rte_table_hash_key16.c +++ b/lib/librte_table/rte_table_hash_key16.c @@ -68,10 +68,10 @@ struct rte_bucket_4_16 { uint64_t next_valid; /* Cache line 1 */ - uint64_t key[4][2]; + uint64_t key[4][2] __rte_cache_aligned; /* Cache line 2 */ - uint8_t data[0]; + uint8_t data[0] __rte_cache_aligned; }; struct rte_table_hash { diff --git a/lib/librte_table/rte_table_hash_key32.c b/lib/librte_table/rte_table_hash_key32.c index a7aba49..619f63a 100644 --- a/lib/librte_table/rte_table_hash_key32.c +++ b/lib/librte_table/rte_table_hash_key32.c @@ -68,10 +68,10 @@ struct rte_bucket_4_32 { uint64_t next_valid; /* Cache lines 1 and 2 */ - uint64_t key[4][4]; + uint64_t key[4][4] __rte_cache_aligned; /* Cache line 3 */ - uint8_t data[0]; + uint8_t data[0] __rte_cache_aligned; }; struct rte_table_hash { diff --git a/lib/librte_table/rte_table_hash_key8.c b/lib/librte_table/rte_table_hash_key8.c index e2e2bdc..4d5e0cd 100644 --- a/lib/librte_table/rte_table_hash_key8.c +++ b/lib/librte_table/rte_table_hash_key8.c @@ -68,7 +68,7 @@ struct rte_bucket_4_8 { uint64_t key[4]; /* Cache line 1 */ - uint8_t data[0]; + uint8_t data[0] __rte_cache_aligned; }; struct rte_table_hash { -- 1.9.1