All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 09/10] efi_loader: Fix efi_install_configuration_table
Date: Fri, 19 Aug 2016 01:23:30 +0200	[thread overview]
Message-ID: <1471562611-93794-11-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1471562611-93794-1-git-send-email-agraf@suse.de>

So far we were only installing the FDT table and didn't have space
to store any other. Hence nobody realized that our efi table allocation
was broken in that it didn't set the indicator for the number of tables
plus one.

This patch fixes it, allowing code to allocate new efi tables.

Signed-off-by: Alexander Graf <agraf@suse.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 lib/efi_loader/efi_boottime.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index 8da0063..da40ddb 100644
--- a/lib/efi_loader/efi_boottime.c
+++ b/lib/efi_loader/efi_boottime.c
@@ -394,7 +394,7 @@ efi_status_t efi_install_configuration_table(const efi_guid_t *guid, void *table
 	/* Add a new entry */
 	memcpy(&efi_conf_table[i].guid, guid, sizeof(*guid));
 	efi_conf_table[i].table = table;
-	systab.nr_tables = i;
+	systab.nr_tables = i + 1;
 
 	return EFI_SUCCESS;
 }
-- 
1.8.5.6

  parent reply	other threads:[~2016-08-18 23:23 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18 23:23 [U-Boot] [PATCH v6 00/10] efi_loader: Expose SMBIOS table Alexander Graf
2016-08-18 23:23 ` [U-Boot] [PATCH v6 01/10] x86: Move table csum into separate file Alexander Graf
2016-08-20 23:52   ` Simon Glass
2016-09-07  1:58   ` Bin Meng
2016-10-13 14:34   ` [U-Boot] [U-Boot, v6, " Alexander Graf
2016-08-18 23:23 ` [U-Boot] [PATCH v6 01/10] x86: Move table csum into separate header Alexander Graf
2016-10-18  3:00   ` Bin Meng
2016-08-18 23:23 ` [U-Boot] [PATCH v6 02/10] x86: Move smbios generation into arch independent directory Alexander Graf
2016-08-20 23:52   ` Simon Glass
2016-10-13 14:35   ` [U-Boot] [U-Boot, v6, " Alexander Graf
2016-08-18 23:23 ` [U-Boot] [PATCH v6 03/10] efi_loader: Expose efi_install_configuration_table Alexander Graf
2016-10-13 14:34   ` [U-Boot] [U-Boot, v6, " Alexander Graf
2016-08-18 23:23 ` [U-Boot] [PATCH v6 04/10] smbios: Allow compilation on 64bit systems Alexander Graf
2016-10-13 14:34   ` [U-Boot] [U-Boot, v6, " Alexander Graf
2016-08-18 23:23 ` [U-Boot] [PATCH v6 05/10] cpu: Add DMTF id and family fields Alexander Graf
2016-08-20 23:52   ` Simon Glass
2016-09-07  2:00   ` Bin Meng
2016-10-13 14:34   ` [U-Boot] [U-Boot,v6,05/10] " Alexander Graf
2016-08-18 23:23 ` [U-Boot] [PATCH v6 06/10] cpu: Add get_vendor callback Alexander Graf
2016-08-20 23:52   ` Simon Glass
2016-09-07  2:02   ` Bin Meng
2016-10-13 14:35   ` [U-Boot] [U-Boot,v6,06/10] " Alexander Graf
2016-08-18 23:23 ` [U-Boot] [PATCH v6 07/10] smbios: Generate type 4 on non-x86 systems Alexander Graf
2016-08-20 23:52   ` Simon Glass
2016-09-07  2:04   ` Bin Meng
2016-10-13 14:35   ` [U-Boot] [U-Boot, v6, " Alexander Graf
2016-10-14  1:50     ` Bin Meng
2016-10-14  5:13       ` Alexander Graf
2016-10-14  5:21         ` Bin Meng
2016-10-14  7:03           ` Alexander Graf
2016-08-18 23:23 ` [U-Boot] [PATCH v6 08/10] smbios: Expose in efi_loader as table Alexander Graf
2016-08-20 23:52   ` Simon Glass
2016-10-13 14:34   ` [U-Boot] [U-Boot, v6, " Alexander Graf
2016-08-18 23:23 ` Alexander Graf [this message]
2016-10-13 14:34   ` [U-Boot] [U-Boot, v6, 09/10] efi_loader: Fix efi_install_configuration_table Alexander Graf
2016-08-18 23:23 ` [U-Boot] [PATCH v6 10/10] smbios: Provide serial number Alexander Graf
2016-10-13 14:34   ` [U-Boot] [U-Boot,v6,10/10] " Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471562611-93794-11-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.