All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Li <ayaka@soulik.info>
To: linux-usb@vger.kernel.org
Cc: johnyoun@synopsys.com, gregkh@linuxfoundation.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, eddie.cai@rock-chips.com,
	randy.li@rock-chips.com, kishon@ti.com,
	linux-kernel@vger.kernel.org, heiko@sntech.de,
	Randy Li <ayaka@soulik.info>
Subject: [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset
Date: Sun, 21 Aug 2016 04:32:20 +0800	[thread overview]
Message-ID: <1471725140-3833-5-git-send-email-ayaka@soulik.info> (raw)
In-Reply-To: <1471725140-3833-1-git-send-email-ayaka@soulik.info>

The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288
has a hardware errata that causes everything to get confused when we get
a remote wakeup.  We'll use the reset that's in the CRU to reset the
port when it's in a bad state.

Note that we add the reset to both dwc2 controllers even though only one
has the errata in case we find some other use for this reset that's
unrelated to the current hardware errata.  Only the host port gets the
quirk property, though.

This patch came from Doug Anderson <dianders@chromium.org> originally.

Signed-off-by: Randy Li <ayaka@soulik.info>
---
 arch/arm/boot/dts/rk3288.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 48ca4e4..646f49d 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -855,6 +855,8 @@
 				clocks = <&cru SCLK_OTGPHY0>;
 				clock-names = "phyclk";
 				#clock-cells = <0>;
+				resets = <&cru SRST_USBOTG_PHY>;
+				reset-names = "phy-reset";
 			};
 
 			usbphy1: usb-phy@334 {
@@ -871,6 +873,9 @@
 				clocks = <&cru SCLK_OTGPHY2>;
 				clock-names = "phyclk";
 				#clock-cells = <0>;
+				resets = <&cru SRST_USBHOST1_PHY>;
+				reset-names = "phy-reset";
+
 			};
 		};
 	};
-- 
2.7.4

  parent reply	other threads:[~2016-08-20 20:42 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30 20:17 [PATCH v2 0/2] Patches to fix remote wakeup on rk3288 dwc2 "host" port Douglas Anderson
2015-10-30 20:17 ` Douglas Anderson
2015-10-30 20:17 ` Douglas Anderson
2015-10-30 20:17 ` [PATCH v2 1/2] usb: dwc2: optionally assert phy "full reset" when waking up Douglas Anderson
2015-11-02 16:12   ` Rob Herring
2015-11-02 16:12     ` Rob Herring
2015-11-02 16:22     ` Doug Anderson
2015-11-02 17:16       ` Rob Herring
2015-11-02 17:48         ` Doug Anderson
2015-11-02 17:48           ` Doug Anderson
     [not found]   ` <1446236275-12698-2-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-19 12:00     ` [PATCH v3 0/2] usb: dwc2: fix the usb host for host port at RK3288 Randy Li
2016-07-19 12:05     ` [PATCH 1/2] usb: dwc2: optionally assert phy "full reset" when waking up Randy Li
     [not found]       ` <1468929933-6971-1-git-send-email-randy.li-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-07-20  1:36         ` Rob Herring
2016-07-20  2:54           ` Randy Li
     [not found]             ` <0c61cf90-6fea-19ce-ce74-91648cb2d921-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-07-21 20:48               ` Rob Herring
2016-08-15 22:19         ` John Youn
     [not found]           ` <38019f37-8d68-b7c1-a5b1-b34ffbadf461-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-08-16  1:10             ` Randy Li
     [not found]               ` <39f96d60-09c0-c71f-b6e3-c84c8304e5f6-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-16  2:33                 ` John Youn
2016-08-20 20:32                   ` [PATCH 0/4 v4] usb: dwc2: fix the usb host for host port at RK32 Randy Li
2016-08-20 20:32                     ` Randy Li
2016-08-20 20:32                     ` [PATCH 1/4] phy: Add reset callback Randy Li
2016-08-20 20:32                     ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li
2016-08-20 20:32                       ` Randy Li
2016-08-22 11:47                       ` Kishon Vijay Abraham I
2016-08-22 11:47                         ` Kishon Vijay Abraham I
2016-08-22 13:00                         ` Heiko Stübner
2016-08-29  9:32                           ` Kishon Vijay Abraham I
2016-08-29  9:32                             ` Kishon Vijay Abraham I
2016-08-20 20:32                     ` [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-20 21:30                       ` Sergei Shtylyov
2016-08-21  7:56                         ` [PATCH 0/4 v5] usb: dwc2: fix the usb host for host port at RK32 Randy Li
2016-08-21  7:56                           ` Randy Li
2016-08-21  7:56                           ` [PATCH 1/4] phy: Add reset callback Randy Li
2016-08-21  7:56                           ` [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li
2016-08-21  7:56                             ` Randy Li
2016-08-23 17:53                             ` Rob Herring
2016-08-23 17:53                               ` Rob Herring
2016-08-21  7:56                           ` [PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-21  7:56                           ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-08-21 11:06                             ` Sergei Shtylyov
2016-08-21 12:19                               ` ayaka
2016-08-21 12:19                                 ` ayaka
2016-08-22 10:30                                 ` Sergei Shtylyov
2016-08-22 10:30                                   ` Sergei Shtylyov
2016-08-21 19:31                         ` [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-08-21 19:31                           ` [RESEND PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-08-21 19:31                             ` Randy Li
2016-08-23 20:46                           ` [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform John Youn
2016-08-23 20:46                             ` John Youn
2016-08-24  8:54                             ` Randy Li
2016-08-24  8:54                               ` Randy Li
2016-08-25 18:23                               ` John Youn
2016-08-25 18:23                                 ` John Youn
2016-08-29  7:51                                 ` Felipe Balbi
2016-08-29  7:51                                   ` Felipe Balbi
2016-08-29 18:24                                   ` John Youn
2016-08-29 18:24                                     ` John Youn
2016-08-20 20:32                     ` Randy Li [this message]
2016-07-19 12:05     ` [PATCH 2/2] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2015-10-30 20:17 ` [PATCH v2 " Douglas Anderson
2015-10-30 20:17   ` Douglas Anderson
2016-09-08 14:27 [PATCH 0/4] the fix for the USB HOST1 at rk3288 platform Randy Li
2016-09-08 14:27 ` [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471725140-3833-5-git-send-email-ayaka@soulik.info \
    --to=ayaka@soulik.info \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.cai@rock-chips.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=johnyoun@synopsys.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=randy.li@rock-chips.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.