From: John Stultz <john.stultz@linaro.org>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Andy Green <andy.green@linaro.org>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Mark Brown <broonie@kernel.org>, Andy Green <andy@warmcat.com>,
John Stultz <john.stultz@linaro.org>
Subject: [RESEND][PATCH 2/7 v4] k3dma: Fix hisi burst clipping
Date: Mon, 22 Aug 2016 15:56:43 -0700 [thread overview]
Message-ID: <1471906608-12418-3-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1471906608-12418-1-git-send-email-john.stultz@linaro.org>
From: Andy Green <andy.green@linaro.org>
Max burst len is a 4-bit field, but at the moment it's clipped with
a 5-bit constant... reduce it to that which can be expressed
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Andy Green <andy@warmcat.com>
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Signed-off-by: Andy Green <andy.green@linaro.org>
[jstultz: Forward ported to mainline]
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
drivers/dma/k3dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
index 39de898..3d51469 100644
--- a/drivers/dma/k3dma.c
+++ b/drivers/dma/k3dma.c
@@ -551,7 +551,7 @@ static int k3_dma_config(struct dma_chan *chan,
c->ccfg |= (val << 12) | (val << 16);
if ((maxburst == 0) || (maxburst > 16))
- val = 16;
+ val = 15;
else
val = maxburst - 1;
c->ccfg |= (val << 20) | (val << 24);
--
1.9.1
next prev parent reply other threads:[~2016-08-22 22:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 22:56 [RESEND][PATCH 0/7 v4] K3DMA fixes for HiKey HDMI audio John Stultz
2016-08-22 22:56 ` [RESEND][PATCH 1/7 v4] Kconfig: Allow k3dma driver to be selected for more then HISI3xx platforms John Stultz
2016-08-23 4:23 ` kbuild test robot
2016-08-23 4:24 ` John Stultz
2016-08-29 8:15 ` Vinod Koul
2016-08-22 22:56 ` John Stultz [this message]
2016-08-22 22:56 ` [RESEND][PATCH 3/7 v4] k3dma: Fix dma err offsets John Stultz
2016-08-22 22:56 ` [RESEND][PATCH 4/7 v4] k3dma: Fix "nobody cared" message seen on any error John Stultz
2016-08-22 22:56 ` [RESEND][PATCH 5/7 v4] k3dma: Fix occasional DMA ERR issue by using proper dma api John Stultz
2016-08-22 22:56 ` [RESEND][PATCH 6/7 v4] k3dma: Fix memory handling in preparation for cyclic mode John Stultz
2016-08-22 22:56 ` [RESEND][PATCH 7/7 v4] k3dma: Add cyclic mode for audio John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471906608-12418-3-git-send-email-john.stultz@linaro.org \
--to=john.stultz@linaro.org \
--cc=andy.green@linaro.org \
--cc=andy@warmcat.com \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=vinod.koul@intel.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.