From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933012AbcHXLgY (ORCPT ); Wed, 24 Aug 2016 07:36:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:54386 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755706AbcHXLeW (ORCPT ); Wed, 24 Aug 2016 07:34:22 -0400 Message-ID: <1472038159.11480.2.camel@suse.com> Subject: Re: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver From: Oliver Neukum To: chunfeng yun Cc: Greg Kroah-Hartman , Mark Rutland , Pawel Moll , Kumar Gala , Sergei Shtylyov , Alan Cooper , Matthias Brugger , Ian Campbell , Mathias Nyman , Rob Herring , Felipe Balbi , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Sascha Hauer , Alan Stern , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Wed, 24 Aug 2016 13:29:19 +0200 In-Reply-To: <1472020923.27677.1.camel@mhfsdcap03> References: <1470730998-9563-1-git-send-email-chunfeng.yun@mediatek.com> <1472020923.27677.1.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-08-24 at 14:42 +0800, chunfeng yun wrote: > Dear all, > > Could you please help me to review the code? Is the structure struct qmu_gpd shared with the hardware? Do I read this correctly that you do PIO to endpoint 0 but DMA to the others? Could you resend the series? Regards Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver Date: Wed, 24 Aug 2016 13:29:19 +0200 Message-ID: <1472038159.11480.2.camel@suse.com> References: <1470730998-9563-1-git-send-email-chunfeng.yun@mediatek.com> <1472020923.27677.1.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1472020923.27677.1.camel@mhfsdcap03> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: chunfeng yun Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felipe Balbi , Pawel Moll , Sergei Shtylyov , Ian Campbell , Greg Kroah-Hartman , Sascha Hauer , Alan Cooper , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mathias Nyman , Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kumar Gala , Matthias Brugger , Alan Stern , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 2016-08-24 at 14:42 +0800, chunfeng yun wrote: > Dear all, > > Could you please help me to review the code? Is the structure struct qmu_gpd shared with the hardware? Do I read this correctly that you do PIO to endpoint 0 but DMA to the others? Could you resend the series? Regards Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 From: oneukum@suse.com (Oliver Neukum) Date: Wed, 24 Aug 2016 13:29:19 +0200 Subject: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver In-Reply-To: <1472020923.27677.1.camel@mhfsdcap03> References: <1470730998-9563-1-git-send-email-chunfeng.yun@mediatek.com> <1472020923.27677.1.camel@mhfsdcap03> Message-ID: <1472038159.11480.2.camel@suse.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2016-08-24 at 14:42 +0800, chunfeng yun wrote: > Dear all, > > Could you please help me to review the code? Is the structure struct qmu_gpd shared with the hardware? Do I read this correctly that you do PIO to endpoint 0 but DMA to the others? Could you resend the series? Regards Oliver