From: Oliver Neukum <oneukum@suse.com>
To: Alban Bedel <alban.bedel@avionic-design.de>
Cc: linux-usb@vger.kernel.org, Freddy Xin <freddy@asix.com.tw>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM
Date: Wed, 24 Aug 2016 16:30:39 +0200 [thread overview]
Message-ID: <1472049039.11480.10.camel@suse.com> (raw)
In-Reply-To: <20160824135231.21782-1-alban.bedel@avionic-design.de>
On Wed, 2016-08-24 at 15:52 +0200, Alban Bedel wrote:
> Implement the .set_eeprom callback to allow setting the MAC address
> as well as a few other parameters. Note that the EEPROM must have a
> correct PID/VID checksum set otherwise the SROM is used and reads
> return the SROM content.
>
> Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de>
> ---
> drivers/net/usb/ax88179_178a.c | 57
> ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
> diff --git a/drivers/net/usb/ax88179_178a.c
> b/drivers/net/usb/ax88179_178a.c
> index e6338c16081a..e6a986303dad 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -28,6 +28,7 @@
>
> #define AX88179_PHY_ID 0x03
> #define AX_EEPROM_LEN 0x100
> +#define AX_EEPROM_BLOCK 0x40u
> #define AX88179_EEPROM_MAGIC 0x17900b95
> #define AX_MCAST_FLTSIZE 8
> #define AX_MAX_MCAST 64
> @@ -43,6 +44,7 @@
> #define AX_ACCESS_PHY 0x02
> #define AX_ACCESS_EEPROM 0x04
> #define AX_ACCESS_EFUS 0x05
> +#define AX_RELOAD_EEPROM 0x06
> #define AX_PAUSE_WATERLVL_HIGH 0x54
> #define AX_PAUSE_WATERLVL_LOW 0x55
>
> @@ -620,6 +622,60 @@ ax88179_get_eeprom(struct net_device *net, struct
> ethtool_eeprom *eeprom,
> return 0;
> }
>
> +static int
> +ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom
> *eeprom,
> + u8 *data)
> +{
> + struct usbnet *dev = netdev_priv(net);
> + unsigned int offset = eeprom->offset;
> + unsigned int len = eeprom->len;
> + int i, err = 0;
> + u8 *block;
> +
> + /* The EEPROM data must be aligned on blocks of 64 bytes */
> + if ((offset % AX_EEPROM_BLOCK) || (len % AX_EEPROM_BLOCK)) {
> + offset = eeprom->offset / AX_EEPROM_BLOCK *
> AX_EEPROM_BLOCK;
> + len = eeprom->len + eeprom->offset - offset;
> + len = DIV_ROUND_UP(len, AX_EEPROM_BLOCK) *
> AX_EEPROM_BLOCK;
> +
> + block = kmalloc(len, GFP_KERNEL);
> + if (!block)
> + return -ENOMEM;
> +
> + /* Copy the current data, we could skip some but KISS
> */
> + for (i = 0; i < len; i += AX_EEPROM_BLOCK) {
> + err = __ax88179_read_cmd(dev,
> AX_ACCESS_EEPROM,
> + (offset + i) >> 1,
> + AX_EEPROM_BLOCK >> 1,
> + AX_EEPROM_BLOCK,
> + &block[i], 0);
> + if (err < 0) {
> + kfree(block);
> + return err;
> + }
> + }
> + memcpy(block + eeprom->offset - offset, data,
> eeprom->len);
> + } else {
> + block = data;
> + }
> +
> + for (i = 0; err >= 0 && i < len; i += AX_EEPROM_BLOCK) {
> + err = ax88179_write_cmd(dev, AX_ACCESS_EEPROM,
> + (offset + i) >> 1,
> + AX_EEPROM_BLOCK >> 1,
> + AX_EEPROM_BLOCK, &block[i]);
> + }
> +
> + if (block != data)
> + kfree(block);
And if block == dta, what frees the memory?
Regards
Oliver
next prev parent reply other threads:[~2016-08-24 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 13:52 [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM Alban Bedel
2016-08-24 14:30 ` Oliver Neukum [this message]
2016-08-24 14:40 ` Alban Bedel
2016-08-25 9:16 ` Oliver Neukum
2016-08-25 10:07 ` Alban Bedel
2016-08-25 10:08 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472049039.11480.10.camel@suse.com \
--to=oneukum@suse.com \
--cc=alban.bedel@avionic-design.de \
--cc=freddy@asix.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.