From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>,
Julien Goodwin <julieng@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter
Date: Wed, 24 Aug 2016 10:50:32 -0700 [thread overview]
Message-ID: <1472061032.14381.112.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <20160824103520.56fad551@xeon-e3>
On Wed, 2016-08-24 at 10:35 -0700, Stephen Hemminger wrote:
> You can't add value in middle of user API enum without breaking
> binary compatibility.
There is no binary compatibility here.
/proc/net/netstat is a text file with a defined format.
First line contains the headers.
If 'binary compatibility 'was an issue, we would not have added anything
in this file.
Programs need to be able to properly parse these TcpExt: lines.
nstat is doing the right thing.
I could put LINUX_MIB_TCPMD5FAILURE at the end, but 'nstat' would have
these MD5 counters in different places.
So for the few people (ie not programs) looking at nstat, it seems
better to place this MIB at this point.
next prev parent reply other threads:[~2016-08-24 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 16:01 [PATCH net-next] tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter Eric Dumazet
2016-08-24 17:35 ` Stephen Hemminger
2016-08-24 17:50 ` Eric Dumazet [this message]
2016-08-25 23:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472061032.14381.112.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=julieng@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.