From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758380AbcHYH00 (ORCPT ); Thu, 25 Aug 2016 03:26:26 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:54873 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758004AbcHYH0X (ORCPT ); Thu, 25 Aug 2016 03:26:23 -0400 Message-ID: <1472109786.3032.21.camel@pengutronix.de> Subject: Re: [PATCH 09/10] reset: zynq: add driver Kconfig option From: Philipp Zabel To: Masahiro Yamada Cc: Linux Kernel Mailing List , Arnd Bergmann , Axel Lin , Hans de Goede , Maxime Ripard , Lee Jones , linux-arm-kernel , Moritz Fischer , Michal Simek , =?ISO-8859-1?Q?S=F6ren?= Brinkmann Date: Thu, 25 Aug 2016 09:23:06 +0200 In-Reply-To: References: <1472045342-7434-1-git-send-email-p.zabel@pengutronix.de> <1472045342-7434-9-git-send-email-p.zabel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 25.08.2016, 10:08 +0900 schrieb Masahiro Yamada: > 2016-08-25 2:48 GMT+09:00 Masahiro Yamada : > > 2016-08-24 22:29 GMT+09:00 Philipp Zabel : > >> Visible only if COMPILE_TEST is enabled, this allows to include the > >> driver in build tests. > >> > >> Cc: Moritz Fischer > >> Cc: Michal Simek > >> Cc: Sören Brinkmann > >> Signed-off-by: Philipp Zabel > >> --- > >> drivers/reset/Kconfig | 6 ++++++ > >> drivers/reset/Makefile | 2 +- > >> 2 files changed, 7 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > >> index 17030e2..86b49a2 100644 > >> --- a/drivers/reset/Kconfig > >> +++ b/drivers/reset/Kconfig > >> @@ -67,6 +67,12 @@ config RESET_SUNXI > >> help > >> This enables the reset driver for Allwinner SoCs. > >> > >> +config RESET_ZYNQ > >> + bool "ZYNQ Reset Driver" if COMPILE_TEST > >> + default ARCH_ZYNQ > >> + help > >> + This enables the reset driver for Xilinx Zynq FPGAs. > >> + > > > > Please move this below RESET_UNIPHIER > > as I assume you are sorting Kconfig entries alphabetically. Yes, that was my intention. > > Otherwise, > > > > Reviewed-by: Masahiro Yamada > > > > > > > >> + This enables the reset driver for Xilinx Zynq FPGAs. > > > One more thing, I thought this statement is not precise > because Zynq is not only an FPGA, > but ARM SoC + FPGA. > > Please consider to reword > > "This enables the reset driver for Xilinx Zynq SoC" I'll change it to SoCs, thanks. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: p.zabel@pengutronix.de (Philipp Zabel) Date: Thu, 25 Aug 2016 09:23:06 +0200 Subject: [PATCH 09/10] reset: zynq: add driver Kconfig option In-Reply-To: References: <1472045342-7434-1-git-send-email-p.zabel@pengutronix.de> <1472045342-7434-9-git-send-email-p.zabel@pengutronix.de> Message-ID: <1472109786.3032.21.camel@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Donnerstag, den 25.08.2016, 10:08 +0900 schrieb Masahiro Yamada: > 2016-08-25 2:48 GMT+09:00 Masahiro Yamada : > > 2016-08-24 22:29 GMT+09:00 Philipp Zabel : > >> Visible only if COMPILE_TEST is enabled, this allows to include the > >> driver in build tests. > >> > >> Cc: Moritz Fischer > >> Cc: Michal Simek > >> Cc: S?ren Brinkmann > >> Signed-off-by: Philipp Zabel > >> --- > >> drivers/reset/Kconfig | 6 ++++++ > >> drivers/reset/Makefile | 2 +- > >> 2 files changed, 7 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > >> index 17030e2..86b49a2 100644 > >> --- a/drivers/reset/Kconfig > >> +++ b/drivers/reset/Kconfig > >> @@ -67,6 +67,12 @@ config RESET_SUNXI > >> help > >> This enables the reset driver for Allwinner SoCs. > >> > >> +config RESET_ZYNQ > >> + bool "ZYNQ Reset Driver" if COMPILE_TEST > >> + default ARCH_ZYNQ > >> + help > >> + This enables the reset driver for Xilinx Zynq FPGAs. > >> + > > > > Please move this below RESET_UNIPHIER > > as I assume you are sorting Kconfig entries alphabetically. Yes, that was my intention. > > Otherwise, > > > > Reviewed-by: Masahiro Yamada > > > > > > > >> + This enables the reset driver for Xilinx Zynq FPGAs. > > > One more thing, I thought this statement is not precise > because Zynq is not only an FPGA, > but ARM SoC + FPGA. > > Please consider to reword > > "This enables the reset driver for Xilinx Zynq SoC" I'll change it to SoCs, thanks. regards Philipp