From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:41400 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759193AbcHYIaU (ORCPT ); Thu, 25 Aug 2016 04:30:20 -0400 Message-ID: <1472112020.24772.4.camel@sipsolutions.net> (sfid-20160825_103040_411309_68EBF8E4) Subject: Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute From: Johannes Berg To: Christoph Hellwig , "Luis R. Rodriguez" Cc: Cristina Moraru , "vegard.nossum@gmail.com" , Valentin Rothberg , Hannes Reinecke , Sam Ravnborg , Michal Marek , linux-kernel@vger.kernel.org, teg@jklm.no, kay@vrfy.org, rusty@rustcorp.com.au, akpm@linux-foundation.org, backports@vger.kernel.org, Guenter Roeck , Greg Kroah-Hartman , "rafael.j.wysocki" , Dmitry Torokhov , Takashi Iwai , Mauro Carvalho Chehab , Hauke Mehrtens , Paul Bolle , Paul Gortmaker , Alexey Khoroshilov , Sathya Prakash Veerichetty , "Martin K. Petersen" , Laurence Oberman , Johannes Thumshirn , Tejun Heo , Jej B , Theodore Ts'o , danijons@student.chalmers.se, Andrzej Wasowski Date: Thu, 25 Aug 2016 10:00:20 +0200 In-Reply-To: <20160825074313.GC18622@lst.de> References: <1471462023-119645-1-git-send-email-cristina.moraru09@gmail.com> <20160818175505.GM3296@wotan.suse.de> <20160825074313.GC18622@lst.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: backports-owner@vger.kernel.org List-ID: > The other nice thing is that we could probably fold most of the > Makefiles into Kconfig using that methods as well, by listing the > objectes required for a module, e.g. > > module NVME_TARGET > tristate "NVMe Target support" > depends on BLOCK > depends on CONFIGFS_FS > name nvmet > objects core.o configfs.o admin-cmd.o io-cmd.o fabrics-cmd.o > objects discovery.o > If this was going to be a thing, then you might also have config NVME_TARGET_FOO bool "NVMe target supports FOO" module NVME_TARGET objects foo.o The "module" would be like a "depends on" plus giving the module for generating the Makefile, and now you can really remove most Makefile stuff... :) johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759245AbcHYIaW (ORCPT ); Thu, 25 Aug 2016 04:30:22 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:41400 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759193AbcHYIaU (ORCPT ); Thu, 25 Aug 2016 04:30:20 -0400 Message-ID: <1472112020.24772.4.camel@sipsolutions.net> Subject: Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute From: Johannes Berg To: Christoph Hellwig , "Luis R. Rodriguez" Cc: Cristina Moraru , "vegard.nossum@gmail.com" , Valentin Rothberg , Hannes Reinecke , Sam Ravnborg , Michal Marek , linux-kernel@vger.kernel.org, teg@jklm.no, kay@vrfy.org, rusty@rustcorp.com.au, akpm@linux-foundation.org, backports@vger.kernel.org, Guenter Roeck , Greg Kroah-Hartman , "rafael.j.wysocki" , Dmitry Torokhov , Takashi Iwai , Mauro Carvalho Chehab , Hauke Mehrtens , Paul Bolle , Paul Gortmaker , Alexey Khoroshilov , Sathya Prakash Veerichetty , "Martin K. Petersen" , Laurence Oberman , Johannes Thumshirn , Tejun Heo , Jej B , "Theodore Ts'o" , danijons@student.chalmers.se, Andrzej Wasowski Date: Thu, 25 Aug 2016 10:00:20 +0200 In-Reply-To: <20160825074313.GC18622@lst.de> References: <1471462023-119645-1-git-send-email-cristina.moraru09@gmail.com> <20160818175505.GM3296@wotan.suse.de> <20160825074313.GC18622@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The other nice thing is that we could probably fold most of the > Makefiles into Kconfig using that methods as well, by listing the > objectes required for a module, e.g. > > module NVME_TARGET > tristate "NVMe Target support" > depends on BLOCK > depends on CONFIGFS_FS > name nvmet > objects core.o configfs.o admin-cmd.o io-cmd.o fabrics-cmd.o > objects discovery.o > If this was going to be a thing, then you might also have config NVME_TARGET_FOO bool "NVMe target supports FOO" module NVME_TARGET objects foo.o The "module" would be like a "depends on" plus giving the module for generating the Makefile, and now you can really remove most Makefile stuff... :) johannes