From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernard Iremonger Subject: [RFC PATCH v2 1/5] librte_ether: add internal callback functions Date: Fri, 26 Aug 2016 10:10:16 +0100 Message-ID: <1472202620-20487-2-git-send-email-bernard.iremonger@intel.com> References: <1471528125-26357-1-git-send-email-bernard.iremonger@intel.com> <1472202620-20487-1-git-send-email-bernard.iremonger@intel.com> Cc: Bernard Iremonger , azelezniak To: rahul.r.shah@intel.com, wenzhuo.lu@intel.com, dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2245058EC for ; Fri, 26 Aug 2016 11:10:27 +0200 (CEST) In-Reply-To: <1472202620-20487-1-git-send-email-bernard.iremonger@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" add _rte_eth_dev_callback_process_vf function. add _rte_eth_dev_callback_process_generic function Adding a callback to the user application on VF to PF mailbox message, allows passing information to the application controlling the PF when a VF mailbox event message is received, such as VF reset. Signed-off-by: azelezniak Signed-off-by: Bernard Iremonger --- lib/librte_ether/rte_ethdev.c | 17 ++++++++++ lib/librte_ether/rte_ethdev.h | 61 ++++++++++++++++++++++++++++++++++ lib/librte_ether/rte_ether_version.map | 7 ++++ 3 files changed, 85 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index f62a9ec..1388ea3 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -2690,6 +2690,20 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, enum rte_eth_event_type event) { + return _rte_eth_dev_callback_process_generic(dev, event, NULL); +} + +void +_rte_eth_dev_callback_process_vf(struct rte_eth_dev *dev, + enum rte_eth_event_type event, void *param) +{ + return _rte_eth_dev_callback_process_generic(dev, event, param); +} + +void +_rte_eth_dev_callback_process_generic(struct rte_eth_dev *dev, + enum rte_eth_event_type event, void *param) +{ struct rte_eth_dev_callback *cb_lst; struct rte_eth_dev_callback dev_cb; @@ -2699,6 +2713,9 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev, continue; dev_cb = *cb_lst; cb_lst->active = 1; + if (param != NULL) + dev_cb.cb_arg = (void *) param; + rte_spinlock_unlock(&rte_eth_dev_cb_lock); dev_cb.cb_fn(dev->data->port_id, dev_cb.event, dev_cb.cb_arg); diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index b0fe033..4fb0b9c 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -3047,9 +3047,27 @@ enum rte_eth_event_type { /**< queue state event (enabled/disabled) */ RTE_ETH_EVENT_INTR_RESET, /**< reset interrupt event, sent to VF on PF reset */ + RTE_ETH_EVENT_VF_MBOX, /**< PF mailbox processing callback */ RTE_ETH_EVENT_MAX /**< max value of this enum */ }; +/** + * Response sent back to ixgbe driver from user app after callback + */ +enum rte_eth_mb_event_rsp { + RTE_ETH_MB_EVENT_NOOP_ACK, /**< skip mbox request and ACK */ + RTE_ETH_MB_EVENT_NOOP_NACK, /**< skip mbox request and NACK */ + RTE_ETH_MB_EVENT_PROCEED, /**< proceed with mbox request */ + RTE_ETH_MB_EVENT_MAX /**< max value of this enum */ +}; + +struct rte_eth_mb_event_param { + uint16_t vfid; + uint16_t msg_type; + uint16_t retval; + void *userdata; +}; + typedef void (*rte_eth_dev_cb_fn)(uint8_t port_id, \ enum rte_eth_event_type event, void *cb_arg); /**< user application callback to be registered for interrupts */ @@ -3114,6 +3132,49 @@ void _rte_eth_dev_callback_process(struct rte_eth_dev *dev, enum rte_eth_event_type event); /** + * @internal Executes all the user application registered callbacks for + * the specific device where parameter have to be passed to user application. + * It is for DPDK internal user only. User application should not call it + * directly. + * + * @param dev + * Pointer to struct rte_eth_dev. + * @param event + * Eth device interrupt event type. + * + * @param param + * parameters to pass back to user application. + * + * @return + * void + */ + +void +_rte_eth_dev_callback_process_vf(struct rte_eth_dev *dev, + enum rte_eth_event_type event, void *param); + +/** + * @internal Executes all the user application registered callbacks. Used by: + * _rte_eth_dev_callback_process and _rte_eth_dev_callback_process_vf + * It is for DPDK internal user only. User application should not call it + * directly. + * + * @param dev + * Pointer to struct rte_eth_dev. + * @param event + * Eth device interrupt event type. + * + * @param param + * parameters to pass back to user application. + * + * @return + * void + */ +void +_rte_eth_dev_callback_process_generic(struct rte_eth_dev *dev, + enum rte_eth_event_type event, void *param); + +/** * When there is no rx packet coming in Rx Queue for a long time, we can * sleep lcore related to RX Queue for power saving, and enable rx interrupt * to be triggered when rx packect arrives. diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index 45ddf44..cb7ef15 100644 --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/rte_ether_version.map @@ -139,3 +139,10 @@ DPDK_16.07 { rte_eth_dev_get_port_by_name; rte_eth_xstats_get_names; } DPDK_16.04; + +DPDK_16.11 { + global: + + _rte_eth_dev_callback_process_generic; + _rte_eth_dev_callback_process_vf; +} DPDK_16.07; -- 2.9.0