Re: [PATCH v10 0/9] submodule inline diff format

From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "sbeller@google.com" <sbeller@google.com>,
	"jacob.keller@gmail.com" <jacob.keller@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
	"j6t@kdbg.org" <j6t@kdbg.org>,
	"gitster@pobox.com" <gitster@pobox.com>,
	"peff@peff.net" <peff@peff.net>,
	"stefanbeller@gmail.com" <stefanbeller@gmail.com>
Subject: Re: [PATCH v10 0/9] submodule inline diff format
Date: Fri, 26 Aug 2016 18:26:55 +0000	[thread overview]
Message-ID: <1472236015.28343.3.camel@intel.com> (raw)
In-Reply-To: <CAGZ79kYbHz2E6-0qNS47KfA5Gs=Ew327LxhOyq+i3axwPVHKGQ@mail.gmail.com>

On Fri, 2016-08-26 at 10:35 -0700, Stefan Beller wrote:
> > a) read_gitfile on <path>/.git
> > b) if read_gitfile succeeds, use it's contents, otherwise use
> > <path>/.git for next steps
> > c) check if the resulting file is a git directory, we're fine.. we
> > found a gitdir, so stop.
> > d) otherwise,  empty the buffer, then lookup submodules
> > e) when submodules lookup succeeds.. see if we found a name. If so,
> > use that.
> 
> When the submodules lookup succeeds, we can assert the name exists.
> There is currently only one way the lookup is populated, and that is
> lookup_or_create_by_name in submodule-config.c:182, which fills in
> the name all the time.

Yes, that was how I was trying to word it, and that's what I've done in
code.

> 
> > 
> > f) if we didn't just exit with an empty buffer.
> > 
> > That empty buffer *should* trigger  revision error codes since it
> > won't point to any valid path and it also triggers the regular
> > error
> > code in add_submodule_odb so it handles that with showing not
> > initizlied.
> > 
> > This method is less work then re-implementing a _gently() variant
> > for
> > all of these functions.
> > 
> > Stefan, does this make sense and seem reasonable?
> 
> Sounds reasonable to me.
> 
> Thanks for working on this!
> Stefan

Thanks for review!

Regards,
Jake