* [PATCH] video: fbdev: intelfb: remove impossible condition
@ 2016-08-31 15:56 ` Sudip Mukherjee
0 siblings, 0 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2016-08-31 15:44 UTC (permalink / raw)
To: Maik Broemme, Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: linux-kernel, linux-fbdev, Sudip Mukherjee
xoffset and yoffset of struct fb_var_screeninfo are unsigned and so
they can never be less than 0.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
drivers/video/fbdev/intelfb/intelfbdrv.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
index bf20744..ff2a5d2 100644
--- a/drivers/video/fbdev/intelfb/intelfbdrv.c
+++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
@@ -1301,11 +1301,6 @@ static int intelfb_check_var(struct fb_var_screeninfo *var,
break;
}
- if (v.xoffset < 0)
- v.xoffset = 0;
- if (v.yoffset < 0)
- v.yoffset = 0;
-
if (v.xoffset > v.xres_virtual - v.xres)
v.xoffset = v.xres_virtual - v.xres;
if (v.yoffset > v.yres_virtual - v.yres)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] video: fbdev: intelfb: remove impossible condition
@ 2016-08-31 15:56 ` Sudip Mukherjee
0 siblings, 0 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2016-08-31 15:56 UTC (permalink / raw)
To: Maik Broemme, Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: linux-kernel, linux-fbdev, Sudip Mukherjee
xoffset and yoffset of struct fb_var_screeninfo are unsigned and so
they can never be less than 0.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
drivers/video/fbdev/intelfb/intelfbdrv.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
index bf20744..ff2a5d2 100644
--- a/drivers/video/fbdev/intelfb/intelfbdrv.c
+++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
@@ -1301,11 +1301,6 @@ static int intelfb_check_var(struct fb_var_screeninfo *var,
break;
}
- if (v.xoffset < 0)
- v.xoffset = 0;
- if (v.yoffset < 0)
- v.yoffset = 0;
-
if (v.xoffset > v.xres_virtual - v.xres)
v.xoffset = v.xres_virtual - v.xres;
if (v.yoffset > v.yres_virtual - v.yres)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] video: fbdev: intelfb: remove impossible condition
2016-08-31 15:56 ` Sudip Mukherjee
@ 2016-09-07 8:16 ` Tomi Valkeinen
-1 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2016-09-07 8:16 UTC (permalink / raw)
To: Sudip Mukherjee, Maik Broemme, Jean-Christophe Plagniol-Villard
Cc: linux-kernel, linux-fbdev
[-- Attachment #1.1: Type: text/plain, Size: 937 bytes --]
On 31/08/16 18:44, Sudip Mukherjee wrote:
> xoffset and yoffset of struct fb_var_screeninfo are unsigned and so
> they can never be less than 0.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> drivers/video/fbdev/intelfb/intelfbdrv.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
> index bf20744..ff2a5d2 100644
> --- a/drivers/video/fbdev/intelfb/intelfbdrv.c
> +++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
> @@ -1301,11 +1301,6 @@ static int intelfb_check_var(struct fb_var_screeninfo *var,
> break;
> }
>
> - if (v.xoffset < 0)
> - v.xoffset = 0;
> - if (v.yoffset < 0)
> - v.yoffset = 0;
> -
> if (v.xoffset > v.xres_virtual - v.xres)
> v.xoffset = v.xres_virtual - v.xres;
> if (v.yoffset > v.yres_virtual - v.yres)
>
Thanks, queued for 4.9.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] video: fbdev: intelfb: remove impossible condition
@ 2016-09-07 8:16 ` Tomi Valkeinen
0 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2016-09-07 8:16 UTC (permalink / raw)
To: Sudip Mukherjee, Maik Broemme, Jean-Christophe Plagniol-Villard
Cc: linux-kernel, linux-fbdev
[-- Attachment #1.1: Type: text/plain, Size: 937 bytes --]
On 31/08/16 18:44, Sudip Mukherjee wrote:
> xoffset and yoffset of struct fb_var_screeninfo are unsigned and so
> they can never be less than 0.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> drivers/video/fbdev/intelfb/intelfbdrv.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
> index bf20744..ff2a5d2 100644
> --- a/drivers/video/fbdev/intelfb/intelfbdrv.c
> +++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
> @@ -1301,11 +1301,6 @@ static int intelfb_check_var(struct fb_var_screeninfo *var,
> break;
> }
>
> - if (v.xoffset < 0)
> - v.xoffset = 0;
> - if (v.yoffset < 0)
> - v.yoffset = 0;
> -
> if (v.xoffset > v.xres_virtual - v.xres)
> v.xoffset = v.xres_virtual - v.xres;
> if (v.yoffset > v.yres_virtual - v.yres)
>
Thanks, queued for 4.9.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-07 8:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-31 15:44 [PATCH] video: fbdev: intelfb: remove impossible condition Sudip Mukherjee
2016-08-31 15:56 ` Sudip Mukherjee
2016-09-07 8:16 ` Tomi Valkeinen
2016-09-07 8:16 ` Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.