All of lore.kernel.org
 help / color / mirror / Atom feed
From: Knut Omang <knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mukesh Kacker
	<mukesh.kacker-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Knut Omang <knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH libibverbs 0/3] SIF related libibverbs patches
Date: Thu,  1 Sep 2016 08:59:50 +0200	[thread overview]
Message-ID: <1472713193-22397-1-git-send-email-knut.omang@oracle.com> (raw)

This is the initial patch series for the work of upstreaming the driver and
user level library for SIF, the new Oracle HCA. My philosophy here has been to
make the initial patches as little intrusive as possible, and rather consolidate
later. For instance patch 1 could have just changed the signature of ibv_cmd_create_ah but that
would have required a simultaneous change of all vendor libraries, which is
much easier to accomplish if they all end up in the same repository...

These patches are needed to support SIF - Oracle's new Infiniband HCA stack
from user mode. A corresponding patch set for the kernel will follow shortly.

I have been back and forth with whether or not an ABI version update is required/desired
for the (bugfix) patch 2 in this series, which will be followed by a corresponding patch
at the kernel level. This should ideally have been a backward compatible change since it does not
really logically change the APIs, but because the kernel checks for exact match of
sizes of the cmd structures instead of just accepting the expected size even if the
provided size is larger, both sides need to change simultaneously in this case to avoid
breaking (ibv_reg_mr). In fact, looking at the last ABI change it seems running with version
5 of the ABI on the kernel side is supported, but it will still fail due to the same reason.

No changes are needed for the vendor libraries, except that they need to be rebuilt against the
changed kern-abi.h file due to the same size check in the kernel.

We need this patch because we have a vendor specific extension to the ibv_reg_mr response,
which breaks if alignment criterias are violated.

This patch 2 and the corresponding kernel patch does not update the ABI version,
let me know what you think, if an update is desired, and what MIN and MAX versions
we would want to set.

Patch set:

Knut Omang (3):
  Add new call ibv_cmd_create_ah_ex which supports extra parameters
  Add padding to get proper end alignment of ibv_reg_mr_resp
  Provide remote XRC SRQ number in kernel post_send.

 include/infiniband/driver.h   |  4 ++++
 include/infiniband/kern-abi.h |  2 ++
 src/cmd.c                     | 55 ++++++++++++++++++++++++++-----------------
 src/libibverbs.map            |  1 +
 4 files changed, 40 insertions(+), 22 deletions(-)

--
2.5.5
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2016-09-01  6:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01  6:59 Knut Omang [this message]
     [not found] ` <1472713193-22397-1-git-send-email-knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-01  6:59   ` [PATCH libibverbs 1/3] Add new call ibv_cmd_create_ah_ex which supports extra parameters Knut Omang
     [not found]     ` <1472713193-22397-2-git-send-email-knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-01  8:34       ` Yishai Hadas
     [not found]         ` <09e67035-0c8a-9b44-fa84-08413dd6ac46-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-09-01  9:53           ` Knut Omang
2016-09-05 11:53           ` Knut Omang
     [not found]             ` <1473076411.3975.87.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-05 14:05               ` Yishai Hadas
     [not found]                 ` <50c8e0ab-f7f4-85b1-09f7-a930ad445ee0-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-09-05 14:55                   ` Knut Omang
2016-09-01 16:49       ` Jason Gunthorpe
     [not found]         ` <20160901164939.GD6479-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-01 17:22           ` Knut Omang
     [not found]             ` <1472750558.9410.230.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-01 17:36               ` Jason Gunthorpe
2016-09-01 18:05               ` Jason Gunthorpe
     [not found]                 ` <20160901180512.GB20098-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-01 18:23                   ` Knut Omang
     [not found]                     ` <1472754220.9410.236.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-02  2:06                       ` Jason Gunthorpe
     [not found]                         ` <20160902020642.GA30057-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-02  7:49                           ` Knut Omang
     [not found]                             ` <1472802582.3975.16.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-03  7:30                               ` Knut Omang
     [not found]                                 ` <1472887840.9410.364.camel-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-05  2:38                                   ` Jason Gunthorpe
     [not found]                                     ` <20160905023817.GD21542-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-05  4:56                                       ` Knut Omang
2016-09-01  6:59   ` [PATCH libibverbs 2/3] Add padding to get proper end alignment of ibv_reg_mr_resp Knut Omang
     [not found]     ` <1472713193-22397-3-git-send-email-knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-01  8:56       ` Yishai Hadas
     [not found]         ` <6ce4a2f9-64ee-29af-72e8-1c8844436a20-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-09-01  9:07           ` Knut Omang
2016-09-01 16:42       ` Jason Gunthorpe
     [not found]         ` <20160901164216.GB6479-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-01 17:17           ` Knut Omang
2016-09-01  6:59   ` [PATCH libibverbs 3/3] Provide remote XRC SRQ number in kernel post_send Knut Omang
     [not found]     ` <1472713193-22397-4-git-send-email-knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-01  9:00       ` Yishai Hadas
     [not found]         ` <67f23338-1a5c-5080-d346-8441afb47670-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-09-05 15:50           ` Knut Omang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472713193-22397-1-git-send-email-knut.omang@oracle.com \
    --to=knut.omang-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mukesh.kacker-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.