All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [PATCH v2 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards
Date: Thu,  1 Sep 2016 11:06:50 +0200	[thread overview]
Message-ID: <1472720817-20362-2-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1472720817-20362-1-git-send-email-javier@osg.samsung.com>

The skeleton.dtsi file was removed in ARM64 for different reasons as
explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").

These also applies to ARM and it will also allow to get rid of the
following DTC warnings in the future:

"Node /memory has a reg or ranges property, but no unit name"

But these boards don't have a memory node defined, so removing the
skeleton.dtsi inclusion in exynos5440.dtsi will cause a change in
the compiled DTB. Add a dummy memory node so the compiled DTB does
not change if the skeleton.dtsi is removed from exynos5440.dtsi.

Eventually the correct starting addresses and sizes should be used
but I didn't find that information.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

Changes in v2:
- Add a fixme to specify that the correct memory values should be set.
  (Bartlomiej Zolnierkiewicz)
- Fix commit message (Krzysztof Kozlowski).

 arch/arm/boot/dts/exynos5440-sd5v1.dts    | 6 ++++++
 arch/arm/boot/dts/exynos5440-ssdk5440.dts | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
index a98501bab6fc..afd21a41e05b 100644
--- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
+++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
@@ -20,6 +20,12 @@
 		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
 	};
 
+	/* FIXME: set reg property with correct start address and size */
+	memory {
+		device_type = "memory";
+		reg = <0 0>;
+	};
+
 	fixed-rate-clocks {
 		xtal {
 			compatible = "samsung,clock-xtal";
diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
index 6a0d802e87c8..bdb3bf622e2f 100644
--- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
+++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
@@ -21,6 +21,12 @@
 		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
 	};
 
+	/* FIXME: set reg property with correct start address and size */
+	memory {
+		device_type = "memory";
+		reg = <0 0>;
+	};
+
 	fixed-rate-clocks {
 		xtal {
 			compatible = "samsung,clock-xtal";
-- 
2.7.4

  reply	other threads:[~2016-09-01  9:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01  9:06 [PATCH v2 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Javier Martinez Canillas
2016-09-01  9:06 ` Javier Martinez Canillas [this message]
2016-09-01 16:26   ` [PATCH v2 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Krzysztof Kozlowski
2016-09-01 16:26     ` Krzysztof Kozlowski
2016-09-01  9:06 ` [PATCH v2 2/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos3 Javier Martinez Canillas
2016-09-01 16:26   ` Krzysztof Kozlowski
2016-09-01 16:26     ` Krzysztof Kozlowski
2016-09-01  9:06 ` [PATCH v2 3/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos4 Javier Martinez Canillas
2016-09-01  9:06   ` Javier Martinez Canillas
2016-09-01 16:28   ` Krzysztof Kozlowski
2016-09-01 16:28     ` Krzysztof Kozlowski
2016-09-01  9:06 ` [PATCH v2 4/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos5 Javier Martinez Canillas
2016-09-01 16:31   ` Krzysztof Kozlowski
2016-09-01 16:31     ` Krzysztof Kozlowski
2016-09-01  9:06 ` [PATCH v2 5/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos3 DTS Javier Martinez Canillas
2016-09-01 16:31   ` Krzysztof Kozlowski
2016-09-01  9:06 ` [PATCH v2 6/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos4 DTS Javier Martinez Canillas
2016-09-01 16:31   ` Krzysztof Kozlowski
2016-09-01  9:06 ` [PATCH v2 7/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos5 DTS Javier Martinez Canillas
2016-09-01 16:32   ` Krzysztof Kozlowski
2016-09-01 16:32     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472720817-20362-2-git-send-email-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.