From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934650AbcIAQnl (ORCPT ); Thu, 1 Sep 2016 12:43:41 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36660 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932533AbcIAQnj (ORCPT ); Thu, 1 Sep 2016 12:43:39 -0400 Message-ID: <1472748216.5019.46.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg From: Eric Dumazet To: robert.foss@collabora.com Cc: freddy@asix.com.tw, Dean_Jenkins@mentor.com, Mark_Craske@mentor.com, davem@davemloft.net, ivecera@redhat.com, john.stultz@linaro.org, vpalatin@chromium.org, stephen@networkplumber.org, grundler@chromium.org, changchias@gmail.com, allan@asix.com.tw, andrew@lunn.ch, tremyfr@gmail.com, colin.king@canonical.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vpalatin@google.com, Grant Grundler Date: Thu, 01 Sep 2016 09:43:36 -0700 In-Reply-To: <9d5c5525f369f1c4098bda989d73886d11036bae.1472155176.git-series.robert.foss@collabora.com> References: <9d5c5525f369f1c4098bda989d73886d11036bae.1472155176.git-series.robert.foss@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-08-29 at 09:32 -0400, robert.foss@collabora.com wrote: > From: Robert Foss > > From: Grant Grundler > > The miii_nway_restart() causes a PHY link change activity and > ax88772_link_reset will be called. link_reset will set > AX_CMD_WRITE_MEDIUM_MODE register correctly. > > The asix_write_medium_mode in reset() fills in a default value to the register > which may be different from the negotiation result. So do this first. > > Ignore the ret value since it's ignored in XXX_link_reset() functions. > > Signed-off-by: Grant Grundler > Signed-off-by: Robert Foss > Tested-by: Robert Foss > --- This is _really_ confusing Robert. Why having two 'From:' clauses ? Who wrote the patch in the first place ? You or Grant ? End result is : commit 535baf8588d04b177cb33700f81499f2b5203c2d Author: Robert Foss Date: Mon Aug 29 09:32:19 2016 -0400 net: asix: autoneg will set WRITE_MEDIUM reg From: Grant Grundler The miii_nway_restart() causes a PHY link change activity and ax88772_link_reset will be called. link_reset will set AX_CMD_WRITE_MEDIUM_MODE register correctly. The asix_write_medium_mode in reset() fills in a default value to the register which may be different from the negotiation result. So do this first. Ignore the ret value since it's ignored in XXX_link_reset() functions. Signed-off-by: Grant Grundler Signed-off-by: Robert Foss Tested-by: Robert Foss Signed-off-by: David S. Miller I guess Grant wrote the patch, but attribution is wrong.