All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Griffin <peter.griffin@linaro.org>
To: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@stlinux.com,
	vinod.koul@intel.com, patrice.chotard@st.com,
	dan.j.williams@intel.com, airlied@linux.ie, kraxel@redhat.com,
	ohad@wizery.com, bjorn.andersson@linaro.org
Cc: peter.griffin@linaro.org, lee.jones@linaro.org,
	dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-remoteproc@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: [PATCH v9 17/19] drm/virtio: kconfig: Fix recursive dependency issue.
Date: Mon,  5 Sep 2016 14:16:59 +0100	[thread overview]
Message-ID: <1473081421-16555-18-git-send-email-peter.griffin@linaro.org> (raw)
In-Reply-To: <1473081421-16555-1-git-send-email-peter.griffin@linaro.org>

ST_SLIM_REMOTEPROC must select REMOTEPROC, which exposes the following
recursive dependency.

[..]
drivers/video/fbdev/Kconfig:5:error: recursive dependency detected!
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/Kconfig:42:	symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/Kconfig:36:	symbol DRM_KMS_HELPER is selected by DRM_VIRTIO_GPU
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/virtio/Kconfig:1:	symbol DRM_VIRTIO_GPU depends on VIRTIO
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/virtio/Kconfig:1:	symbol VIRTIO is selected by REMOTEPROC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/remoteproc/Kconfig:4:	symbol REMOTEPROC is selected by ST_SLIM_REMOTEPROC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/remoteproc/Kconfig:103:	symbol ST_SLIM_REMOTEPROC is selected by ST_FDMA
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/dma/Kconfig:440:	symbol ST_FDMA depends on DMADEVICES
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/dma/Kconfig:5:	symbol DMADEVICES is selected by SND_SOC_SH4_SIU
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
sound/soc/sh/Kconfig:29:	symbol SND_SOC_SH4_SIU is selected by SND_SIU_MIGOR
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
sound/soc/sh/Kconfig:64:	symbol SND_SIU_MIGOR depends on I2C
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/i2c/Kconfig:7:	symbol I2C is selected by FB_DDC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:63:	symbol FB_DDC is selected by FB_CYBER2000_DDC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:378:	symbol FB_CYBER2000_DDC depends on FB_CYBER2000
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:366:	symbol FB_CYBER2000 depends on FB

which is due to drivers/gpu/drm/virtio/Kconfig depending on VIRTIO.

Fix by dropping depend and switching to select VIRTIO.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 drivers/gpu/drm/virtio/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/virtio/Kconfig b/drivers/gpu/drm/virtio/Kconfig
index e1afc3d..90357d9 100644
--- a/drivers/gpu/drm/virtio/Kconfig
+++ b/drivers/gpu/drm/virtio/Kconfig
@@ -1,6 +1,7 @@
 config DRM_VIRTIO_GPU
 	tristate "Virtio GPU driver"
-	depends on DRM && VIRTIO
+	depends on DRM
+	select VIRTIO
         select DRM_KMS_HELPER
         select DRM_TTM
 	help
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: peter.griffin@linaro.org (Peter Griffin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 17/19] drm/virtio: kconfig: Fix recursive dependency issue.
Date: Mon,  5 Sep 2016 14:16:59 +0100	[thread overview]
Message-ID: <1473081421-16555-18-git-send-email-peter.griffin@linaro.org> (raw)
In-Reply-To: <1473081421-16555-1-git-send-email-peter.griffin@linaro.org>

ST_SLIM_REMOTEPROC must select REMOTEPROC, which exposes the following
recursive dependency.

[..]
drivers/video/fbdev/Kconfig:5:error: recursive dependency detected!
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/Kconfig:42:	symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/Kconfig:36:	symbol DRM_KMS_HELPER is selected by DRM_VIRTIO_GPU
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpu/drm/virtio/Kconfig:1:	symbol DRM_VIRTIO_GPU depends on VIRTIO
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/virtio/Kconfig:1:	symbol VIRTIO is selected by REMOTEPROC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/remoteproc/Kconfig:4:	symbol REMOTEPROC is selected by ST_SLIM_REMOTEPROC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/remoteproc/Kconfig:103:	symbol ST_SLIM_REMOTEPROC is selected by ST_FDMA
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/dma/Kconfig:440:	symbol ST_FDMA depends on DMADEVICES
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/dma/Kconfig:5:	symbol DMADEVICES is selected by SND_SOC_SH4_SIU
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
sound/soc/sh/Kconfig:29:	symbol SND_SOC_SH4_SIU is selected by SND_SIU_MIGOR
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
sound/soc/sh/Kconfig:64:	symbol SND_SIU_MIGOR depends on I2C
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/i2c/Kconfig:7:	symbol I2C is selected by FB_DDC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:63:	symbol FB_DDC is selected by FB_CYBER2000_DDC
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:378:	symbol FB_CYBER2000_DDC depends on FB_CYBER2000
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/video/fbdev/Kconfig:366:	symbol FB_CYBER2000 depends on FB

which is due to drivers/gpu/drm/virtio/Kconfig depending on VIRTIO.

Fix by dropping depend and switching to select VIRTIO.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 drivers/gpu/drm/virtio/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/virtio/Kconfig b/drivers/gpu/drm/virtio/Kconfig
index e1afc3d..90357d9 100644
--- a/drivers/gpu/drm/virtio/Kconfig
+++ b/drivers/gpu/drm/virtio/Kconfig
@@ -1,6 +1,7 @@
 config DRM_VIRTIO_GPU
 	tristate "Virtio GPU driver"
-	depends on DRM && VIRTIO
+	depends on DRM
+	select VIRTIO
         select DRM_KMS_HELPER
         select DRM_TTM
 	help
-- 
1.9.1

  parent reply	other threads:[~2016-09-05 13:16 UTC|newest]

Thread overview: 174+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 13:16 [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets Peter Griffin
2016-09-05 13:16 ` Peter Griffin
2016-09-05 13:16 ` Peter Griffin
2016-09-05 13:16 ` [PATCH v9 01/19] remoteproc: st_slim_rproc: add a slimcore rproc driver Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-13 17:56   ` Bjorn Andersson
2016-09-13 17:56     ` Bjorn Andersson
2016-09-13 17:56     ` Bjorn Andersson
2016-09-14  8:30     ` Lee Jones
2016-09-14  8:30     ` Lee Jones
2016-09-14  8:30       ` Lee Jones
2016-09-14  8:30       ` Lee Jones
2016-09-05 13:16 ` [PATCH v9 02/19] MAINTAINERS: Add st slim core rproc driver to STi section Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16 ` [PATCH v9 03/19] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16 ` [PATCH v9 04/19] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16 ` [PATCH v9 05/19] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16 ` [PATCH v9 06/19] ARM: STi: DT: STiH407: Add FDMA driver dt nodes Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-14 11:59   ` Patrice Chotard
2016-09-14 11:59     ` Patrice Chotard
2016-09-14 11:59     ` Patrice Chotard
2016-09-14 11:59     ` Patrice Chotard
2016-09-14 11:59   ` Patrice Chotard
2016-09-05 13:16 ` [PATCH v9 07/19] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16 ` [PATCH v9 08/19] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin
2016-09-05 13:16 ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16 ` [PATCH v9 09/19] ARM: multi_v7_defconfig: Enable STi and simple-card drivers Peter Griffin
2016-09-05 13:16 ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16 ` [PATCH v9 10/19] ARM: DT: STiH407: Add i2s_out pinctrl configuration Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-14 12:00   ` Patrice Chotard
2016-09-14 12:00   ` Patrice Chotard
2016-09-14 12:00     ` Patrice Chotard
2016-09-14 12:00     ` Patrice Chotard
2016-09-05 13:16 ` [PATCH v9 11/19] ARM: DT: STiH407: Add i2s_in " Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-14 12:00   ` Patrice Chotard
2016-09-14 12:00   ` Patrice Chotard
2016-09-14 12:00     ` Patrice Chotard
2016-09-14 12:00     ` Patrice Chotard
2016-09-14 12:00     ` Patrice Chotard
2016-09-05 13:16 ` [PATCH v9 12/19] ARM: DT: STiH407: Add spdif_out pinctrl config Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-14 12:00   ` Patrice Chotard
2016-09-14 12:00     ` Patrice Chotard
2016-09-14 12:00     ` Patrice Chotard
2016-09-14 12:00   ` Patrice Chotard
2016-09-05 13:16 ` Peter Griffin
2016-09-05 13:16 ` [PATCH v9 13/19] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node Peter Griffin
2016-09-05 13:16 ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-14 12:01   ` Patrice Chotard
2016-09-14 12:01   ` Patrice Chotard
2016-09-14 12:01     ` Patrice Chotard
2016-09-14 12:01     ` Patrice Chotard
2016-09-05 13:16 ` [PATCH v9 14/19] ARM: STi: DT: STiH407: Add uniperif player dt nodes Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-14 12:01   ` Patrice Chotard
2016-09-14 12:01   ` Patrice Chotard
2016-09-14 12:01     ` Patrice Chotard
2016-09-14 12:01     ` Patrice Chotard
2016-09-05 13:16 ` [PATCH v9 15/19] ARM: STi: DT: STiH407: Add uniperif reader " Peter Griffin
2016-09-05 13:16 ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-14 12:01   ` Patrice Chotard
2016-09-14 12:01   ` Patrice Chotard
2016-09-14 12:01     ` Patrice Chotard
2016-09-14 12:01     ` Patrice Chotard
2016-09-05 13:16 ` [PATCH v9 16/19] ARM: DT: STi: stihxxx-b2120: Add DT nodes for STi audio card Peter Griffin
2016-09-05 13:16   ` Peter Griffin
2016-09-14 12:01   ` Patrice Chotard
2016-09-14 12:01     ` Patrice Chotard
2016-09-14 12:01     ` Patrice Chotard
2016-09-14 12:01   ` Patrice Chotard
2016-09-05 13:16 ` Peter Griffin
2016-09-05 13:16 ` [PATCH v9 17/19] drm/virtio: kconfig: Fix recursive dependency issue Peter Griffin
2016-09-05 13:16 ` Peter Griffin [this message]
2016-09-05 13:16   ` Peter Griffin
2016-09-19 23:18   ` Emil Velikov
2016-09-19 23:18     ` Emil Velikov
2016-09-19 23:18     ` Emil Velikov
2016-09-19 23:18     ` Emil Velikov
2016-09-19 23:18     ` Emil Velikov
2016-09-20  8:32     ` Peter Griffin
2016-09-20  8:32       ` Peter Griffin
2016-09-20  8:32       ` Peter Griffin
2016-09-20  8:32       ` Peter Griffin
2016-09-20  9:33       ` Jani Nikula
2016-09-20  9:33       ` Jani Nikula
2016-09-20  9:33         ` Jani Nikula
2016-09-20  9:33         ` Jani Nikula
2016-09-20  9:33         ` Jani Nikula
2016-10-06  9:37         ` Peter Griffin
2016-10-06  9:37           ` Peter Griffin
2016-10-06  9:37           ` Peter Griffin
2016-10-06  9:37           ` Peter Griffin
2016-10-06 10:45           ` Emil Velikov
2016-10-06 10:45           ` Emil Velikov
2016-10-06 10:45             ` Emil Velikov
2016-10-06 10:45             ` Emil Velikov
2016-10-06 10:45             ` Emil Velikov
2016-10-07 17:44             ` Peter Griffin
2016-10-07 17:44               ` Peter Griffin
2016-10-07 17:44               ` Peter Griffin
2016-10-07 17:44               ` Peter Griffin
2016-09-21 12:09       ` Emil Velikov
2016-09-21 12:09       ` Emil Velikov
2016-09-21 12:09         ` Emil Velikov
2016-09-21 12:09         ` Emil Velikov
2016-09-27 17:01         ` Bjorn Andersson
2016-09-27 17:01           ` Bjorn Andersson
2016-09-27 17:01           ` Bjorn Andersson
2016-09-27 17:01           ` Bjorn Andersson
2016-10-06 10:10           ` Emil Velikov
2016-10-06 10:10           ` Emil Velikov
2016-10-06 10:10             ` Emil Velikov
2016-10-06 10:10             ` Emil Velikov
2016-10-06 10:48         ` Peter Griffin
2016-10-06 10:48           ` Peter Griffin
2016-10-06 10:48           ` Peter Griffin
2016-10-06 10:48           ` Peter Griffin
2016-10-06 11:31           ` Emil Velikov
2016-10-06 11:31             ` Emil Velikov
2016-10-06 11:31             ` Emil Velikov
2016-10-06 11:31           ` Emil Velikov
2016-09-05 13:17 ` [PATCH v9 18/19] drm/virtio: kconfig: Fixup white space Peter Griffin
2016-09-05 13:17   ` Peter Griffin
2016-09-05 13:17 ` Peter Griffin
2016-09-05 13:17 ` [PATCH v9 19/19] dmaengine: kconfig: Remove superfluous '\n' Peter Griffin
2016-09-05 13:17   ` Peter Griffin
2016-09-05 13:17   ` Peter Griffin
2016-09-05 13:17 ` Peter Griffin
2016-09-13  9:31 ` [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets Peter Griffin
2016-09-13  9:31 ` Peter Griffin
2016-09-13  9:31   ` Peter Griffin
2016-09-13  9:31   ` Peter Griffin
2016-09-13 18:06   ` Bjorn Andersson
2016-09-13 18:06   ` Bjorn Andersson
2016-09-13 18:06     ` Bjorn Andersson
2016-09-13 18:06     ` Bjorn Andersson
2016-09-14  6:59     ` Patrice Chotard
2016-09-14  6:59       ` Patrice Chotard
2016-09-14  6:59       ` Patrice Chotard
2016-09-14  6:59       ` Patrice Chotard
2016-09-14  6:59     ` Patrice Chotard
2016-09-14 13:07     ` Vinod Koul
2016-09-14 13:07       ` Vinod Koul
2016-09-14 13:07       ` Vinod Koul
2016-09-15 16:20       ` Vinod Koul
2016-09-15 16:20       ` Vinod Koul
2016-09-15 16:20         ` Vinod Koul
2016-09-15 16:20         ` Vinod Koul
2016-09-14 13:07     ` Vinod Koul
2016-09-19  9:34 [PATCH 0/2] Fix recursive Kconfig depedency issue Peter Griffin
2016-09-19  9:34 ` [PATCH 1/2] drm/virtio: kconfig: Fix recursive dependency issue Peter Griffin
2016-09-20  7:20   ` [PATCH v9 17/19] " Emil Velikov
2016-09-20  7:24     ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473081421-16555-18-git-send-email-peter.griffin@linaro.org \
    --to=peter.griffin@linaro.org \
    --cc=airlied@linux.ie \
    --cc=bjorn.andersson@linaro.org \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@stlinux.com \
    --cc=kraxel@redhat.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=patrice.chotard@st.com \
    --cc=vinod.koul@intel.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.