All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
To: stgt@vger.kernel.org
Cc: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>,
	Teruaki Ishizaki <ishizaki.teruaki@lab.ntt.co.jp>,
	Takashi Menjo <menjo.takashi@lab.ntt.co.jp>
Subject: [PATCH 4/6] sheepdog: handle a case of snapshot -> failover
Date: Tue,  6 Sep 2016 16:37:27 +0900	[thread overview]
Message-ID: <1473147449-29377-5-git-send-email-mitake.hitoshi@lab.ntt.co.jp> (raw)
In-Reply-To: <1473147449-29377-1-git-send-email-mitake.hitoshi@lab.ntt.co.jp>

If refreshed inode is snapshot, we can reload entire inode and switch
to working VDI immediately.

Cc: Teruaki Ishizaki <ishizaki.teruaki@lab.ntt.co.jp>
Cc: Takashi Menjo <menjo.takashi@lab.ntt.co.jp>
Tested-by: Takashi Menjo <menjo.takashi@lab.ntt.co.jp>
Signed-off-by: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
---
 usr/bs_sheepdog.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/usr/bs_sheepdog.c b/usr/bs_sheepdog.c
index ecb5033..8f228b5 100644
--- a/usr/bs_sheepdog.c
+++ b/usr/bs_sheepdog.c
@@ -704,6 +704,34 @@ static int reload_inode(struct sheepdog_access_info *ai, int is_snapshot)
 			ret = -1;
 			goto ret;
 		}
+
+		if (!!ai->inode.snap_ctime) {
+			/*
+			 * This is a case like below:
+			 * take snapshot -> write something -> failover
+			 *
+			 * Because invalidated inode is readonly and latest
+			 * working VDI can have COWed objects, we need to
+			 * resolve VID and reload its entire inode object.
+			 */
+			memset(tag, 0, sizeof(tag));
+
+			ret = find_vdi_name(ai, ai->inode.name, CURRENT_VDI_ID,
+					    tag, &vid, 0);
+			if (ret) {
+				ret = -1;
+				goto ret;
+			}
+
+			ret = read_object(ai, (char *)&ai->inode,
+					  vid_to_vdi_oid(vid),
+					  ai->inode.nr_copies, SD_INODE_SIZE, 0,
+					  &need_reload);
+			if (ret) {
+				ret = -1;
+				goto ret;
+			}
+		}
 	}
 
 	ai->min_dirty_data_idx = UINT32_MAX;
-- 
2.7.4

  parent reply	other threads:[~2016-09-06  7:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06  7:37 [PATCH 0/6] sheepdog driver cleanup Hitoshi Mitake
2016-09-06  7:37 ` [PATCH 1/6] sheepdog: prevent double locking during inode reload Hitoshi Mitake
2016-09-06  7:37 ` [PATCH 2/6] sheepdog: serialize overwrapping request Hitoshi Mitake
2016-09-06  7:37 ` [PATCH 3/6] sheepdog: pass a correct flag to reload_inode() Hitoshi Mitake
2016-09-06  7:37 ` Hitoshi Mitake [this message]
2016-09-06  7:37 ` [PATCH 5/6] sheepdog: don't let ai have min and max dirty data indexes Hitoshi Mitake
2016-09-06  7:37 ` [PATCH 6/6] sheepdog: handle an inconsistent state of metadata Hitoshi Mitake
2016-09-07  0:24 ` [PATCH 0/6] sheepdog driver cleanup FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473147449-29377-5-git-send-email-mitake.hitoshi@lab.ntt.co.jp \
    --to=mitake.hitoshi@lab.ntt.co.jp \
    --cc=ishizaki.teruaki@lab.ntt.co.jp \
    --cc=menjo.takashi@lab.ntt.co.jp \
    --cc=stgt@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.