All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: devel@driverdev.osuosl.org
Cc: Luca Ceresoli <luca@lucaceresoli.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Geliang Tang <geliangtang@163.com>,
	Jakub Sitnicki <jsitnicki@gmail.com>,
	Ivan Safonov <insafonov@gmail.com>,
	Kyle Kuffermann <kyle.kuffermann@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 3/6] staging: rtl8188eu: declare internal function as static
Date: Tue,  6 Sep 2016 18:36:54 +0200	[thread overview]
Message-ID: <1473179817-7277-3-git-send-email-luca@lucaceresoli.net> (raw)
In-Reply-To: <1473179817-7277-1-git-send-email-luca@lucaceresoli.net>

This function is only used inside rtw_recv.c. Which is quite logical,
since it's a timer callback: it is passed as the _fn argument to
setup_timer(). So it is internal to rtw_recv.c and should be static.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Geliang Tang <geliangtang@163.com>
Cc: Jakub Sitnicki <jsitnicki@gmail.com>
Cc: Ivan Safonov <insafonov@gmail.com>
Cc: Kyle Kuffermann <kyle.kuffermann@gmail.com>
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org

---

Changes v2 -> v3:
- add "staging: " prefix to commit message title.

Changes v1 -> v2:
- improve the commit message.
---
 drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 977bb25..1063617 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -39,7 +39,7 @@ static u8 rtw_rfc1042_header[] = {
        0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
 };
 
-void rtw_signal_stat_timer_hdl(unsigned long data);
+static void rtw_signal_stat_timer_hdl(unsigned long data);
 
 void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
 {
@@ -2088,7 +2088,7 @@ _recv_entry_drop:
 	return ret;
 }
 
-void rtw_signal_stat_timer_hdl(unsigned long data)
+static void rtw_signal_stat_timer_hdl(unsigned long data)
 {
 	struct adapter *adapter = (struct adapter *)data;
 	struct recv_priv *recvpriv = &adapter->recvpriv;
-- 
2.7.4

  parent reply	other threads:[~2016-09-06 16:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06 16:36 [PATCH v3 1/6] staging: rtl8723au: remove unimplemented functions declaration Luca Ceresoli
2016-09-06 16:36 ` [PATCH v3 2/6] staging: rtl8188eu: " Luca Ceresoli
2016-09-06 16:36 ` Luca Ceresoli [this message]
2016-09-06 16:36 ` [PATCH v3 4/6] staging: rtl8188eu: remove rtw_proc_{init,remove}_one Luca Ceresoli
2016-09-06 16:36 ` [PATCH v3 5/6] staging: rtl8188eu: remove useless include Luca Ceresoli
2016-09-06 16:36 ` [PATCH v3 6/6] staging: rtl8188eu: remove unused debugging functions Luca Ceresoli
2016-09-12  8:14 ` [PATCH v3 1/6] staging: rtl8723au: remove unimplemented functions declaration Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473179817-7277-3-git-send-email-luca@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bhaktipriya96@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=geliangtang@163.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=insafonov@gmail.com \
    --cc=jsitnicki@gmail.com \
    --cc=kyle.kuffermann@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.