From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756300AbcIGCNX (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 22:13:23 -0400
Received: from smtprelay0028.hostedemail.com ([216.40.44.28]:42401 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1755437AbcIGCNV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 22:13:21 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1042:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2687:2740:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3871:3872:3873:4250:4321:5007:7903:10004:10400:10848:11026:11232:11473:11658:11914:12048:12740:13019:13069:13311:13357:13439:13894:13972:14181:14659:14721:21080:30012:30029:30054:30070:30083:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none
X-HE-Tag: thing59_39adf2611a403
X-Filterd-Recvd-Size: 2457
Message-ID: <1473214394.29864.4.camel@perches.com>
Subject: Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros
From: Joe Perches <joe@perches.com>
To: Ronnie.Kunin@microchip.com, Woojung.Huh@microchip.com,
        netdev@vger.kernel.org, linux-usb@vger.kernel.org
Cc: f.fainelli@gmail.com, UNGLinuxDriver@microchip.com,
        linux-kernel@vger.kernel.org
Date: Tue, 06 Sep 2016 19:13:14 -0700
In-Reply-To: <CB1A8EE47AAD7B4897132E685E5108C551F87491@CHN-SV-EXMX02.mchp-main.com>
References: <cover.1473202982.git.joe@perches.com>
         <9235D6609DB808459E95D78E17F2E43D40910FF9@CHN-SV-EXMX02.mchp-main.com>
        ,<1473211122.29864.1.camel@perches.com>
         <CB1A8EE47AAD7B4897132E685E5108C551F87491@CHN-SV-EXMX02.mchp-main.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.21.91-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-09-07 at 02:00 +0000, Ronnie.Kunin@microchip.com wrote:
> Microchip's internal convention is for register (offset) definitions
> to be capitalized (i.e.: MY_REGISTER). Our convention for bits
> (position) definitions within a register is to carry as a prefix the
> name of the register and suffix it with the bit name and adding a
> trailing underscore (i.e. MY_REGISTER_MY_BIT_). The trailing
> underscore is what easily lets us distinguish a bit from a register
> definition when reading code. We have been using this convention for
> many years and has worked very well for us across all projects (by now
> hundreds).

I think it's kind of an ugly convention, but <shrug> no
skin off my nose really.

> > Is there anything other than a one-time cost
> > to apply these?  Is the same code used for
> > other platforms?
> 
> Yes, a single header file with the definition of registers and bits is
> shared (either as a standalone file or with its contents pasted into a
> native environment "carrier" header file) across all drivers (and
> other non driver software projects as well) for the same device. So a
> change like this indeed has a high cost for Microchip and we'd rather
> not do this unless it is an absolutely mandated requirement. 

No worries, if you don't like it, don't apply it.

Send a NAK too so David Miller doesn't apply it either.