From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Francis Y. Yan" <francisyyan@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
soheil@google.com, ncardwell@google.com,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH net-next 2/2] tcp: put a TLV list of TCP stats in error queue
Date: Wed, 07 Sep 2016 07:22:37 -0700 [thread overview]
Message-ID: <1473258157.10725.28.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <1473211961-107223-2-git-send-email-francisyyan@gmail.com>
On Tue, 2016-09-06 at 18:32 -0700, Francis Y. Yan wrote:
> To export useful TCP statistics along with timestamps, such as
> rwnd-limited time and min RTT, we enqueue a TLV list in error queue
> immediately when a timestamp is generated.
>
> Specifically, if user space requests SOF_TIMESTAMPING_TX_* timestamps
> and sets SOF_TIMESTAMPING_OPT_STATS, the kernel will create a list of
> TLVs (struct nlattr) containing all the statistics and store the list
> in payload of the skb that is going to be enqueued into error queue.
> Notice that SOF_TIMESTAMPING_OPT_STATS can only be set together with
> SOF_TIMESTAMPING_OPT_TSONLY.
>
> In addition, if the application in user space also enables receiving
> timestamp (e.g. by SOF_TIMESTAMPING_SOFTWARE), calling recvfrom() on
> error queue will return one more control message with a cmsg_type of
> SCM_OPT_STATS containing the list of TLVs in its cmsg_data.
>
> Signed-off-by: Francis Y. Yan <francisyyan@gmail.com>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> ---
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2016-09-07 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 1:32 [PATCH net-next 1/2] tcp: measure rwnd-limited time Francis Y. Yan
2016-09-07 1:32 ` [PATCH net-next 2/2] tcp: put a TLV list of TCP stats in error queue Francis Y. Yan
2016-09-07 5:04 ` Soheil Hassas Yeganeh
2016-09-07 14:22 ` Eric Dumazet [this message]
2016-09-07 5:07 ` [PATCH net-next 1/2] tcp: measure rwnd-limited time Soheil Hassas Yeganeh
2016-09-07 14:19 ` Eric Dumazet
2016-09-08 0:27 ` David Miller
2016-09-08 15:31 ` Yuchung Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473258157.10725.28.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=francisyyan@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.