From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934903AbcIHLhq (ORCPT ); Thu, 8 Sep 2016 07:37:46 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33147 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933793AbcIHLhp (ORCPT ); Thu, 8 Sep 2016 07:37:45 -0400 From: Baoyou Xie To: gregkh@linuxfoundation.org, wsa@the-dreams.de Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] staging: ks7010: mark symbols static where possible Date: Thu, 8 Sep 2016 19:37:24 +0800 Message-Id: <1473334644-26133-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 3 warnings when building kernel with W=1: drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes] drivers/staging/ks7010/ks7010_sdio.c:121:6: warning: no previous prototype for 'ks_wlan_hw_sleep_wakeup_request' [-Wmissing-prototypes] drivers/staging/ks7010/ks7010_sdio.c:174:5: warning: no previous prototype for '_ks_wlan_hw_power_save' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/staging/ks7010/ks7010_sdio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index b7337fd..466ba07 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -87,7 +87,7 @@ static int ks7010_sdio_write(struct ks_wlan_private *priv, unsigned int address, return rc; } -void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv) +static void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv) { unsigned char rw_data; int retval; @@ -118,7 +118,7 @@ void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv) return; } -void ks_wlan_hw_sleep_wakeup_request(struct ks_wlan_private *priv) +static void ks_wlan_hw_sleep_wakeup_request(struct ks_wlan_private *priv) { unsigned char rw_data; int retval; @@ -171,7 +171,7 @@ void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv) } } -int _ks_wlan_hw_power_save(struct ks_wlan_private *priv) +static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv) { int rc = 0; unsigned char rw_data; -- 2.7.4