All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	daniel@iogearbox.net, xiyou.wangcong@gmail.com,
	John Fastabend <john.r.fastabend@intel.com>
Subject: Re: [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action
Date: Thu, 08 Sep 2016 09:11:17 -0700	[thread overview]
Message-ID: <1473351077.15733.63.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <1473350573.15733.61.camel@edumazet-glaptop3.roam.corp.google.com>

On Thu, 2016-09-08 at 09:02 -0700, Eric Dumazet wrote:
> On Thu, 2016-09-08 at 06:38 -0400, Jamal Hadi Salim wrote:
> > On 16-09-06 10:25 AM, Eric Dumazet wrote:
> > 
> > >
> > > Just use u16 in the array ?
> > >
> > > u16 tmpaddr[ETH_ALEN / 2]; /* ether_addr_copy() requirement */
> > >
> > > ether_addr_copy((u8 *)tmpaddr, eth_hdr(skb)->h_dest);
> > > ...
> > >
> > 
> > Ok - thanks Eric. BTW:
> > Nobody has answered my other question:
> > I can get stats to increment with:
> > bstats_update(&d->tcf_bstats, skb);
> > but not:
> > bstats_cpu_update(this_cpu_ptr(d->common.cpu_bstats), skb);
> 
> This simply works for me.
> 
> But maybe you read the stats at the wrong place ?
> 
> Pleas give us more details, thanks !

And double check the tcf_hash_create() call :

Last parameter is a boolean, and you must set it to true if you want per
cpu stats !

  reply	other threads:[~2016-09-08 16:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-28 12:19 [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action Jamal Hadi Salim
2016-08-28 14:48 ` Alexei Starovoitov
2016-08-29 10:35   ` Jamal Hadi Salim
2016-08-28 16:07 ` Eric Dumazet
2016-08-29  5:10   ` Cong Wang
2016-08-29 13:27     ` Eric Dumazet
2016-08-29 10:38   ` Jamal Hadi Salim
2016-08-29 11:00     ` Daniel Borkmann
2016-08-29 11:40       ` Jamal Hadi Salim
2016-08-29 11:55         ` Jamal Hadi Salim
2016-08-29 11:35     ` Jamal Hadi Salim
2016-08-29 18:20       ` Eric Dumazet
2016-08-30 11:12         ` Jamal Hadi Salim
2016-08-30 11:57           ` Jamal Hadi Salim
2016-08-30 12:35             ` Eric Dumazet
2016-09-06 12:03               ` Jamal Hadi Salim
2016-08-30 12:44             ` Eric Dumazet
2016-09-06 12:08               ` Jamal Hadi Salim
2016-09-06 14:25                 ` Eric Dumazet
2016-09-08 10:38                   ` Jamal Hadi Salim
2016-09-08 16:02                     ` Eric Dumazet
2016-09-08 16:11                       ` Eric Dumazet [this message]
2016-09-09 12:33                         ` Jamal Hadi Salim
2016-08-30 12:20           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473351077.15733.63.camel@edumazet-glaptop3.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.