All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL v2 02/14] virtio-pci: use size from correct structure
Date: Sat, 10 Sep 2016 00:47:24 +0300	[thread overview]
Message-ID: <1473456998-14863-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1473456998-14863-1-git-send-email-mst@redhat.com>

PIO MR registration should use size from the correct notify struct.
Doesn't affect any visible behaviour because the field values are the
same (both are 4).

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/virtio/virtio-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 755f921..268fd8e 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1520,7 +1520,7 @@ static void virtio_pci_modern_regions_init(VirtIOPCIProxy *proxy)
                           &notify_pio_ops,
                           virtio_bus_get_device(&proxy->bus),
                           "virtio-pci-notify-pio",
-                          proxy->notify.size);
+                          proxy->notify_pio.size);
 }
 
 static void virtio_pci_modern_region_map(VirtIOPCIProxy *proxy,
-- 
MST

  parent reply	other threads:[~2016-09-09 21:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 21:47 [Qemu-devel] [PULL v2 00/14] virtio,vhost,pc: fixes and updates Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 01/14] virtio: Tell the user what went wrong when event_notifier_init failed Michael S. Tsirkin
2016-09-09 21:47 ` Michael S. Tsirkin [this message]
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 03/14] pc: Add 2.8 machine Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 04/14] target-i386: present virtual L3 cache info for vcpus Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 05/14] virtio-pci: reduce modern_mem_bar size Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 06/14] virtio: zero vq->inuse in virtio_reset() Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 07/14] virtio-balloon: discard virtqueue element on reset Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 08/14] virtio: add virtqueue_rewind() Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 09/14] virtio-balloon: fix stats vq migration Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 10/14] virtio-pci: error out when both legacy and modern modes are disabled Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 11/14] vhost: don't set vring call if no vector Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 12/14] virtio-pci: minor refactoring Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 13/14] tests/acpi: speedup acpi tests Michael S. Tsirkin
2016-09-09 21:47 ` [Qemu-devel] [PULL v2 14/14] vhost-vsock: add virtio sockets device Michael S. Tsirkin
2016-09-12 11:48 ` [Qemu-devel] [PULL v2 00/14] virtio, vhost, pc: fixes and updates Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473456998-14863-3-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.