From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751066AbcIJSv6 (ORCPT ); Sat, 10 Sep 2016 14:51:58 -0400 Received: from smtprelay0198.hostedemail.com ([216.40.44.198]:57188 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751219AbcIJSv5 (ORCPT ); Sat, 10 Sep 2016 14:51:57 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:69:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3874:4321:4433:5007:6120:7264:8531:8957:10004:10400:10848:11232:11658:11914:12043:12683:12740:13069:13311:13357:13439:14095:14096:14659:21080:30054:30076:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: owner06_4af5dd1f64738 X-Filterd-Recvd-Size: 1784 Message-ID: <1473533513.19464.3.camel@perches.com> Subject: Re: [RFC v6 01/23] clocksource: sh_cmt: compute rate before registration again From: Joe Perches To: Thomas Gleixner , Nicolai Stange Cc: John Stultz , linux-kernel@vger.kernel.org Date: Sat, 10 Sep 2016 11:51:53 -0700 In-Reply-To: References: <20160909200033.32103-1-nicstange@gmail.com> <20160909200033.32103-2-nicstange@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-09-10 at 14:56 +0200, Thomas Gleixner wrote: > if (foo) > bar(foo->something, foo->somemore, foo->other, > CONST);) > else > rab(); > > > Is NOT. Simply because the pattern of a 'if ()' condition without braces > suggests a single line statement to follow. Then the reading flow stops > because there is more than one line. While: > if (foo) { > bar(foo->something, foo->somemore, foo->other, > CONST);) > } else { > rab(); > } While I mostly agree, CodingStyle says: ------------------------------------------------------ Do not unnecessarily use braces where a single statement will do. if (condition) action(); and if (condition) do_this(); else do_that(); ------------------------------------------------------ Perhaps that should be "with single line statements" instead. >