From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752063AbcIMFcb (ORCPT ); Tue, 13 Sep 2016 01:32:31 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:6494 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750734AbcIMFc2 (ORCPT ); Tue, 13 Sep 2016 01:32:28 -0400 Message-ID: <1473744743.28437.26.camel@mtksdaap41> Subject: Re: [PATCH v7 9/9] drm/mediatek: add support for Mediatek SoC MT2701 From: CK Hu To: YT Shen CC: , Philipp Zabel , David Airlie , Matthias Brugger , Daniel Kurtz , Mao Huang , Bibby Hsieh , "Daniel Vetter" , Thierry Reding , Jie Qiu , Maxime Ripard , Chris Wilson , shaoming chen , Jitao Shi , Boris Brezillon , Dan Carpenter , , , , , Sascha Hauer , , Date: Tue, 13 Sep 2016 13:32:23 +0800 In-Reply-To: <1473675413.12398.29.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-10-git-send-email-yt.shen@mediatek.com> <1473226653.11736.33.camel@mtksdaap41> <1473675413.12398.29.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, YT: On Mon, 2016-09-12 at 18:16 +0800, YT Shen wrote: > Hi CK, > > On Wed, 2016-09-07 at 13:37 +0800, CK Hu wrote: > > Hi, YT: > > > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > > This patch add support for the Mediatek MT2701 DISP subsystem. > > > There is only one OVL engine in MT2701. > > > > > > Signed-off-by: YT Shen > > > > [snip...] > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > index 4b4e449..465819b 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > @@ -112,6 +112,7 @@ struct mtk_ddp_comp_match { > > > > > > static const struct mtk_ddp_comp_match mtk_ddp_matches[DDP_COMPONENT_ID_MAX] = { > > > [DDP_COMPONENT_AAL] = { MTK_DISP_AAL, 0, NULL }, > > > + [DDP_COMPONENT_BLS] = { MTK_DISP_PWM, 0, NULL }, > > > > I think BLS is different than PWM, so this statement should be > > > > [DDP_COMPONENT_BLS] = { MTK_DISP_BLS, 0, NULL }; > The BLS module actually is a multifunction device, one of them is the > PWM function. We only upstream PWM function [1] now, and it is > accepted. When there are real use case (gamma function), we will update > this part. What do you think? I think BLS = PWM + GAMMA and the device with register range from 0x1400a000 to 0x1400afff should be called BLS. I think this device is called PWM in [1] because it just use its PWM function and it's not suitable. At least in DRM driver, we should use the term BLS rather than PWM. Maybe we should define as below: [DDP_COMPONENT_BLS] = { MTK_DISP_BLS, 0, NULL }; and { .compatible = "mediatek,mt2701-disp-pwm", .data = (void *)MTK_DISP_BLS }, Regards, CK [1] https://patchwork.kernel.org/patch/9223001/ > > Regards, > yt.shen > > [1] https://patchwork.kernel.org/patch/9223001/ > > > > > > > > [DDP_COMPONENT_COLOR0] = { MTK_DISP_COLOR, 0, &ddp_color }, > > > [DDP_COMPONENT_COLOR1] = { MTK_DISP_COLOR, 1, &ddp_color }, > > > [DDP_COMPONENT_DPI0] = { MTK_DPI, 0, NULL }, > > > > Regards, > > CK > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v7 9/9] drm/mediatek: add support for Mediatek SoC MT2701 Date: Tue, 13 Sep 2016 13:32:23 +0800 Message-ID: <1473744743.28437.26.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-10-git-send-email-yt.shen@mediatek.com> <1473226653.11736.33.camel@mtksdaap41> <1473675413.12398.29.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1473675413.12398.29.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: YT Shen Cc: Daniel Vetter , Jie Qiu , Mao Huang , yingjoe.chen@mediatek.com, Dan Carpenter , Jitao Shi , Sascha Hauer , linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Matthias Brugger , shaoming chen , linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, Maxime Ripard List-Id: linux-mediatek@lists.infradead.org SGksIFlUOgoKT24gTW9uLCAyMDE2LTA5LTEyIGF0IDE4OjE2ICswODAwLCBZVCBTaGVuIHdyb3Rl Ogo+IEhpIENLLAo+IAo+IE9uIFdlZCwgMjAxNi0wOS0wNyBhdCAxMzozNyArMDgwMCwgQ0sgSHUg d3JvdGU6Cj4gPiBIaSwgWVQ6Cj4gPiAKPiA+IE9uIEZyaSwgMjAxNi0wOS0wMiBhdCAxOToyNCAr MDgwMCwgWVQgU2hlbiB3cm90ZToKPiA+ID4gVGhpcyBwYXRjaCBhZGQgc3VwcG9ydCBmb3IgdGhl IE1lZGlhdGVrIE1UMjcwMSBESVNQIHN1YnN5c3RlbS4KPiA+ID4gVGhlcmUgaXMgb25seSBvbmUg T1ZMIGVuZ2luZSBpbiBNVDI3MDEuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBZVCBTaGVu IDx5dC5zaGVuQG1lZGlhdGVrLmNvbT4KPiA+IAo+ID4gW3NuaXAuLi5dCj4gPiAKPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMgYi9k cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jCj4gPiA+IGluZGV4IDRi NGU0NDkuLjQ2NTgxOWIgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRl ay9tdGtfZHJtX2RkcF9jb21wLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVr L210a19kcm1fZGRwX2NvbXAuYwo+ID4gPiBAQCAtMTEyLDYgKzExMiw3IEBAIHN0cnVjdCBtdGtf ZGRwX2NvbXBfbWF0Y2ggewo+ID4gPiAgCj4gPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG10a19k ZHBfY29tcF9tYXRjaCBtdGtfZGRwX21hdGNoZXNbRERQX0NPTVBPTkVOVF9JRF9NQVhdID0gewo+ ID4gPiAgCVtERFBfQ09NUE9ORU5UX0FBTF0JPSB7IE1US19ESVNQX0FBTCwJMCwgTlVMTCB9LAo+ ID4gPiArCVtERFBfQ09NUE9ORU5UX0JMU10JPSB7IE1US19ESVNQX1BXTSwJMCwgTlVMTCB9LAo+ ID4gCj4gPiBJIHRoaW5rIEJMUyBpcyBkaWZmZXJlbnQgdGhhbiBQV00sIHNvIHRoaXMgc3RhdGVt ZW50IHNob3VsZCBiZQo+ID4gCj4gPiBbRERQX0NPTVBPTkVOVF9CTFNdID0geyBNVEtfRElTUF9C TFMsIDAsIE5VTEwgfTsKPiBUaGUgQkxTIG1vZHVsZSBhY3R1YWxseSBpcyBhIG11bHRpZnVuY3Rp b24gZGV2aWNlLCBvbmUgb2YgdGhlbSBpcyB0aGUKPiBQV00gZnVuY3Rpb24uICBXZSBvbmx5IHVw c3RyZWFtIFBXTSBmdW5jdGlvbiBbMV0gbm93LCBhbmQgaXQgaXMKPiBhY2NlcHRlZC4gIFdoZW4g dGhlcmUgYXJlIHJlYWwgdXNlIGNhc2UgKGdhbW1hIGZ1bmN0aW9uKSwgd2Ugd2lsbCB1cGRhdGUK PiB0aGlzIHBhcnQuICBXaGF0IGRvIHlvdSB0aGluaz8KCkkgdGhpbmsgQkxTID0gUFdNICsgR0FN TUEgYW5kIHRoZSBkZXZpY2Ugd2l0aCByZWdpc3RlciByYW5nZSBmcm9tCjB4MTQwMGEwMDAgdG8g MHgxNDAwYWZmZiBzaG91bGQgYmUgY2FsbGVkIEJMUy4gSSB0aGluayB0aGlzIGRldmljZSBpcwpj YWxsZWQgUFdNIGluIFsxXSBiZWNhdXNlIGl0IGp1c3QgdXNlIGl0cyBQV00gZnVuY3Rpb24gYW5k IGl0J3Mgbm90CnN1aXRhYmxlLiBBdCBsZWFzdCBpbiBEUk0gZHJpdmVyLCB3ZSBzaG91bGQgdXNl IHRoZSB0ZXJtIEJMUyByYXRoZXIgdGhhbgpQV00uIE1heWJlIHdlIHNob3VsZCBkZWZpbmUgYXMg YmVsb3c6CgpbRERQX0NPTVBPTkVOVF9CTFNdID0geyBNVEtfRElTUF9CTFMsIDAsIE5VTEwgfTsK CmFuZAoKeyAuY29tcGF0aWJsZSA9ICJtZWRpYXRlayxtdDI3MDEtZGlzcC1wd20iLCAgIC5kYXRh ID0gKHZvaWQKKilNVEtfRElTUF9CTFMgfSwKCgpSZWdhcmRzLApDSwoKWzFdIGh0dHBzOi8vcGF0 Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTIyMzAwMS8KCj4gCj4gUmVnYXJkcywKPiB5dC5zaGVu Cj4gCj4gWzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTIyMzAwMS8KPiAK PiA+IAo+ID4gCj4gPiA+ICAJW0REUF9DT01QT05FTlRfQ09MT1IwXQk9IHsgTVRLX0RJU1BfQ09M T1IsCTAsICZkZHBfY29sb3IgfSwKPiA+ID4gIAlbRERQX0NPTVBPTkVOVF9DT0xPUjFdCT0geyBN VEtfRElTUF9DT0xPUiwJMSwgJmRkcF9jb2xvciB9LAo+ID4gPiAgCVtERFBfQ09NUE9ORU5UX0RQ STBdCT0geyBNVEtfRFBJLAkJMCwgTlVMTCB9LAo+ID4gCj4gPiBSZWdhcmRzLAo+ID4gQ0sKPiA+ IAo+ID4gCj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Tue, 13 Sep 2016 13:32:23 +0800 Subject: [PATCH v7 9/9] drm/mediatek: add support for Mediatek SoC MT2701 In-Reply-To: <1473675413.12398.29.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-10-git-send-email-yt.shen@mediatek.com> <1473226653.11736.33.camel@mtksdaap41> <1473675413.12398.29.camel@mtksdaap41> Message-ID: <1473744743.28437.26.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, YT: On Mon, 2016-09-12 at 18:16 +0800, YT Shen wrote: > Hi CK, > > On Wed, 2016-09-07 at 13:37 +0800, CK Hu wrote: > > Hi, YT: > > > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > > This patch add support for the Mediatek MT2701 DISP subsystem. > > > There is only one OVL engine in MT2701. > > > > > > Signed-off-by: YT Shen > > > > [snip...] > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > index 4b4e449..465819b 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > @@ -112,6 +112,7 @@ struct mtk_ddp_comp_match { > > > > > > static const struct mtk_ddp_comp_match mtk_ddp_matches[DDP_COMPONENT_ID_MAX] = { > > > [DDP_COMPONENT_AAL] = { MTK_DISP_AAL, 0, NULL }, > > > + [DDP_COMPONENT_BLS] = { MTK_DISP_PWM, 0, NULL }, > > > > I think BLS is different than PWM, so this statement should be > > > > [DDP_COMPONENT_BLS] = { MTK_DISP_BLS, 0, NULL }; > The BLS module actually is a multifunction device, one of them is the > PWM function. We only upstream PWM function [1] now, and it is > accepted. When there are real use case (gamma function), we will update > this part. What do you think? I think BLS = PWM + GAMMA and the device with register range from 0x1400a000 to 0x1400afff should be called BLS. I think this device is called PWM in [1] because it just use its PWM function and it's not suitable. At least in DRM driver, we should use the term BLS rather than PWM. Maybe we should define as below: [DDP_COMPONENT_BLS] = { MTK_DISP_BLS, 0, NULL }; and { .compatible = "mediatek,mt2701-disp-pwm", .data = (void *)MTK_DISP_BLS }, Regards, CK [1] https://patchwork.kernel.org/patch/9223001/ > > Regards, > yt.shen > > [1] https://patchwork.kernel.org/patch/9223001/ > > > > > > > > [DDP_COMPONENT_COLOR0] = { MTK_DISP_COLOR, 0, &ddp_color }, > > > [DDP_COMPONENT_COLOR1] = { MTK_DISP_COLOR, 1, &ddp_color }, > > > [DDP_COMPONENT_DPI0] = { MTK_DPI, 0, NULL }, > > > > Regards, > > CK > > > > > >