From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757698AbcIMJ0C (ORCPT ); Tue, 13 Sep 2016 05:26:02 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:28353 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1757142AbcIMJ0B (ORCPT ); Tue, 13 Sep 2016 05:26:01 -0400 Message-ID: <1473758754.28437.40.camel@mtksdaap41> Subject: Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function From: CK Hu To: YT Shen CC: , Philipp Zabel , David Airlie , Matthias Brugger , Daniel Kurtz , Mao Huang , Bibby Hsieh , "Daniel Vetter" , Thierry Reding , Jie Qiu , Maxime Ripard , Chris Wilson , shaoming chen , Jitao Shi , Boris Brezillon , Dan Carpenter , , , , , Sascha Hauer , , Date: Tue, 13 Sep 2016 17:25:54 +0800 In-Reply-To: <1473675381.12398.27.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-8-git-send-email-yt.shen@mediatek.com> <1473215632.11736.21.camel@mtksdaap41> <1473675381.12398.27.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, YT: On Mon, 2016-09-12 at 18:16 +0800, YT Shen wrote: > Hi CK, > > On Wed, 2016-09-07 at 10:33 +0800, CK Hu wrote: > > Hi, YT: > > > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > > From: shaoming chen > > > > > > add dsi read/write commands for transfer function > > > > > > Signed-off-by: shaoming chen > > > --- > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 188 +++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 188 insertions(+) > > > > > > > [snip...] > > > > > > > > +static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) > > > +{ > > > + dsi->irq_data &= ~irq_bit; > > > +} > > > + > > > > [snip...] > > > > > + > > > +static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, > > > + unsigned int timeout) > > > +{ > > > + s32 ret = 0; > > > + unsigned long jiffies = msecs_to_jiffies(timeout); > > > + > > > + ret = wait_event_interruptible_timeout(_dsi_irq_wait_queue, > > > + dsi->irq_data & irq_flag, > > > + jiffies); > > > + if (ret == 0) { > > > + dev_info(dsi->dev, "Wait DSI IRQ(0x%08x) Timeout\n", irq_flag); > > > + > > > + mtk_dsi_enable(dsi); > > > + mtk_dsi_reset_engine(dsi); > > > + } > > > + > > > + return ret; > > > +} > > > > I think mtk_dsi_irq_data_clear() and mtk_dsi_wait_for_irq_done() should > > be moved to the 6th patch [1] of this series because these two functions > > deal the irq control. > We will move mtk_dsi_irq_data_clear() to patch "drm/mediatek: add dsi > interrupt control" and put mtk_dsi_wait_for_irq_done() here, because it > is used in the transfer function. mtk_dsi_irq_data_clear() is also only used in transfer function now. I think both function could be used for other application rather than transfer function, so these two function are general function for irq control. Regards, CK > > Regards, > yt.shen > > > > > > [1] https://patchwork.kernel.org/patch/9310819/ > > > > > > Regards, > > CK > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function Date: Tue, 13 Sep 2016 17:25:54 +0800 Message-ID: <1473758754.28437.40.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-8-git-send-email-yt.shen@mediatek.com> <1473215632.11736.21.camel@mtksdaap41> <1473675381.12398.27.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1473675381.12398.27.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: YT Shen Cc: Daniel Vetter , Jie Qiu , Mao Huang , yingjoe.chen@mediatek.com, Dan Carpenter , Jitao Shi , Sascha Hauer , linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Matthias Brugger , shaoming chen , linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, Maxime Ripard List-Id: linux-mediatek@lists.infradead.org SGksIFlUOgoKT24gTW9uLCAyMDE2LTA5LTEyIGF0IDE4OjE2ICswODAwLCBZVCBTaGVuIHdyb3Rl Ogo+IEhpIENLLAo+IAo+IE9uIFdlZCwgMjAxNi0wOS0wNyBhdCAxMDozMyArMDgwMCwgQ0sgSHUg d3JvdGU6Cj4gPiBIaSwgWVQ6Cj4gPiAKPiA+IE9uIEZyaSwgMjAxNi0wOS0wMiBhdCAxOToyNCAr MDgwMCwgWVQgU2hlbiB3cm90ZToKPiA+ID4gRnJvbTogc2hhb21pbmcgY2hlbiA8c2hhb21pbmcu Y2hlbkBtZWRpYXRlay5jb20+Cj4gPiA+IAo+ID4gPiBhZGQgZHNpIHJlYWQvd3JpdGUgY29tbWFu ZHMgZm9yIHRyYW5zZmVyIGZ1bmN0aW9uCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBzaGFv bWluZyBjaGVuIDxzaGFvbWluZy5jaGVuQG1lZGlhdGVrLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBk cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RzaS5jIHwgMTg4ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxODggaW5zZXJ0aW9u cygrKQo+ID4gPiAKPiA+IAo+ID4gW3NuaXAuLi5dCj4gPiAKPiA+ID4gIAo+ID4gPiArc3RhdGlj IHZvaWQgbXRrX2RzaV9pcnFfZGF0YV9jbGVhcihzdHJ1Y3QgbXRrX2RzaSAqZHNpLCB1MzIgaXJx X2JpdCkKPiA+ID4gK3sKPiA+ID4gKwlkc2ktPmlycV9kYXRhICY9IH5pcnFfYml0Owo+ID4gPiAr fQo+ID4gPiArCj4gPiAKPiA+IFtzbmlwLi4uXQo+ID4gCj4gPiA+ICsKPiA+ID4gK3N0YXRpYyBz MzIgbXRrX2RzaV93YWl0X2Zvcl9pcnFfZG9uZShzdHJ1Y3QgbXRrX2RzaSAqZHNpLCB1MzIgaXJx X2ZsYWcsCj4gPiA+ICsJCQkJICAgICB1bnNpZ25lZCBpbnQgdGltZW91dCkKPiA+ID4gK3sKPiA+ ID4gKwlzMzIgcmV0ID0gMDsKPiA+ID4gKwl1bnNpZ25lZCBsb25nIGppZmZpZXMgPSBtc2Vjc190 b19qaWZmaWVzKHRpbWVvdXQpOwo+ID4gPiArCj4gPiA+ICsJcmV0ID0gd2FpdF9ldmVudF9pbnRl cnJ1cHRpYmxlX3RpbWVvdXQoX2RzaV9pcnFfd2FpdF9xdWV1ZSwKPiA+ID4gKwkJCQkJICAgICAg IGRzaS0+aXJxX2RhdGEgJiBpcnFfZmxhZywKPiA+ID4gKwkJCQkJICAgICAgIGppZmZpZXMpOwo+ ID4gPiArCWlmIChyZXQgPT0gMCkgewo+ID4gPiArCQlkZXZfaW5mbyhkc2ktPmRldiwgIldhaXQg RFNJIElSUSgweCUwOHgpIFRpbWVvdXRcbiIsIGlycV9mbGFnKTsKPiA+ID4gKwo+ID4gPiArCQlt dGtfZHNpX2VuYWJsZShkc2kpOwo+ID4gPiArCQltdGtfZHNpX3Jlc2V0X2VuZ2luZShkc2kpOwo+ ID4gPiArCX0KPiA+ID4gKwo+ID4gPiArCXJldHVybiByZXQ7Cj4gPiA+ICt9Cj4gPiAKPiA+IEkg dGhpbmsgbXRrX2RzaV9pcnFfZGF0YV9jbGVhcigpIGFuZCBtdGtfZHNpX3dhaXRfZm9yX2lycV9k b25lKCkgc2hvdWxkCj4gPiBiZSBtb3ZlZCB0byB0aGUgNnRoIHBhdGNoIFsxXSBvZiB0aGlzIHNl cmllcyBiZWNhdXNlIHRoZXNlIHR3byBmdW5jdGlvbnMKPiA+IGRlYWwgdGhlIGlycSBjb250cm9s Lgo+IFdlIHdpbGwgbW92ZSBtdGtfZHNpX2lycV9kYXRhX2NsZWFyKCkgdG8gcGF0Y2ggImRybS9t ZWRpYXRlazogYWRkIGRzaQo+IGludGVycnVwdCBjb250cm9sIiBhbmQgcHV0IG10a19kc2lfd2Fp dF9mb3JfaXJxX2RvbmUoKSBoZXJlLCBiZWNhdXNlIGl0Cj4gaXMgdXNlZCBpbiB0aGUgdHJhbnNm ZXIgZnVuY3Rpb24uCgptdGtfZHNpX2lycV9kYXRhX2NsZWFyKCkgaXMgYWxzbyBvbmx5IHVzZWQg aW4gdHJhbnNmZXIgZnVuY3Rpb24gbm93LiBJCnRoaW5rIGJvdGggZnVuY3Rpb24gY291bGQgYmUg dXNlZCBmb3Igb3RoZXIgYXBwbGljYXRpb24gcmF0aGVyIHRoYW4KdHJhbnNmZXIgZnVuY3Rpb24s IHNvIHRoZXNlIHR3byBmdW5jdGlvbiBhcmUgZ2VuZXJhbCBmdW5jdGlvbiBmb3IgaXJxCmNvbnRy b2wuCgpSZWdhcmRzLApDSwoKPiAKPiBSZWdhcmRzLAo+IHl0LnNoZW4KPiA+IAo+ID4gCj4gPiBb MV0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC85MzEwODE5Lwo+ID4gCj4gPiAK PiA+IFJlZ2FyZHMsCj4gPiBDSwo+ID4gCj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Tue, 13 Sep 2016 17:25:54 +0800 Subject: [PATCH v7 7/9] drm/mediatek: add dsi transfer function In-Reply-To: <1473675381.12398.27.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-8-git-send-email-yt.shen@mediatek.com> <1473215632.11736.21.camel@mtksdaap41> <1473675381.12398.27.camel@mtksdaap41> Message-ID: <1473758754.28437.40.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, YT: On Mon, 2016-09-12 at 18:16 +0800, YT Shen wrote: > Hi CK, > > On Wed, 2016-09-07 at 10:33 +0800, CK Hu wrote: > > Hi, YT: > > > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > > From: shaoming chen > > > > > > add dsi read/write commands for transfer function > > > > > > Signed-off-by: shaoming chen > > > --- > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 188 +++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 188 insertions(+) > > > > > > > [snip...] > > > > > > > > +static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) > > > +{ > > > + dsi->irq_data &= ~irq_bit; > > > +} > > > + > > > > [snip...] > > > > > + > > > +static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, > > > + unsigned int timeout) > > > +{ > > > + s32 ret = 0; > > > + unsigned long jiffies = msecs_to_jiffies(timeout); > > > + > > > + ret = wait_event_interruptible_timeout(_dsi_irq_wait_queue, > > > + dsi->irq_data & irq_flag, > > > + jiffies); > > > + if (ret == 0) { > > > + dev_info(dsi->dev, "Wait DSI IRQ(0x%08x) Timeout\n", irq_flag); > > > + > > > + mtk_dsi_enable(dsi); > > > + mtk_dsi_reset_engine(dsi); > > > + } > > > + > > > + return ret; > > > +} > > > > I think mtk_dsi_irq_data_clear() and mtk_dsi_wait_for_irq_done() should > > be moved to the 6th patch [1] of this series because these two functions > > deal the irq control. > We will move mtk_dsi_irq_data_clear() to patch "drm/mediatek: add dsi > interrupt control" and put mtk_dsi_wait_for_irq_done() here, because it > is used in the transfer function. mtk_dsi_irq_data_clear() is also only used in transfer function now. I think both function could be used for other application rather than transfer function, so these two function are general function for irq control. Regards, CK > > Regards, > yt.shen > > > > > > [1] https://patchwork.kernel.org/patch/9310819/ > > > > > > Regards, > > CK > > > >