From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758078AbcIMJ7l (ORCPT ); Tue, 13 Sep 2016 05:59:41 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:8382 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1757632AbcIMJ7k (ORCPT ); Tue, 13 Sep 2016 05:59:40 -0400 Message-ID: <1473760774.28437.53.camel@mtksdaap41> Subject: Re: [PATCH v7 8/9] drm/mediatek: update DSI sub driver flow From: CK Hu To: YT Shen CC: , Philipp Zabel , David Airlie , Matthias Brugger , Daniel Kurtz , Mao Huang , Bibby Hsieh , "Daniel Vetter" , Thierry Reding , Jie Qiu , Maxime Ripard , Chris Wilson , shaoming chen , Jitao Shi , Boris Brezillon , Dan Carpenter , , , , , Sascha Hauer , , Date: Tue, 13 Sep 2016 17:59:34 +0800 In-Reply-To: <1473675347.12398.24.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-9-git-send-email-yt.shen@mediatek.com> <1473224283.11736.27.camel@mtksdaap41> <1473675347.12398.24.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, YT: On Mon, 2016-09-12 at 18:15 +0800, YT Shen wrote: > Hi CK, > > On Wed, 2016-09-07 at 12:58 +0800, CK Hu wrote: > > Hi, YT: > > > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > > This patch update enable/disable flow of DSI module and MIPI TX module > > > > > > Signed-off-by: shaoming chen > > > Signed-off-by: YT Shen > > > --- > > > > I think the description is too simple. Please briefly describe WHY of > > this patch. The original enable/disable flow is workable, so why do you > > need this patch? Without this patch, what problem would happen? > Got it, we will update more descriptions in the next version. > There is no transfer/interrupt function in the upstream DSI driver. > We also implement the following function [1][2] in this patch series. > > Original flow works on there is a bridge chip: DSI -> bridge -> panel. > In this case: DSI -> panel, the DSI sub driver flow should be updated. > We need to initialize DSI first so that we can send commands to panel. > > [1] https://patchwork.kernel.org/patch/9310819/ > drm/mediatek: add dsi interrupt control > [2] https://patchwork.kernel.org/patch/9310823/ > drm/mediatek: add dsi transfer function > I suggest you to separate "DSI directly connect to panel" related patches to another series because MT8173 could also apply it and it is not essential for MT2701 if MT2701 use bridge IC for dsi. Regards, CK > > > > Regards, > > CK > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v7 8/9] drm/mediatek: update DSI sub driver flow Date: Tue, 13 Sep 2016 17:59:34 +0800 Message-ID: <1473760774.28437.53.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-9-git-send-email-yt.shen@mediatek.com> <1473224283.11736.27.camel@mtksdaap41> <1473675347.12398.24.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1473675347.12398.24.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: YT Shen Cc: Daniel Vetter , Jie Qiu , Mao Huang , yingjoe.chen@mediatek.com, Dan Carpenter , Jitao Shi , Sascha Hauer , linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Matthias Brugger , shaoming chen , linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, Maxime Ripard List-Id: linux-mediatek@lists.infradead.org SGksIFlUOgoKT24gTW9uLCAyMDE2LTA5LTEyIGF0IDE4OjE1ICswODAwLCBZVCBTaGVuIHdyb3Rl Ogo+IEhpIENLLAo+IAo+IE9uIFdlZCwgMjAxNi0wOS0wNyBhdCAxMjo1OCArMDgwMCwgQ0sgSHUg d3JvdGU6Cj4gPiBIaSwgWVQ6Cj4gPiAKPiA+IE9uIEZyaSwgMjAxNi0wOS0wMiBhdCAxOToyNCAr MDgwMCwgWVQgU2hlbiB3cm90ZToKPiA+ID4gVGhpcyBwYXRjaCB1cGRhdGUgZW5hYmxlL2Rpc2Fi bGUgZmxvdyBvZiBEU0kgbW9kdWxlIGFuZCBNSVBJIFRYIG1vZHVsZQo+ID4gPiAKPiA+ID4gU2ln bmVkLW9mZi1ieTogc2hhb21pbmcgY2hlbiA8c2hhb21pbmcuY2hlbkBtZWRpYXRlay5jb20+Cj4g PiA+IFNpZ25lZC1vZmYtYnk6IFlUIFNoZW4gPHl0LnNoZW5AbWVkaWF0ZWsuY29tPgo+ID4gPiAt LS0KPiA+IAo+ID4gSSB0aGluayB0aGUgZGVzY3JpcHRpb24gaXMgdG9vIHNpbXBsZS4gUGxlYXNl IGJyaWVmbHkgZGVzY3JpYmUgV0hZIG9mCj4gPiB0aGlzIHBhdGNoLiBUaGUgb3JpZ2luYWwgZW5h YmxlL2Rpc2FibGUgZmxvdyBpcyB3b3JrYWJsZSwgc28gd2h5IGRvIHlvdQo+ID4gbmVlZCB0aGlz IHBhdGNoPyBXaXRob3V0IHRoaXMgcGF0Y2gsIHdoYXQgcHJvYmxlbSB3b3VsZCBoYXBwZW4/Cj4g R290IGl0LCB3ZSB3aWxsIHVwZGF0ZSBtb3JlIGRlc2NyaXB0aW9ucyBpbiB0aGUgbmV4dCB2ZXJz aW9uLgo+IFRoZXJlIGlzIG5vIHRyYW5zZmVyL2ludGVycnVwdCBmdW5jdGlvbiBpbiB0aGUgdXBz dHJlYW0gRFNJIGRyaXZlci4KPiBXZSBhbHNvIGltcGxlbWVudCB0aGUgZm9sbG93aW5nIGZ1bmN0 aW9uIFsxXVsyXSBpbiB0aGlzIHBhdGNoIHNlcmllcy4KPiAKPiBPcmlnaW5hbCBmbG93IHdvcmtz IG9uIHRoZXJlIGlzIGEgYnJpZGdlIGNoaXA6IERTSSAtPiBicmlkZ2UgLT4gcGFuZWwuCj4gSW4g dGhpcyBjYXNlOiBEU0kgLT4gcGFuZWwsIHRoZSBEU0kgc3ViIGRyaXZlciBmbG93IHNob3VsZCBi ZSB1cGRhdGVkLgo+IFdlIG5lZWQgdG8gaW5pdGlhbGl6ZSBEU0kgZmlyc3Qgc28gdGhhdCB3ZSBj YW4gc2VuZCBjb21tYW5kcyB0byBwYW5lbC4KPiAKPiBbMV0gaHR0cHM6Ly9wYXRjaHdvcmsua2Vy bmVsLm9yZy9wYXRjaC85MzEwODE5Lwo+IGRybS9tZWRpYXRlazogYWRkIGRzaSBpbnRlcnJ1cHQg Y29udHJvbAo+IFsyXSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzkzMTA4MjMv Cj4gZHJtL21lZGlhdGVrOiBhZGQgZHNpIHRyYW5zZmVyIGZ1bmN0aW9uCj4gCgpJIHN1Z2dlc3Qg eW91IHRvIHNlcGFyYXRlICJEU0kgZGlyZWN0bHkgY29ubmVjdCB0byBwYW5lbCIgcmVsYXRlZApw YXRjaGVzIHRvIGFub3RoZXIgc2VyaWVzIGJlY2F1c2UgTVQ4MTczIGNvdWxkIGFsc28gYXBwbHkg aXQgYW5kIGl0IGlzCm5vdCBlc3NlbnRpYWwgZm9yIE1UMjcwMSBpZiBNVDI3MDEgdXNlIGJyaWRn ZSBJQyBmb3IgZHNpLgoKUmVnYXJkcywKQ0sKCj4gPiAKPiA+IFJlZ2FyZHMsCj4gPiBDSwo+ID4g Cj4gPiAKPiAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Tue, 13 Sep 2016 17:59:34 +0800 Subject: [PATCH v7 8/9] drm/mediatek: update DSI sub driver flow In-Reply-To: <1473675347.12398.24.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-9-git-send-email-yt.shen@mediatek.com> <1473224283.11736.27.camel@mtksdaap41> <1473675347.12398.24.camel@mtksdaap41> Message-ID: <1473760774.28437.53.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, YT: On Mon, 2016-09-12 at 18:15 +0800, YT Shen wrote: > Hi CK, > > On Wed, 2016-09-07 at 12:58 +0800, CK Hu wrote: > > Hi, YT: > > > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > > This patch update enable/disable flow of DSI module and MIPI TX module > > > > > > Signed-off-by: shaoming chen > > > Signed-off-by: YT Shen > > > --- > > > > I think the description is too simple. Please briefly describe WHY of > > this patch. The original enable/disable flow is workable, so why do you > > need this patch? Without this patch, what problem would happen? > Got it, we will update more descriptions in the next version. > There is no transfer/interrupt function in the upstream DSI driver. > We also implement the following function [1][2] in this patch series. > > Original flow works on there is a bridge chip: DSI -> bridge -> panel. > In this case: DSI -> panel, the DSI sub driver flow should be updated. > We need to initialize DSI first so that we can send commands to panel. > > [1] https://patchwork.kernel.org/patch/9310819/ > drm/mediatek: add dsi interrupt control > [2] https://patchwork.kernel.org/patch/9310823/ > drm/mediatek: add dsi transfer function > I suggest you to separate "DSI directly connect to panel" related patches to another series because MT8173 could also apply it and it is not essential for MT2701 if MT2701 use bridge IC for dsi. Regards, CK > > > > Regards, > > CK > > > > > >