All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Draszik" <git@andred.net>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] kernel-yocto: remove do_shared_workdir from SRCTREECOVEREDTASKS
Date: Tue, 13 Sep 2016 14:29:01 +0100	[thread overview]
Message-ID: <1473773341.5279.8.camel@andred.net> (raw)
In-Reply-To: <1473764984.5279.6.camel@andred.net>

Please unignore this patch :-) The patch does what I intended.

Sorry for the noise.

On Di, 2016-09-13 at 12:09 +0100, André Draszik wrote:
> Ignore this. This doesn't yet work as I intended I think.
> 
> On Di, 2016-09-13 at 10:07 +0100, André Draszik wrote:
> > 
> > Various recipes depend on the kernel's do_shared_workdir
> > task, a quick grep suggests all external kernel modules
> > (via module.bbclass), but also perf, and potentially any
> > additional headers as outlined in linux-libc-headers.inc
> > are affected.
> > 
> > Having do_shared_workdir in SRCTREECOVEREDTASKS means this
> > task is removed when externalsrc is enabled, making all
> > those recipes fail as the task they depend on,
> > virtual/kernel:do_shared_workdir, doesn't exist.
> > 
> > Remove do_shared_workdir from SRCTREECOVEREDTASKS so that
> > all those recipes work even if externalsrc is activated.
> > 
> > According to the comment in here, the reason for
> > do_shared_workdir to be removed as a task is because it
> > modifies the source tree, but that doesn't seem to be
> > case.
> > 
> > Signed-off-by: André Draszik <git@andred.net>
> > ---
> >  meta/classes/kernel-yocto.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-
> > yocto.bbclass
> > index 82b9210..53659f2 100644
> > --- a/meta/classes/kernel-yocto.bbclass
> > +++ b/meta/classes/kernel-yocto.bbclass
> > @@ -1,5 +1,5 @@
> >  # remove tasks that modify the source tree in case externalsrc is
> > inherited
> > -SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches
> > do_kernel_configcheck do_kernel_checkout do_shared_workdir do_fetch
> > do_unpack do_patch"
> > +SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches
> > do_kernel_configcheck do_kernel_checkout do_fetch do_unpack do_patch"
> >  
> >  # returns local (absolute) path names for all valid patches in the
> >  # src_uri


      reply	other threads:[~2016-09-13 13:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13  9:07 [PATCH] kernel-yocto: remove do_shared_workdir from SRCTREECOVEREDTASKS André Draszik
2016-09-13 11:09 ` André Draszik
2016-09-13 13:29   ` André Draszik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473773341.5279.8.camel@andred.net \
    --to=git@andred.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.