From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754705AbcINGTO (ORCPT ); Wed, 14 Sep 2016 02:19:14 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:58623 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750967AbcINGTN (ORCPT ); Wed, 14 Sep 2016 02:19:13 -0400 Message-ID: <1473833946.24354.8.camel@mtksdaap41> Subject: Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function From: YT Shen To: CK Hu CC: , Philipp Zabel , David Airlie , Matthias Brugger , Daniel Kurtz , Mao Huang , Bibby Hsieh , "Daniel Vetter" , Thierry Reding , Jie Qiu , Maxime Ripard , Chris Wilson , shaoming chen , Jitao Shi , Boris Brezillon , Dan Carpenter , , , , , Sascha Hauer , , Date: Wed, 14 Sep 2016 14:19:06 +0800 In-Reply-To: <1473758754.28437.40.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-8-git-send-email-yt.shen@mediatek.com> <1473215632.11736.21.camel@mtksdaap41> <1473675381.12398.27.camel@mtksdaap41> <1473758754.28437.40.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi CK, On Tue, 2016-09-13 at 17:25 +0800, CK Hu wrote: > Hi, YT: > > On Mon, 2016-09-12 at 18:16 +0800, YT Shen wrote: > > Hi CK, > > > > On Wed, 2016-09-07 at 10:33 +0800, CK Hu wrote: > > > Hi, YT: > > > > > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > > > From: shaoming chen > > > > > > > > add dsi read/write commands for transfer function > > > > > > > > Signed-off-by: shaoming chen > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 188 +++++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 188 insertions(+) > > > > > > > > > > [snip...] > > > > > > > > > > > +static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) > > > > +{ > > > > + dsi->irq_data &= ~irq_bit; > > > > +} > > > > + > > > > > > [snip...] > > > > > > > + > > > > +static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, > > > > + unsigned int timeout) > > > > +{ > > > > + s32 ret = 0; > > > > + unsigned long jiffies = msecs_to_jiffies(timeout); > > > > + > > > > + ret = wait_event_interruptible_timeout(_dsi_irq_wait_queue, > > > > + dsi->irq_data & irq_flag, > > > > + jiffies); > > > > + if (ret == 0) { > > > > + dev_info(dsi->dev, "Wait DSI IRQ(0x%08x) Timeout\n", irq_flag); > > > > + > > > > + mtk_dsi_enable(dsi); > > > > + mtk_dsi_reset_engine(dsi); > > > > + } > > > > + > > > > + return ret; > > > > +} > > > > > > I think mtk_dsi_irq_data_clear() and mtk_dsi_wait_for_irq_done() should > > > be moved to the 6th patch [1] of this series because these two functions > > > deal the irq control. > > We will move mtk_dsi_irq_data_clear() to patch "drm/mediatek: add dsi > > interrupt control" and put mtk_dsi_wait_for_irq_done() here, because it > > is used in the transfer function. > > mtk_dsi_irq_data_clear() is also only used in transfer function now. I > think both function could be used for other application rather than > transfer function, so these two function are general function for irq > control. We will rollback the changes here. Move mtk_dsi_irq_data_clear() to original place. Add new functions could be used in the future will have problems. warning: 'mtk_dsi_wait_for_irq_done' defined but not used [-Wunused-function] static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, warning: 'mtk_dsi_irq_data_clear' defined but not used [-Wunused-function] static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) > Regards, > CK > > > > > Regards, > > yt.shen > > > > > > > > > [1] https://patchwork.kernel.org/patch/9310819/ > > > > > > > > > Regards, > > > CK > > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: YT Shen Subject: Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function Date: Wed, 14 Sep 2016 14:19:06 +0800 Message-ID: <1473833946.24354.8.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-8-git-send-email-yt.shen@mediatek.com> <1473215632.11736.21.camel@mtksdaap41> <1473675381.12398.27.camel@mtksdaap41> <1473758754.28437.40.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1473758754.28437.40.camel@mtksdaap41> Sender: linux-kernel-owner@vger.kernel.org To: CK Hu Cc: dri-devel@lists.freedesktop.org, Philipp Zabel , David Airlie , Matthias Brugger , Daniel Kurtz , Mao Huang , Bibby Hsieh , Daniel Vetter , Thierry Reding , Jie Qiu , Maxime Ripard , Chris Wilson , shaoming chen , Jitao Shi , Boris Brezillon , Dan Carpenter , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel. List-Id: linux-mediatek@lists.infradead.org Hi CK, On Tue, 2016-09-13 at 17:25 +0800, CK Hu wrote: > Hi, YT: > > On Mon, 2016-09-12 at 18:16 +0800, YT Shen wrote: > > Hi CK, > > > > On Wed, 2016-09-07 at 10:33 +0800, CK Hu wrote: > > > Hi, YT: > > > > > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > > > From: shaoming chen > > > > > > > > add dsi read/write commands for transfer function > > > > > > > > Signed-off-by: shaoming chen > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 188 +++++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 188 insertions(+) > > > > > > > > > > [snip...] > > > > > > > > > > > +static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) > > > > +{ > > > > + dsi->irq_data &= ~irq_bit; > > > > +} > > > > + > > > > > > [snip...] > > > > > > > + > > > > +static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, > > > > + unsigned int timeout) > > > > +{ > > > > + s32 ret = 0; > > > > + unsigned long jiffies = msecs_to_jiffies(timeout); > > > > + > > > > + ret = wait_event_interruptible_timeout(_dsi_irq_wait_queue, > > > > + dsi->irq_data & irq_flag, > > > > + jiffies); > > > > + if (ret == 0) { > > > > + dev_info(dsi->dev, "Wait DSI IRQ(0x%08x) Timeout\n", irq_flag); > > > > + > > > > + mtk_dsi_enable(dsi); > > > > + mtk_dsi_reset_engine(dsi); > > > > + } > > > > + > > > > + return ret; > > > > +} > > > > > > I think mtk_dsi_irq_data_clear() and mtk_dsi_wait_for_irq_done() should > > > be moved to the 6th patch [1] of this series because these two functions > > > deal the irq control. > > We will move mtk_dsi_irq_data_clear() to patch "drm/mediatek: add dsi > > interrupt control" and put mtk_dsi_wait_for_irq_done() here, because it > > is used in the transfer function. > > mtk_dsi_irq_data_clear() is also only used in transfer function now. I > think both function could be used for other application rather than > transfer function, so these two function are general function for irq > control. We will rollback the changes here. Move mtk_dsi_irq_data_clear() to original place. Add new functions could be used in the future will have problems. warning: 'mtk_dsi_wait_for_irq_done' defined but not used [-Wunused-function] static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, warning: 'mtk_dsi_irq_data_clear' defined but not used [-Wunused-function] static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) > Regards, > CK > > > > > Regards, > > yt.shen > > > > > > > > > [1] https://patchwork.kernel.org/patch/9310819/ > > > > > > > > > Regards, > > > CK > > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: yt.shen@mediatek.com (YT Shen) Date: Wed, 14 Sep 2016 14:19:06 +0800 Subject: [PATCH v7 7/9] drm/mediatek: add dsi transfer function In-Reply-To: <1473758754.28437.40.camel@mtksdaap41> References: <1472815484-43821-1-git-send-email-yt.shen@mediatek.com> <1472815484-43821-8-git-send-email-yt.shen@mediatek.com> <1473215632.11736.21.camel@mtksdaap41> <1473675381.12398.27.camel@mtksdaap41> <1473758754.28437.40.camel@mtksdaap41> Message-ID: <1473833946.24354.8.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi CK, On Tue, 2016-09-13 at 17:25 +0800, CK Hu wrote: > Hi, YT: > > On Mon, 2016-09-12 at 18:16 +0800, YT Shen wrote: > > Hi CK, > > > > On Wed, 2016-09-07 at 10:33 +0800, CK Hu wrote: > > > Hi, YT: > > > > > > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote: > > > > From: shaoming chen > > > > > > > > add dsi read/write commands for transfer function > > > > > > > > Signed-off-by: shaoming chen > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 188 +++++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 188 insertions(+) > > > > > > > > > > [snip...] > > > > > > > > > > > +static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) > > > > +{ > > > > + dsi->irq_data &= ~irq_bit; > > > > +} > > > > + > > > > > > [snip...] > > > > > > > + > > > > +static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, > > > > + unsigned int timeout) > > > > +{ > > > > + s32 ret = 0; > > > > + unsigned long jiffies = msecs_to_jiffies(timeout); > > > > + > > > > + ret = wait_event_interruptible_timeout(_dsi_irq_wait_queue, > > > > + dsi->irq_data & irq_flag, > > > > + jiffies); > > > > + if (ret == 0) { > > > > + dev_info(dsi->dev, "Wait DSI IRQ(0x%08x) Timeout\n", irq_flag); > > > > + > > > > + mtk_dsi_enable(dsi); > > > > + mtk_dsi_reset_engine(dsi); > > > > + } > > > > + > > > > + return ret; > > > > +} > > > > > > I think mtk_dsi_irq_data_clear() and mtk_dsi_wait_for_irq_done() should > > > be moved to the 6th patch [1] of this series because these two functions > > > deal the irq control. > > We will move mtk_dsi_irq_data_clear() to patch "drm/mediatek: add dsi > > interrupt control" and put mtk_dsi_wait_for_irq_done() here, because it > > is used in the transfer function. > > mtk_dsi_irq_data_clear() is also only used in transfer function now. I > think both function could be used for other application rather than > transfer function, so these two function are general function for irq > control. We will rollback the changes here. Move mtk_dsi_irq_data_clear() to original place. Add new functions could be used in the future will have problems. warning: 'mtk_dsi_wait_for_irq_done' defined but not used [-Wunused-function] static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, warning: 'mtk_dsi_irq_data_clear' defined but not used [-Wunused-function] static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) > Regards, > CK > > > > > Regards, > > yt.shen > > > > > > > > > [1] https://patchwork.kernel.org/patch/9310819/ > > > > > > > > > Regards, > > > CK > > > > > > > > >