From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 05/18] drm/i915: Move GEM activity tracking into a common struct reservation_object Date: Wed, 14 Sep 2016 12:44:04 +0300 Message-ID: <1473846244.3924.35.camel@linux.intel.com> References: <20160914065250.15482-1-chris@chris-wilson.co.uk> <20160914065250.15482-6-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C378B6E703 for ; Wed, 14 Sep 2016 09:44:08 +0000 (UTC) In-Reply-To: <20160914065250.15482-6-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24ga2UsIDIwMTYtMDktMTQgYXQgMDc6NTIgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJ biBwcmVwYXJhdGlvbiB0byBzdXBwb3J0IG1hbnkgZGlzdGluY3QgdGltZWxpbmVzLCB3ZSBuZWVk IHRvIGV4cGFuZCB0aGUKPiBhY3Rpdml0eSB0cmFja2luZyBvbiB0aGUgR0VNIG9iamVjdCB0byBo YW5kbGUgbW9yZSB0aGFuIGp1c3QgYSByZXF1ZXN0Cj4gcGVyIGVuZ2luZS4gV2UgYWxyZWFkeSB1 c2UgdGhlIHN0cnVjdCByZXNlcnZhdGlvbl9vYmplY3Qgb24gdGhlIGRtYS1idWYKPiB0byBoYW5k bGUgbWFueSBmZW5jZSBjb250ZXh0cywgc28gaW50ZWdyYXRpbmcgdGhhdCBpbnRvIHRoZSBHRU0g b2JqZWN0Cj4gaXRzZWxmIGlzIHRoZSBwcmVmZXJyZWQgc29sdXRpb24uIChGb3IgZXhhbXBsZSwg d2UgY2FuIG5vdyBzaGFyZSB0aGUgc2FtZQo+IHJlc2VydmF0aW9uX29iamVjdCBiZXR3ZWVuIGV2 ZXJ5IGNvbnN1bWVyL3Byb2R1Y2VyIHVzaW5nIHRoaXMgYnVmZmVyIGFuZAo+IHNraXAgdGhlIG1h bnVhbCBpbXBvcnQvZXhwb3J0IHZpYSBkbWEtYnVmLikKPiAKPiBDYXZlYXRzOgoKSSdkIG1ha2Ug Y29tbWVudHMgd2hpY2ggcGF0Y2ggaW4gdGhlIHNlcmllcyBhZGRyZXNzZXMgZWFjaCBpbnRyb2R1 Y2VkCnByb2JsZW0sIHdoaWNoIGFyZSBmaXhhYmxlIGluIGZ1dHVyZSBhbmQgd2hpY2ggYXJlIHRh a2VuIGFzICJhCnBlcm1hbmVudCBoaXQiIGZvciBhY2hpZXZpbmcgbXVsdGlwbGUgdGltZWxpbmVz LiBXaXRoIGEgYml0IG9mCnJlYXNvbmluZyBmb3IgZWFjaCAobm93IG9ubHkgYSBmZXcgcG9pbnRz IGluY2x1ZGUgc29tZSBvZiB0aGlzKS4KCj4gwqBzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1faTkx NV9nZW1fb2JqZWN0ICoKPiBAQCAtMjM0NywzNSArMjM0MSwxMCBAQCBpOTE1X2dlbV9vYmplY3Rf aGFzX3N0cnVjdF9wYWdlKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4g wqAJcmV0dXJuIG9iai0+b3BzLT5mbGFncyAmIEk5MTVfR0VNX09CSkVDVF9IQVNfU1RSVUNUX1BB R0U7Cj4gwqB9Cj4gwqAKPiAtc3RhdGljIGlubGluZSB1bnNpZ25lZCBsb25nCj4gLWk5MTVfZ2Vt X29iamVjdF9nZXRfYWN0aXZlKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmop Cj4gLXsKPiAtCXJldHVybiAob2JqLT5mbGFncyA+PiBJOTE1X0JPX0FDVElWRV9TSElGVCkgJiBJ OTE1X0JPX0FDVElWRV9NQVNLOwo+IC19Cj4gLQo+IMKgc3RhdGljIGlubGluZSBib29sCj4gwqBp OTE1X2dlbV9vYmplY3RfaXNfYWN0aXZlKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0 ICpvYmopCj4gwqB7Cj4gLQlyZXR1cm4gaTkxNV9nZW1fb2JqZWN0X2dldF9hY3RpdmUob2JqKTsK PiAtfQo+IC0KPiAtc3RhdGljIGlubGluZSB2b2lkCj4gLWk5MTVfZ2VtX29iamVjdF9zZXRfYWN0 aXZlKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosIGludCBlbmdpbmUpCj4gLXsKPiAt CW9iai0+ZmxhZ3MgfD0gQklUKGVuZ2luZSArIEk5MTVfQk9fQUNUSVZFX1NISUZUKTsKPiAtfQo+ IC0KPiAtc3RhdGljIGlubGluZSB2b2lkCj4gLWk5MTVfZ2VtX29iamVjdF9jbGVhcl9hY3RpdmUo c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwgaW50IGVuZ2luZSkKPiAtewo+IC0Jb2Jq LT5mbGFncyAmPSB+QklUKGVuZ2luZSArIEk5MTVfQk9fQUNUSVZFX1NISUZUKTsKPiAtfQo+IC0K PiAtc3RhdGljIGlubGluZSBib29sCj4gLWk5MTVfZ2VtX29iamVjdF9oYXNfYWN0aXZlX2VuZ2lu ZShjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+IC0JCQkJwqDCoGludCBl bmdpbmUpCj4gLXsKPiAtCXJldHVybiBvYmotPmZsYWdzICYgQklUKGVuZ2luZSArIEk5MTVfQk9f QUNUSVZFX1NISUZUKTsKPiArCXJldHVybiBvYmotPmFjdGl2ZV9jb3VudDsKCm91ciB0eXBlIGlz IGJvb2wsIHNvICEhb2JqLT5hY3RpdmVfY291bnQ7Cgo+IMKgfQo+IAoKPFNOSVA+Cgo+IAo+IMKg c3RhdGljIGludAo+IMKgaTkxNV9nZW1fZXhlY2J1ZmZlcl9tb3ZlX3RvX2dwdShzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiDCoAkJCQlzdHJ1Y3QgbGlzdF9oZWFkICp2bWFzKQo+ IMKgewo+IC0JY29uc3QgdW5zaWduZWQgaW50IG90aGVyX3JpbmdzID0gZWJfb3RoZXJfZW5naW5l cyhyZXEpOwo+IMKgCXN0cnVjdCBpOTE1X3ZtYSAqdm1hOwo+IMKgCWludCByZXQ7Cj4gwqAKPiDC oAlsaXN0X2Zvcl9lYWNoX2VudHJ5KHZtYSwgdm1hcywgZXhlY19saXN0KSB7Cj4gwqAJCXN0cnVj dCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmogPSB2bWEtPm9iajsKPiAtCQlzdHJ1Y3QgcmVzZXJ2 YXRpb25fb2JqZWN0ICpyZXN2Owo+IC0KPiAtCQlpZiAob2JqLT5mbGFncyAmIG90aGVyX3Jpbmdz KSB7Cj4gLQkJCXJldCA9IGk5MTVfZ2VtX3JlcXVlc3RfYXdhaXRfb2JqZWN0Cj4gLQkJCQkocmVx LCBvYmosIG9iai0+YmFzZS5wZW5kaW5nX3dyaXRlX2RvbWFpbik7Cj4gLQkJCWlmIChyZXQpCj4g LQkJCQlyZXR1cm4gcmV0Owo+IC0JCX0KPiDCoAo+IC0JCXJlc3YgPSBpOTE1X2dlbV9vYmplY3Rf Z2V0X2RtYWJ1Zl9yZXN2KG9iaik7Cj4gLQkJaWYgKHJlc3YpIHsKPiAtCQkJcmV0ID0gaTkxNV9z d19mZW5jZV9hd2FpdF9yZXNlcnZhdGlvbgo+IC0JCQkJKCZyZXEtPnN1Ym1pdCwgcmVzdiwgJmk5 MTVfZmVuY2Vfb3BzLAo+IC0JCQkJwqBvYmotPmJhc2UucGVuZGluZ193cml0ZV9kb21haW4sIDEw KkhaLAo+IC0JCQkJwqBHRlBfS0VSTkVMIHwgX19HRlBfTk9XQVJOKTsKPiAtCQkJaWYgKHJldCA8 IDApCj4gLQkJCQlyZXR1cm4gcmV0Owo+IC0JCX0KPiArCQlyZXQgPSBpOTE1X2dlbV9yZXF1ZXN0 X2F3YWl0X29iamVjdAo+ICsJCQkocmVxLCBvYmosIG9iai0+YmFzZS5wZW5kaW5nX3dyaXRlX2Rv bWFpbik7CgpJIGtub3cgaXQgd2FzIHByZXZpb3VzbHkgbGlrZSB0aGlzLCBidXQgSSdtIG5vdCBz dXJlIEkgYWdyZWUgb24gdGhpcwpzdHlsZSBhdCBhbGwuCgo+IEBAIC0xMTkzNSwxNyArMTE5MzIs OCBAQCBzdGF0aWMgYm9vbCB1c2VfbW1pb19mbGlwKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu Z2luZSwKPiDCoAo+IMKgCWlmIChpOTE1LnVzZV9tbWlvX2ZsaXAgPCAwKQo+IMKgCQlyZXR1cm4g ZmFsc2U7Cj4gLQllbHNlIGlmIChpOTE1LnVzZV9tbWlvX2ZsaXAgPiAwKQo+IC0JCXJldHVybiB0 cnVlOwo+IC0JZWxzZSBpZiAoaTkxNS5lbmFibGVfZXhlY2xpc3RzKQo+IC0JCXJldHVybiB0cnVl Owo+IMKgCj4gLQlyZXN2ID0gaTkxNV9nZW1fb2JqZWN0X2dldF9kbWFidWZfcmVzdihvYmopOwo+ IC0JaWYgKHJlc3YgJiYgIXJlc2VydmF0aW9uX29iamVjdF90ZXN0X3NpZ25hbGVkX3JjdShyZXN2 LCBmYWxzZSkpCj4gLQkJcmV0dXJuIHRydWU7Cj4gLQo+IC0JcmV0dXJuIGVuZ2luZSAhPSBpOTE1 X2dlbV9hY3RpdmVfZ2V0X2VuZ2luZSgmb2JqLT5sYXN0X3dyaXRlLAo+IC0JCQkJCQnCoMKgwqDC oCZvYmotPmJhc2UuZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsJcmV0dXJuIHRydWU7CgoJcmV0dXJu IGk5MTVfdXNlX21taW9fZmxpcCA+PSAwOyAvLyA/Cgo+IEBAIC04NjAsMzkgKzg2MCw2IEBAIHN0 cnVjdCBkcm1faTkxNV9nZW1fYnVzeSB7Cj4gwqAJwqAqIGxvbmcgYXMgbm8gbmV3IEdQVSBjb21t YW5kcyBhcmUgZXhlY3V0ZWQgdXBvbiBpdCkuIER1ZSB0byB0aGUKPiDCoAnCoCogYXN5bmNocm9u b3VzIG5hdHVyZSBvZiB0aGUgaGFyZHdhcmUsIGFuIG9iamVjdCByZXBvcnRlZAo+IMKgCcKgKiBh cyBidXN5IG1heSBiZWNvbWUgaWRsZSBiZWZvcmUgdGhlIGlvY3RsIGlzIGNvbXBsZXRlZC4KPiAt CcKgKgo+IC0JwqAqIEZ1cnRoZXJtb3JlLCBpZiB0aGUgb2JqZWN0IGlzIGJ1c3ksIHdoaWNoIGVu Z2luZSBpcyBidXN5IGlzIG9ubHkKPiAtCcKgKiBwcm92aWRlZCBhcyBhIGd1aWRlLiBUaGVyZSBh cmUgcmFjZSBjb25kaXRpb25zIHdoaWNoIHByZXZlbnQgdGhlCj4gLQnCoCogcmVwb3J0IG9mIHdo aWNoIGVuZ2luZXMgYXJlIGJ1c3kgZnJvbSBiZWluZyBhbHdheXMgYWNjdXJhdGUuCj4gLQnCoCog SG93ZXZlciwgdGhlIGNvbnZlcnNlIGlzIG5vdCB0cnVlLiBJZiB0aGUgb2JqZWN0IGlzIGlkbGUs IHRoZQo+IC0JwqAqIHJlc3VsdCBvZiB0aGUgaW9jdGwsIHRoYXQgYWxsIGVuZ2luZXMgYXJlIGlk bGUsIGlzIGFjY3VyYXRlLgo+IC0JwqAqCj4gLQnCoCogVGhlIHJldHVybmVkIGR3b3JkIGlzIHNw bGl0IGludG8gdHdvIGZpZWxkcyB0byBpbmRpY2F0ZSBib3RoCj4gLQnCoCogdGhlIGVuZ2luZXMg b24gd2hpY2ggdGhlIG9iamVjdCBpcyBiZWluZyByZWFkLCBhbmQgdGhlCj4gLQnCoCogZW5naW5l IG9uIHdoaWNoIGl0IGlzIGN1cnJlbnRseSBiZWluZyB3cml0dGVuIChpZiBhbnkpLgo+IC0JwqAq Cj4gLQnCoCogVGhlIGxvdyB3b3JkIChiaXRzIDA6MTUpIGluZGljYXRlIGlmIHRoZSBvYmplY3Qg aXMgYmVpbmcgd3JpdHRlbgo+IC0JwqAqIHRvIGJ5IGFueSBlbmdpbmUgKHRoZXJlIGNhbiBvbmx5 IGJlIG9uZSwgYXMgdGhlIEdFTSBpbXBsaWNpdAo+IC0JwqAqIHN5bmNocm9uaXNhdGlvbiBydWxl cyBmb3JjZSB3cml0ZXMgdG8gYmUgc2VyaWFsaXNlZCkuIE9ubHkgdGhlCj4gLQnCoCogZW5naW5l IGZvciB0aGUgbGFzdCB3cml0ZSBpcyByZXBvcnRlZC4KPiAtCcKgKgo+IC0JwqAqIFRoZSBoaWdo IHdvcmQgKGJpdHMgMTY6MzEpIGFyZSBhIGJpdG1hc2sgb2Ygd2hpY2ggZW5naW5lcyBhcmUKPiAt CcKgKiBjdXJyZW50bHkgcmVhZGluZyBmcm9tIHRoZSBvYmplY3QuIE11bHRpcGxlIGVuZ2luZXMg bWF5IGJlCj4gLQnCoCogcmVhZGluZyBmcm9tIHRoZSBvYmplY3Qgc2ltdWx0YW5lb3VzbHkuCj4g LQnCoCoKPiAtCcKgKiBUaGUgdmFsdWUgb2YgZWFjaCBlbmdpbmUgaXMgdGhlIHNhbWUgYXMgc3Bl Y2lmaWVkIGluIHRoZQo+IC0JwqAqIEVYRUNCVUZGRVIyIGlvY3RsLCBpLmUuIEk5MTVfRVhFQ19S RU5ERVIsIEk5MTVfRVhFQ19CU0QgZXRjLgo+IC0JwqAqIE5vdGUgSTkxNV9FWEVDX0RFRkFVTFQg aXMgYSBzeW1ib2xpYyB2YWx1ZSBhbmQgaXMgbWFwcGVkIHRvCj4gLQnCoCogdGhlIEk5MTVfRVhF Q19SRU5ERVIgZW5naW5lIGZvciBleGVjdXRpb24sIGFuZCBzbyBpdCBpcyBuZXZlcgo+IC0JwqAq IHJlcG9ydGVkIGFzIGFjdGl2ZSBpdHNlbGYuIFNvbWUgaGFyZHdhcmUgbWF5IGhhdmUgcGFyYWxs ZWwKPiAtCcKgKiBleGVjdXRpb24gZW5naW5lcywgZS5nLiBtdWx0aXBsZSBtZWRpYSBlbmdpbmVz LCB3aGljaCBhcmUKPiAtCcKgKiBtYXBwZWQgdG8gdGhlIHNhbWUgaWRlbnRpZmllciBpbiB0aGUg RVhFQ0JVRkZFUjIgaW9jdGwgYW5kCj4gLQnCoCogc28gYXJlIG5vdCBzZXBhcmF0ZWx5IHJlcG9y dGVkIGZvciBidXN5bmVzcy4KPiAtCcKgKgo+IC0JwqAqIENhdmVhdCBlbXB0b3I6Cj4gLQnCoCog T25seSB0aGUgYm9vbGVhbiByZXN1bHQgb2YgdGhpcyBxdWVyeSBpcyByZWxpYWJsZTsgdGhhdCBp cyB3aGV0aGVyCj4gLQnCoCogdGhlIG9iamVjdCBpcyBpZGxlIG9yIGJ1c3kuIFRoZSByZXBvcnQg b2Ygd2hpY2ggZW5naW5lcyBhcmUgYnVzeQo+IC0JwqAqIHNob3VsZCBiZSBvbmx5IHVzZWQgYXMg YSBoZXVyaXN0aWMuCj4gwqAJwqAqLwoKRGFuaWVsIHRvIEFjayB0aGlzIEFCSSBjaGFuZ2UuCgpS ZXZpZXdlZC1ieTogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZUBsaW51eC5pbnRlbC5j b20+CgpEb3VibGUgY2hlY2sgYnkgc29tZWJvZHkgb24gdGhlIHBsYW5lIGNvZGUgd291bGQgbm90 IGh1cnQuCgpSZWdhcmRzLCBKb29uYXMKLS0gCkpvb25hcyBMYWh0aW5lbgpPcGVuIFNvdXJjZSBU ZWNobm9sb2d5IENlbnRlcgpJbnRlbCBDb3Jwb3JhdGlvbgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK